This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.
This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.
This update should result in no functional change.
For more information see the thread at
http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html
Change-Id: Ia90aa3c67fffb83ce0664e7745c5360e6d4e4214
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I4de2d37d36adddfdf4079a4f7f90955960a444e4
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I1ce08d6d828822572223b95a77c456759850cd5a
Add a xenial nodeset and update the spec helper to install puppet 3 from
the Ubuntu repos instead of from puppetlabs.
Change-Id: I54f9c9fe60aed608f89f35f12a91c42266cbb263
Allow to specify different key types for ed25519, for example
Depends-On: Ie842b25d38541e85cebfc0d11043aec836980173
Change-Id: I2a625c4dbb72f3ae1f9644636d635033be817465
Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: I237739d3ab679d961a7e8e6980af6893321b702b
Use same target directory for zuul-cloner and
the regular git command.
Change-Id: I7f55692b71961531fe9f5f066aaf87682297c6a7
Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com>
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Fix arrow
alignment errors now caught by the bundle-installed puppet-lint.
This patch makes $users::virtual::localuser::sshkeys a required
parameter to fix the puppet-lint-empty_string-check error. If left as
empty string and the default is used, the ssh_authorized_key resource
will still create the authorized_key entry but with an empty key, which
is not useful.
Change-Id: Ica35f012f3af74159fc8b2ae5df60d11d4c15f33
When key_id is not set, that is defaulting to blank,
and is causing duplication errors if two users don't have
it set. Defaulting to user title, to ensure that this
key will be unique per user.
Change-Id: Ie79e461483af9c44d53bb1ca5ed64687b4723f68
The http://ci.openstack.org/ documentation site has been deprecated,
replaced by redirects to corresponding paths within
http://docs.openstack.org/infra/ where other Project Infrastructure
documentation already resides.
Change-Id: I4ab8252de3d48ca125785ff7529060472ba4bf56
When creating a new user, ensure that the home folder, and the
.ssh one is created with the right ownership and
permissions.
Change-Id: I25167179a1573c4dbbc4a8703f5bb200af9709f5
Before we had set gid and uid to unset by default. Which if not
overridden will have puppet try to set the gid and uid values to
'unset'. This should be an error as 'unset' is not a number. We don't
have this error because we always override these values when creating
localusers. But for completeness and better error messages remove the
default values so that puppet requires users to have proper gid and uid
values.
Change-Id: I14667912b9239ea1c56123c18b0c13834f9c3cb6
Set uid and gid values for users that puppet creates so they are
consistent across all systems. Pick some arbitrary values for them
and set them for all current users. Remove users who haven't been
around for a while (their ssh keys should all be removed at this
point).
I do not know what puppet will do with existing users (whether it
will attempt to change their entries or not), so do not merge this
change until all existing servers have been updated.
Change-Id: Id77e767af792f41fe2f8551953a2cf621323b373
* modules/user/manifests/virtual/localuser.pp: This reverts part of
0d82c62 which was providing a temporary transition correcting
permissions and ownership as well as removing the results of a
previous failed implementation of keyfile management. Unfortunately
that also caused nodepool images to no longer set up accounts
correctly, but reverting the transitional bits fixes that issue.
Change-Id: Ic3e7f0a3b82bbc8a23707b88f9fe381e9d70e356
We need specific key ids for keys, and if the key id changes, we need
a way to delete old ones. We also need the file to be writable by at
least the user so that puppet doesn't complain.
Change-Id: I5718b80d844d5f95149d0e23d98960879955c43c
There is a builtin type for adding authorized_keys. We started
using it for the restricted access for the puppet triggering key,
and it seems to make sense to be consistent across the board.
Change-Id: I76ffb0136c58c05fa7c8abb793cb8e3b03cb5f6c
Changes:
groups now a variable with a preset, since there may be instances
where sudo/admin will NOT be desired.
home now entirely a variable, defaults to previous action, but
handles cases where created user may not belong in /home
managed home flag, defaulted to enabled.
No impact to current functionality. Allows for more granular changes
in the future. Typo fix for managehome.
Change-Id: Id0921f5b28ea0ffd2230d94e87673e6b39ac060e
This patch adds the user::virtual::disable function to the user module.
This will allow puppet to remove a user, ssh keys, and screen sessions
while preserving the user home directory.
This patch adds future functionality without impacting the currently
configured infrastructure.
Change-Id: I2933e6857094398f86c2a7e6eaabe9898a1d3078
This is a sytle guide update for puppet. Including definations within a
class is not recommented.
Change-Id: Id108d61dade1f99350691627236f1a13c12c10bc
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/14986
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
Killed trailing whitespace in the puppet repo files using
`sed -r 's/\s+$//'`. Skip binary files and html templates for lodgeit
and mailman.
Change-Id: Ib43493161d8f0e8fae1426b22fb1737832ca14cd
Reviewed-on: https://review.openstack.org/12969
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Includes:
Fixing jenkins sudoers from jeblair
Removing tarmac depend from jeblair
Remove wheel group from jeblair
Change-Id: I86ec23f7aeafc31cc70b0f3a648739bb7316fc61
OpenDev Sysadmins