Merge "Improve test coverage: project API"

2015-12-03 16:12:51 +00:00 · 2015-12-03 16:12:51 +00:00 · 5662df15f0
parent d20c995512 f16ec0527a
commit 5662df15f0
1 changed files with 120 additions and 0 deletions
--- a/shade/tests/unit/test_project.py
+++ b/shade/tests/unit/test_project.py
@ -0,0 +1,120 @@
+# -*- coding: utf-8 -*-
+
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+
+import mock
+
+import munch
+import os_client_config as occ
+import testtools
+
+import shade
+from shade.tests.unit import base
+
+
+class TestProject(base.TestCase):
+
+    def setUp(self):
+        super(TestProject, self).setUp()
+        self.cloud = shade.operator_cloud(validate=False)
+
+    @mock.patch.object(occ.cloud_config.CloudConfig, 'get_api_version')
+    @mock.patch.object(shade.OpenStackCloud, 'keystone_client')
+    def test_create_project_v2(self, mock_keystone, mock_api_version):
+        mock_api_version.return_value = '2'
+        name = 'project_name'
+        description = 'Project description'
+        self.cloud.create_project(name=name, description=description)
+        mock_keystone.tenants.create.assert_called_once_with(
+            project_name=name, description=description, enabled=True,
+            tenant_name=name
+        )
+
+    @mock.patch.object(occ.cloud_config.CloudConfig, 'get_api_version')
+    @mock.patch.object(shade.OpenStackCloud, 'keystone_client')
+    def test_create_project_v3(self, mock_keystone, mock_api_version):
+        mock_api_version.return_value = '3'
+        name = 'project_name'
+        description = 'Project description'
+        domain_id = '123'
+        self.cloud.create_project(name=name, description=description,
+                                  domain_id=domain_id)
+        mock_keystone.projects.create.assert_called_once_with(
+            project_name=name, description=description, enabled=True,
+            name=name, domain=domain_id
+        )
+
+    @mock.patch.object(occ.cloud_config.CloudConfig, 'get_api_version')
+    @mock.patch.object(shade.OpenStackCloud, 'keystone_client')
+    def test_create_project_v3_no_domain(self, mock_keystone,
+                                         mock_api_version):
+        mock_api_version.return_value = '3'
+        with testtools.ExpectedException(
+                shade.OpenStackCloudException,
+                "User creation requires an explicit domain_id argument."
+        ):
+            self.cloud.create_project(name='foo', description='bar')
+
+    @mock.patch.object(occ.cloud_config.CloudConfig, 'get_api_version')
+    @mock.patch.object(shade.OpenStackCloud, 'update_project')
+    @mock.patch.object(shade.OpenStackCloud, 'keystone_client')
+    def test_delete_project_v2(self, mock_keystone, mock_update,
+                               mock_api_version):
+        mock_api_version.return_value = '2'
+        mock_update.return_value = dict(id='123')
+        self.cloud.delete_project('123')
+        mock_update.assert_called_once_with('123', enabled=False)
+        mock_keystone.tenants.delete.assert_called_once_with(tenant='123')
+
+    @mock.patch.object(occ.cloud_config.CloudConfig, 'get_api_version')
+    @mock.patch.object(shade.OpenStackCloud, 'update_project')
+    @mock.patch.object(shade.OpenStackCloud, 'keystone_client')
+    def test_delete_project_v3(self, mock_keystone, mock_update,
+                               mock_api_version):
+        mock_api_version.return_value = '3'
+        mock_update.return_value = dict(id='123')
+        self.cloud.delete_project('123')
+        mock_update.assert_called_once_with('123', enabled=False)
+        mock_keystone.projects.delete.assert_called_once_with(project='123')
+
+    @mock.patch.object(shade.OpenStackCloud, 'get_project')
+    def test_update_project_not_found(self, mock_get_project):
+        mock_get_project.return_value = None
+        with testtools.ExpectedException(
+                shade.OpenStackCloudException,
+                "Project ABC not found."
+        ):
+            self.cloud.update_project('ABC')
+
+    @mock.patch.object(occ.cloud_config.CloudConfig, 'get_api_version')
+    @mock.patch.object(shade.OpenStackCloud, 'get_project')
+    @mock.patch.object(shade.OpenStackCloud, 'keystone_client')
+    def test_update_project_v2(self, mock_keystone, mock_get_project,
+                               mock_api_version):
+        mock_api_version.return_value = '2'
+        mock_get_project.return_value = munch.Munch(dict(id='123'))
+        self.cloud.update_project('123', description='new', enabled=False)
+        mock_keystone.tenants.update.assert_called_once_with(
+            description='new', enabled=False, tenant_id='123')
+
+    @mock.patch.object(occ.cloud_config.CloudConfig, 'get_api_version')
+    @mock.patch.object(shade.OpenStackCloud, 'get_project')
+    @mock.patch.object(shade.OpenStackCloud, 'keystone_client')
+    def test_update_project_v3(self, mock_keystone, mock_get_project,
+                               mock_api_version):
+        mock_api_version.return_value = '3'
+        mock_get_project.return_value = munch.Munch(dict(id='123'))
+        self.cloud.update_project('123', description='new', enabled=False)
+        mock_keystone.projects.update.assert_called_once_with(
+            description='new', enabled=False, project='123')