Commit Graph

120 Commits

Author SHA1 Message Date
Monty Taylor 6f3a2792cc Switch to ansible on review-dev
The review-dev service playbook should do everything now that
the puppet did. Update how we're running things.

Change-Id: I70303c48328ea6713c24bf9c6f63d4808d30b95c
2020-01-14 12:04:15 -06:00
Sorin Sbarnea 3792315db5 Recognize DISK_FULL failure messages (review_dev)
When a job is killed by zuul due to failure like DISK_FULL, a different
message ends up in as a comment.

<li>job-name
finger://ze09.openstack.org/8b6d...6f : DISK_FULL in 2h 59m 50s</li>

This adds another pattern that recognize these messages as failures,
regardess the case (DISK_FULL in this case).

Change-Id: Ib17f05a043430362b02a2826d69572f6b2dbd64a
Needed-By: https://review.opendev.org/#/c/631509/
2019-08-01 11:47:09 +01:00
David Moreau Simard 8ed05c1340
Enable gerrit replication.autoReload for review-dev
This enables automatic reload of the replication configuration for
review-dev.

Depends-On: https://review.openstack.org/650049
Change-Id: I3be630339870d527bedcfbd84b8dc8084dc10f4b
2019-04-04 12:48:16 -04:00
Clark Boylan f963225dcd Use correct 2.13.12 war on review-dev
This war is based on merged code and is hosted permanently (unlike the
war hosted on our logs server that we were testing with earlier). If
this ends up being a happy war we'll deploy it to production.

Change-Id: I7a0ca93f0cd7a9eed19172d315000c3b7e4464b7
2019-01-15 14:22:05 -08:00
Clark Boylan 767e6c6921 Test new Gerrit 2.13.12 war on review-dev
This updates the gerrit isntall on review-dev to 2.13.12 + our 8 local
patches. Will need to restart gerrit and make sur ethat things are
happy.

In particular this update comes with jgit updates.

Change-Id: Iebd5617a9e516381100d424ce5749b4cbf866ab2
2019-01-11 13:06:31 -08:00
Jeremy Stanley 04c3294893 Hyperlink task footers on review-dev
Add a commentlink entry which matches task footers in commit
messages and links them to the corresponding task URL on
storyboard-dev. This has already been tested manually on review-dev,
and seems to work without breaking the separate its-storyboard entry
which handles task updating automation.

Change-Id: Iea9bde67432249e7314917ff63d6ee5e16a80f25
2018-10-03 19:56:15 +00:00
Zuul 423ade7d43 Merge "Double the gerrit regex backslashes" 2018-09-27 18:31:15 +00:00
Monty Taylor dfe891af3e
Double the gerrit regex backslashes
The current amount of backslashes is not good enough for gerrit, and it
rejects the config file. Probably related to futureparser? In any case,
we need doubled-backslashes in the generated file, so 4 backslashes does
the right thing in the puppet.

Change-Id: I950b8efbcb876b2d1309f1117626a41ef22025b0
2018-09-27 08:17:53 -05:00
Monty Taylor 19712f93e7
Only replicate gtest-org and kdc
Test replication constraints on review-dev.

Change-Id: Icce6be35bc0e14b1d75c4967b0cd4972075c8762
2018-09-26 12:10:29 -05:00
Monty Taylor bab6fcad3c
Remove base.yaml things from openstack_project::server
Now that we've got base server stuff rewritten in ansible, remove the
old puppet versions.

Depends-On: https://review.openstack.org/588326
Change-Id: I5c82fe6fd25b9ddaa77747db377ffa7e8bf23c7b
2018-08-16 17:25:10 -05:00
Jeremy Stanley fca20ebe84 Comment on linked stories for review state changes
Configure the its-storyboard Gerrit plugin to leave comments with
hyperlinks on stories mentioned in a change's commit message footer
whenever that change gets a new patchset, or is abandoned or merged.
This now must be explicitly configured for the version of the plugin
used with newer Gerrit (circa 2.13).

Change-Id: I14dea61a906c4b267145dce6911a10d8075b4ba9
2018-04-13 20:14:09 +00:00
Paul Belanger 01899d7ab8
Add gerrit_configure flag to review-dev01.o.o
This will allow us to bootstrap a server with gerrit users, then
attach the volumes with hold the git repos for gerrit, then we can
remove this flag and properly puppet the rest of the server.

Change-Id: I9159c941ece4f6928204601b9933d7a953baa2dd
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2018-03-20 15:35:05 -04:00
Ian Wienand e0e08a3613 Remove precise references
Remove the sources.list

From review.pp, don't set java_home.  The puppet-gerrit module figures
it out automatically.

For review-dev.pp, it seems java paths are used to import keys for
storyboard.  Add matching logic for that.

Remove precise only workaround in status.o.o

[1] https://git.openstack.org/cgit/openstack-infra/puppet-gerrit/tree/manifests/init.pp#n274

Change-Id: I31c9196a32febf4760b897a3110150fcd581e173
2018-02-16 10:11:53 +11:00
Ian Wienand 60b89d662e Remove ci-backup-rs-ord.openstack.org
Migrate backups to new backup01.ord.rax.ci.openstack.org

We decided to start fresh backups on the new server, so this is ready
to go.  I have performed an initial backup on each server so it has
accepted the host key of the new server and been tested (I also fixed
up review-dev.o.o, which was rebuilt but keys not updated ... todo:
add this to puppet, but since it changes so infrequently not high
priority).

Change-Id: I0872f9fcf4a334d32f632b3cb04801deefab4fd1
2017-11-15 09:28:55 +11:00
Jeremy Stanley d5dad4fd09 Stop using the Gerrit Contact Store
As part of the "Gerrit ContactStore Removal" specification, now that
owners.py is checking foundation membership when generating voter
rolls it's fine for us to stop using requireContactInformation on
the ICLA and rip out our accompanying configuration.

Note that this should not be merged until the All-Projects config on
review.openstack.org and review-dev.openstack.org has been manually
adjusted to remove the "requireContactInformation = true" line from
the [contributor-agreement "ICLA"] section therein. Further, this
must be done by pushing the necessary edit directly into
refs/meta/config as there is no WebUI control nor API method to
alter contributor-agreement options.

Change-Id: I8c39a6bf43f5b12db3e8aab18bedbf7e1a0f0b7e
Story: #2001094
Task: #4867
2017-08-04 20:24:37 +00:00
Clark Boylan 6dcd47daa2 Explicitly set utf8 on gerrit jdbc url
Testing on review-dev has shown that gerrit won't honor utf8 characters
without explicitly enabling utf8 on the jdbc url string. Add utf8
parameters to the jdbc connection url for the accountPatchReviewDb on
review_dev.

Change-Id: Ib24a7e53e290cc32e9842d524d51a381aace181a
2017-07-25 10:49:15 -07:00
Khai Do c857584ce7 upgrade review-dev.o.o with gerrit v2.13.9
This updates the gerrit war, plugin versions, and sets the new
accountPatchReviewDb url value to use mysql. Also uses updated Gerrit
query api paths for changeid and sha1 lookups in commentlinks.

Depends-On: Ifc04395f076200a68e6398190a0712c80e5278c6
Change-Id: Ic1a116b1608eb9134d18dad9463b9b9b142700fa
2017-07-05 10:57:10 -07:00
Monty Taylor bf456b38d1
Revert "Setup known_hosts file on gerrit servers"
The key is not in heira.

This reverts commit 956372cd39.

Change-Id: I19bc0f418318edc839c4eca168cd3c05ac7655f0
2017-04-07 05:40:09 -05:00
Khai Do 956372cd39 Setup known_hosts file on gerrit servers
Setup known_hosts file on review.o.o and review-dev.o.o so that
known services connecting to it won't be blocked.

Change-Id: If0b082867df73322a9115b94ea5be18d0631acc0
depends-on: I0bb6638f5362696cd9a9a7401cb2e96ab69eea06
2017-03-28 22:14:35 -07:00
Khai Do c56cd2c409 upgrade Gerrit's javamelody plugin on review-dev.o.o
upgrade Gerrit's javamelody plugin[1] on review-dev.o.o
This brings in an upstream change[2] to update javamelody to version
1.60.0

NOTE: Approving this change will kill Gerrit due to a bug, the change
to fix[3] this bug is uncommited atm.  The way to avoid the bug is
to stop Gerrit, approve this change, allow puppet to propogate
the update then start Gerrit.

[1] http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/javamelody-1de5d37.jar
[2] 1de5d373af
[3] https://review.openstack.org/#/c/268689/

Change-Id: I33102ce76521c5ffc25f83d3d2022f87f9732f18
2016-09-06 14:21:42 -07:00
Jenkins c1f2cf432a Merge "Make Launchpad credentials reusable" 2016-08-26 14:13:28 +00:00
Jeremy Stanley 9a612ee9bc Make Launchpad credentials reusable
Refactor and rename our Launchpad "sync" credentials (they haven't
been used to synchronize group membership from LP to Gerrit for
nearly 4 years now) which currently perform bug updates for
new/merged changes, so that they can be reused in the future to
update bugs as a part of release automation jobs.

Change-Id: Icd08dffef88fc8e99683d991ac6ac88b93bcb3e6
2016-08-17 18:29:36 +00:00
Jeremy Stanley da6513a87f Test Gerrit CI comment regex for rel="nofollow"
Now that we're running with a backport of
https://gerrit-review.googlesource.com/80320 from upstream, the
hyperlinks in comments include a rel="nofollow" parameter. Our
regular expression for these entries needs to take that into
account, so give it a try on review-dev.

Change-Id: Ida090f45cfdfb41c43c4ba1157f0478fc0936a20
2016-08-13 16:02:15 +00:00
Khai Do 3e93a9c15b Workaround for its-storyboard change-restored event
The change-restored event isn't getting process by the its-storyboard
plugin due to spaces in the config string.  This is a bug in plugin
and should be fixed. Until then this change is a workaround so that the
change-restored event will get processed.

Change-Id: Ic4489d029ce8409520f16c23a676125c7b3ab164
2016-08-09 10:49:32 -07:00
Jenkins 391a0c46df Merge "Upgrade gerrit on review-dev.o.o" 2016-08-09 16:13:16 +00:00
Jenkins 39e6037261 Merge "Update its-storyboard actions on review-dev.o.o" 2016-08-09 16:08:57 +00:00
Khai Do 79fe6fc022 Upgrade gerrit on review-dev.o.o
This upgrade does not require a reindex. It will pull in the following
changes:

277538  Append submitted info to the change REST endpoint.
267927  Remove required access permission to list account emails
340157  Update Google gson library to 2.3.1
345540  Add rel=nofollow parameter to links in comments
311903  Use maven repos for bouncy castle resources
260324  Add syntax highlighting support for puppet

Change-Id: I81553738f4cbbcdc3db9bd02325f0e254d9f4289
2016-08-08 21:34:20 +00:00
Khai Do 0cf12e7796 Fix setup of server certificate for its-storyboard
Using 'secret' for the keystore password doesn't work.  The default
password for it is 'changeit'[1]

[1] https://docs.oracle.com/cd/E19798-01/821-1841/gjrgy/index.html

Change-Id: I99abfffc3c0535e8856fc431dcf561bdb078d134
2016-08-04 11:46:45 -07:00
Khai Do 39d379dd01 Update its-storyboard actions on review-dev.o.o
Update its-storyboard actions on review-dev.o.o to be same as on
review.o.o so it will provide more prod like testing environment.
This is basically turning off commenting to storyboard and instead
just enables task transitions.

Change-Id: I1b5a7109d90f0b3ad67afe41b43d8cbe5de471d9
2016-08-04 09:19:46 -07:00
Khai Do ced4ae3e89 Install its-storyboard plugin on review-dev.o.o
Install Gerrit its-storyboard plugin[1] to support integration between
gerrit and storyboard. Install the plugin from tarballs.o.o[2] to
review-dev.o.o for testing.

Additional requirement for this change to take effect:
1. A parameter needs to be set to enable its-storyboard plugin.  This
   is a per project setting in refs/meta/config (project.config file)
   If we want to enable for all project then set this param in
   All-Projects:
    [plugin "its-storyboard"]
      enabled = true

[1] https://gerrit.googlesource.com/plugins/its-storyboard
[2] http://tarballs.openstack.org/ci/gerrit/plugins/its-storyboard

Change-Id: Ida9c7ece6b53df10da1a95291ec2b2de1adb7fbd
2016-07-26 09:50:21 -07:00
Khai Do f1ca18ebfd Configure its-storyboard plugin
Add configurations for the its-storyboard plugin:
1. Move java_home variable to a higher level module so it can be used
   to install certificate on review-dev.o.o
2. Configure its-storyboard for review.o.o and review-dev.o.o
3. Associate review.o.o with storyboard.o.o and review-dev.o.o with
   storyboard-dev.o.o
4. Import ssl certificate to java on review-dev.o.o so that the plugin
   can POST updates to storyboard-dev.o.o using storyboard REST APIs.
5. Configure rules (or conditions) telling its-plugin to update
   storyboard tasks status on specific gerrit change updates.

Gerrit change to storyboard task transition mapping:
change abandoned -> SB task set to 'todo'
change createed or change restored -> SB task set to 'review'
change merged -> SB task set to 'merged'

Change-Id: Id6ec16e267fca5fbbc42b1d3547fc5d2fa4c671b
depends-on: I9f47a2ed88ffbe827e494a478c0dc89a08bbe370
depends-on: I5e817fab8a8973b688fd44dd819e3616df171321
2016-07-26 09:29:17 -07:00
Khai Do db5b77804e Install the Gerrit delete-project plugin on review-dev.o.o
Install Gerrit delete-project plugin[1] to allow us to clean up
deprecated repos. Install the plugin from tarballs.o.o[2] to
review-dev.o.o for testing.

[1] https://gerrit.googlesource.com/plugins/delete-project/+/stable-2.11/src/main/resources/Documentation/about.md
[2] http://tarballs.openstack.org/ci/gerrit/plugins/delete-project

Change-Id: I3b3687b4e905c85b5d50f35c70b187137a9e0f2f
2016-07-25 14:12:29 -07:00
Khai Do 169496396b Refactor gerrit commentlinks parameter
Refactor the commentlinks to allow review.o.o and review-dev.o.o to
define seperate comment links.  We essentially want to point
review.o.o story links to storyboard.o.o and review-dev.o.o links to
storyboard-dev.o.o

Change-Id: I70e5791a76ca97756613c393e598978ec13c8271
2016-06-16 23:14:34 -07:00
Jenkins df520b64cd Merge "Update javamelody plugin on review-dev.o.o" 2015-12-14 20:05:36 +00:00
Khai Do 00f0524038 Bump Gerrit version on review-dev.o.o
Bump Gerrit version to match the one on review.o.o

Change-Id: Idb13b799cf6b36596fa63c69486ac020a3334869
2015-12-14 17:50:58 +00:00
Khai Do 4eff3079f7 Update javamelody plugin on review-dev.o.o
Update Javamelody plugin from stable-2.11 for Gerrit 2.11

plugin from here:
   http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/

Change-Id: Iabe4ee454b3b4d6452469a6db7fbaaac780abc31
2015-12-13 15:22:56 -08:00
Jenkins 30858cca08 Merge "Update plugin version for Gerrit 2.11 on review-dev.o.o" 2015-12-11 20:09:08 +00:00
Philip Marc Schwartz 4a1809b50d Pull o_p::server out of gerrit role
Change-Id: Ia028637e1b9c91284d3f1476322ae486cd54d63f
Signed-off-by: Philip Marc Schwartz <pschwar@linux.vnet.ibm.com>
2015-11-19 13:57:58 -05:00
Khai Do 62f77b1f02 Update plugin version for Gerrit 2.11 on review-dev.o.o
plugin from here:
  http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/

Change-Id: I6218af6034ab0ce4af647418bc1348067d2417c9
2015-11-14 13:16:00 -08:00
Jenkins b77133c91f Merge "Generate cgit links with '/' character instead of '%2F'" 2015-11-03 06:26:48 +00:00
Khai Do 47c9050620 Update review-dev.o.o to Gerrit ver 2.11
Change-Id: Ifdcc14af698883ea5dcdf714fb80f3ac20d89493
2015-10-21 14:48:40 -07:00
Khai Do 9c9eae01cd Generate cgit links with '/' character instead of '%2F'
The generated cgit links in the Gerrit change screen contain "%2F" in URL
instead of "/" character.  Add the urlEncode setting to make Gerrit
generate links with "/" character instead.

Change-Id: I07d1b3175c039bba0d8b7392c756fa6a5b2e74e9
depends-on: I0ed9f2e872617d601120a5ab15b512e30aae51b5
2015-10-16 12:04:50 -07:00
Khai Do 2d7bf19e74 Update Gerrit to newer 2.10 build on review-dev.o.o
Depends-on: I03d6e57f809d424f79a98c82c812202f0cfdd9c0
Change-Id: I2e55bf6964b48dafe5045e002cb59c8e87d217ee
2015-05-08 17:30:21 +00:00
Jenkins 8e1b08e7e1 Merge "Allow puppet to manage replication keys on review-dev.o.o" 2015-04-21 18:26:23 +00:00
Khai Do 436ad97d59 Allow puppet to manage replication keys on review-dev.o.o
Change-Id: I284379cc69349037db4bf7dfd52e22d22b34d465
2015-04-16 11:18:20 -07:00
Khai Do cea213eb96 update Gerrit javamelody plugin on review-dev.o.o
Change Ieecb4f03b72 added a job to build javamelody from stable-2.10
branch [1].  Since review-dev.o.o is now running Gerrit 2.10 we need
to update the javamelody plugin.

[1] https://gerrit.googlesource.com/plugins/javamelody/+/stable-2.10

Change-Id: I1c5977ab09f8689ee27d743725191ef131da0fcb
2015-04-13 12:25:18 -07:00
Khai Do ad73df5cbb upgrade review-dev to Gerrit ver 2.10
Change-Id: I1a1aeb3ba2d5cb1bebf98511b3c0f06926e330d9
2015-04-09 16:33:35 -07:00
Jenkins d9f52c509e Merge "Add the Gerrit replication plugin paramater 'defaultForceUpdate'" 2015-03-17 14:37:39 +00:00
Khai Do f8b23c9043 Update the Gerrit javamelody plugin version on review-dev.o.o
Change Ia931d053cbf setup a build for javamelody with Gerrit-2.9.x
This change Updates the javamelody plugin version on review-dev.o.o to the
new javamelody build.

The file is at http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/

Change-Id: I431043bec2cd0815334cde24480307200166bf32
2015-03-05 12:14:09 -08:00
Khai Do dba3b2c560 Upgrade Gerrit from 2.8 to ver 2.9 for review-dev.o.o
Change-Id: Ie89c02d575de4f9ef82833a2e1b1807bf3856ad1
2015-02-19 22:46:07 -08:00