Change I37337b9d07ace4 disabled the use of jeepyb's trivial rebase
script however the puppet for it still exists. There's really no need
to keep the option around in the puppet manifest so this change just
removes it.
Change-Id: I101e385823a110a74b3060ad11e3e528d5048d9f
* .../templates/gerrit_patchset-created.erb: The SSH user and key
for the welcome-message hook script are now options instead of
positional parameters. Also, the user is a short name not a full
E-mail address.
Change-Id: Ibcb70068db89ec75a4b284340206718fd9d10e96
After extensive fixing from Jeremey and the Infrastructure
team, welcome message now detects newbies correctly.
The code has been run for a week in dry-run mode, and has
been verified to produce no false positives.
This patch removes the dry run option from the hook, to enable
welcome message to post welcoming messages on reviews from first-
time contributors.
Change-Id: I5dd072d36480294eefc23aa6376ae0a686621b08
The welcome-message script uses SSH arguments that are the same
as expire-old-reviews, not trivial-rebase. This patch updates
the hook script to use the correct CLI arguments.
Change-Id: Ib771e2a8cf4b770878dd24c72efd80344e62f754
This patch adds the welcome message script to the patchset-created
trigger in gerrit. In theory it should post a lovely message to
any committer making a patchset for the first time.
However, it has not been tested, and review-dev is not available.
So, this patch uses the --dry-run option of welcome_message.py
so that it will hopefully post useful information to the log, but
won't cause catastrophic failures.
Change-Id: I4f04fcd2bd43f680f0d5032fc613194be8dd2586
* .../files/gerrit/change-merged: Call the docimpact script from
this hook.
* .../templates/gerrit_patchset-created.erb: Stop calling the
docimpact script from this hook.
Change-Id: I9a2d6e33ec35eb94ae14f7d2b17ead52bb9a2019
Change the destination address for SecurityImpact email notifications to
openstack-security@lists.openstack.org. This is being done at the
request of bdpayne.
Change-Id: If548c9ad74bb5e4f53f42ac737150a32ff54006e
Reviewed-on: https://review.openstack.org/27304
Reviewed-by: bdpayne <bdpayne@acm.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Spencer Krum <krum.spencer@gmail.com>
Reviewed-by: Elizabeth Krumbach <lyz@princessleia.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Instead of keeping many of these files directly in the tree, use them
from the out-of-tree jeepyb project, which makes them easier to consume
for other people who are not us.
Change-Id: Id704f2e17dd80709ef63cbbf2c5475a08a835f91
Reviewed-on: https://review.openstack.org/16777
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Fixes bug #1070577
Make the notify_impact script generic so that it can handle different
types of notifications. Then add a SecurityImpact notification.
Change-Id: Id4bbf7db29e36dde783328e31685079e79d0b1e9
Reviewed-on: https://review.openstack.org/14856
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Consider whitespace changes significant enough not to reapply code
reviews, but still comment if that's all which changed between
patchsets. This addresses bug 1057506.
* modules/openstack_project/files/gerrit/scripts/trivial_rebase.py
(GetPatchId): Add a flag called consider_whitespace, but defaulting to
False so as to preserve default behavior of the module. Add conditional
behavior to replace all spaces and tabs with percent signs before
calculating the patch-id hash.
(Main): Add a --whitespace command-line option to turn on whitespace
change checking. If enabled and if normal GetPatchId calls return a
match, re-run with consider_whitespace set to True and apply a comment
to the new patchset in Gerrit if the result is non-matching.
* modules/openstack_project/templates/gerrit_patchset-created.erb: Add
--whitespace to the trivial_rebase.py invocation, enabling whitespace
checking.
Change-Id: I89c479614a637717cf515a5d3f6d03b5f7830581
Reviewed-on: https://review.openstack.org/13775
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
Adds trivial_rebase.py for bug 881184.
* modules/openstack_project/files/gerrit/scripts/trivial_rebase.py: A
modified version of the contrib/trivial_rebase.py included in upstream
Gerrit's git tree (we'll try to get individual patches submitted
upstream soon):
git clone https://gerrit.googlesource.com/gerrit
* modules/openstack_project/files/gerrit/patchset-created: Moved to
modules/openstack_project/templates/gerrit_patchset-created.erb and
added an entry for the trivial_rebase.py script with variables for its
command-line options sourced from gerrit.pp and review{,_dev}.pp.
* modules/openstack_project/manifests/gerrit.pp: Changed the file
definition for /home/gerrit2/review_site/hooks/patchset-created to use a
template, adding the ssh_host_key and trivial_rebase_role_id variables
it requires. Added a file entry for trivial_rebase.py as well, since
we're putting it in modules/openstack_project instead of modules/gerrit
where the existing scripts reside (we'll eventually want to move all of
modules/gerrit/files/scripts out of there at some point, but not now).
* modules/openstack_project/manifests/review_dev.pp: Override the
trivial_rebase_role_id variable to trivial-rebase@review-dev.o.o on
review-dev.
* modules/openstack_project/manifests/review.pp: Override the
trivial_rebase_role_id variable to trivial-rebase@review.o.o on review.
Change-Id: I941f15525c72b84708ae1de6832834eb53ab6863
Reviewed-on: https://review.openstack.org/12373
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Monty Taylor