airship
/
pegleg
Code Issues Proposed changes

trivial: Drop unused lint code P002 

This patch set drops unused lint code P002 from Pegleg. The
variable for P002 is called:

  DECKHAND_RENDERING_INCOMPLETE_FLAG

It is not clear what this even means, so the assumption here is
that it is a mishap so there is nothing to implement behind the
scenes. The recourse is to remove it.

Change-Id: I3bc99e5f48aa1fa9ea652f073fd4e147b4283e10
This commit is contained in:
Felipe Monteiro 2018-10-29 19:40:30 -04:00
parent 0fc18c6f19
commit 89ec1e3e3a
2 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pegleg/engine/errorcodes.py
View File

@ -13,7 +13,6 @@
# limitations under the License.
SCHEMA_STORAGE_POLICY_MISMATCH_FLAG = 'P001'
DECKHAND_RENDERING_INCOMPLETE_FLAG = 'P002'
REPOS_MISSING_DIRECTORIES_FLAG = 'P003'
DECKHAND_DUPLICATE_SCHEMA = 'P004'
DECKHAND_RENDER_EXCEPTION = 'P005'

20
tests/unit/engine/test_selectable_linting.py
View File

@ -48,17 +48,6 @@ class TestSelectableLinting(object):
assert msg_1 in expected_exc
assert msg_2 in expected_exc
@mock.patch.object(lint, '_verify_no_unexpected_files', return_value=[])
def test_lint_excludes_P002(*args):
exclude_lint = ['P002']
config.set_site_repo('../pegleg/site_yamls/')
with mock.patch.object(
lint,
'_verify_deckhand_render',
return_value=[('P002', 'test message')]) as mock_method:
lint.full(False, exclude_lint, [])
mock_method.assert_called()
@pytest.mark.skip(reason=_SKIP_P003_REASON)
@mock.patch.object(lint, '_verify_deckhand_render', return_value=[])
def test_lint_excludes_P003(*args):
@ -90,15 +79,6 @@ class TestSelectableLinting(object):
assert msg_1 not in expected_exc
assert msg_2 in expected_exc
@mock.patch.object(lint, '_verify_no_unexpected_files', return_value=[])
def test_lint_warns_P002(*args):
warn_lint = ['P002']
config.set_site_repo('../pegleg/site_yamls/')
with mock.patch.object(lint, '_verify_deckhand_render') as mock_method:
lint.full(False, [], warn_lint)
mock_method.assert_called()
@pytest.mark.skip(reason=_SKIP_P003_REASON)
@mock.patch.object(lint, '_verify_deckhand_render', return_value=[])
def test_lint_warns_P003(*args):