This patch adds a missing config that let any playbook fail if no vars
are passed. Even though it's always good overriding variables, we should
provide defaults for config files like any other first citizen parameter.
Change-Id: I953296e22a6d8310aaf401fd9b13a71c35dbaf6a
- Moves some of the tasks from config.yml that are actually used to run
the chronyd into a new dedicated run.yml tasks file.
- Adds a sync.yml with tasks for actually syncing using chronyc.
- Adds some install tasks to install.yml to disable ntpd in case it is
running as it's not compatible when chronyd is also running.
- Refactors the distro variable loading into a common tasks vars.yml
that can be reused by the other tasks files
- Adds a symbolic link 'chrony' to the top level directory of the
project, since the role is named 'chrony', and ansible searches for a
directory with that name.
Signed-off-by: James Slagle <jslagle@redhat.com>
Change-Id: I673ce4fc17dd98aa251fdffce73bf9a096aad6fb
NetworkManager has a dispatcher which may cause the sources to be marked
as disabled. If you don't have any interfaces actually managed with
NetworkManager, we need to have a way to ensure that the sources get
marked enabled on boot. This change adds a chrony-online service that
waits for the network-online.target in order to be able to make chronyd
source online.
Change-Id: Ib1d91852d281c63b2458fc3c0199a5d5fed17056
The tox option to skip source distribution building is skipsdist,
but this seems to be often misspelled skipdist instead, which gets
silently ignored and so does not take effect. Correct it
everywhere, in hopes that new projects will finally stop copying
this mistake around.
See https://tox.readthedocs.io/en/latest/config.html#conf-skipsdist
and https://github.com/tox-dev/tox/issues/1388 for details.
Change-Id: I930b16a0834d893080386b40989fa517f1bc343b
Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:
UserWarning: Usage of dash-separated 'description-file' will not be
supported in future versions. Please use the underscore name
'description_file' instead
[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb
Change-Id: I7112c11085d646e17fa2beb792a0aeed0d56e66b
ansible_distribution and ansible_os_family rely on the facts being
injected as vars. This change switches our vars file lookup to use
ansible_facts instead.
Change-Id: Ia6636bf0223f7e51b6b50950a5c8c1413b4a54b0
The service will be enabled if and only if its state is set to "running"
or "started".
This change addresses comment in this change:
https://review.opendev.org/#/c/669365/1/tasks/config.yml@14
Change-Id: Ic25772c04047bcd3aaa3e8abc5b947feb66bcbbb
With older tripleo versions, we did disable the service since we were
using ntpd.
If we upgrade from a version using ntpd, the chronyd service won't be
active upon reboot.
Change-Id: Ic59374afdf5ace02ba8243f5163d0950e527ec52
Closes-Bug: #1835368
We've seen handlers being inconsitently being ignored for some
deployments when we force a handler flush mid-playbook. We'll need to
ensure the config is properly loaded if we want to follow up with
subsequent chronyc application so it's best to always invoke the restart
when the configuration actually changes.
Change-Id: I5292f1b1bd65cef340e1e9742463620effc30d26
The os specific variables are overriding the provided vars so we should
only define things that should not be overridable because they are OS
specific (service names, config file locations, etc)
Change-Id: I2af49137d91c34eeb68353d7438a5ee09c8166c9
Closes-Bug: #1802538
Using "python setup.py check -r -s" method of checking the package has
been deprecated with the new recommendation to build the sdist and
wheel, then running "twine check" against the output.
Luckily, there is already a job that covers this that only runs when the
README, setup.py, or setup.cfg files change, making running this in the
pep8 job redundant. This covered by the test-release-openstack-python3
that is defined in the publish-to-pypi-python3 template.
More details can be found in this mailing list post:
http://lists.openstack.org/pipermail/openstack-dev/2018-October/136136.html
Change-Id: If922868b53aaff788bc9439c0ce1b05340208704
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
The commands used by constraints need at least tox 2.0. Update to
reflect reality, which should help with local running of constraints
targets.
Change-Id: I868084c1ba43fdf6487275d453471b8f996f8668
The vars, tests and handlers folders are not properly packaged. This
change updates the setup.cfg to include these folders for distribution.
Change-Id: I0d5784c01a681341b50418ef79888ac6d94a5344