It is no longer supported by jammy and lead us to the following errors with the announce-release job.
```
No package matching 'python-dev' is available
```
Change-Id: I262efa933975966d6e078eff4e5778bc00331a92
The tox option to skip source distribution building is skipsdist,
but this seems to be often misspelled skipdist instead, which gets
silently ignored and so does not take effect. Correct it
everywhere, in hopes that new projects will finally stop copying
this mistake around.
See https://tox.readthedocs.io/en/latest/config.html#conf-skipsdist
and https://github.com/tox-dev/tox/issues/1388 for details.
Change-Id: Iac474f1d458c3b803eb28a33bd05002db31c4689
Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:
UserWarning: Usage of dash-separated 'description-file' will not be
supported in future versions. Please use the underscore name
'description_file' instead
[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb
Change-Id: I1f6e855b0c9cddaf714bf5750f3edd167ede1527
With the switch to tripleo_free in stable/train, we can no longer
reliably use handlers. That being said, handlers don't make sense when
you are forcing them to run with a flush handlers anyway. So this change
takes the code we used in the handler and makes them explicit tasks in
the required locations where we used to do a flush handlers. This
change should also improve the scope of some tasks to only occur when
necessary.
Change-Id: I1e31af24a4c1b9356a5971c6c1cb717d39d1e9b2
Closes-Bug: #1909750
1) Bump pyflakes
We need a python 3.9 compatible version.
Related PyCQA/pyflakes #367
2) Fix missing permissions on files
3) Ignore ansible-lint 106 for role name
4) Fix setup-tools install LP#1902986
5) ensure virtualenv is installed
6) fix missing htpasswd
Change-Id: I8302bc6c9250eba78437ccfec35e4de91348333e
Back in Openstack Pike release we hit issue with docker having
changes applied via puppet causing restart of docker service
without --live-restore option. This approach was buggous from the
begining and it's definetly obsolete here. We do only minor updates of
OS during release so we do only patch level updates of docker.
Change-Id: Iff4823d72c4d50838b6997398b23e76cec50ca56
RefBug: #1747851
Closes-Bug: #1851872
Ansible triggers notifies at the same time. It created a race as "wait
for registry" is dependant on "reload docker-distribution". This patch
moves notifies to dependant service to fix race condition.
Change-Id: I550d5538238ba6100714dd1ca8fcda25292a6773
With the upcoming activation of RHEL8 pipeline, we decided with infra it
was better to switch rdo registry to restricted access.
This means that all the job in rdo must login to registry to pull
containers.
All the Centos7 jobs must now call this role to login to the registry,
so we are expanding the login part to satisfy the workflow
RHEL8 job with podman will use a internal role instead.
Change-Id: I6e55bdcf493d04bfc88ae22154124a7888563147
When we run this, if we try to evaulate this without the variable being
set it errors. We assume empty if the variable is unset.
Change-Id: Ic6eea050cd627d9d09745bf194c2dd36b015e6ff
Closes-Bug: #1835657
This change adds molecule testing using a simple base job and pre|run playbooks.
The test will be executed via a native zuul job and will ensure we're exercising
all of the available code path's as provide by this role.
Two molecule scenarios will be executed whenever any change is made to this role
* default - runs through the typical main code path
* login - tests a secure docker registry ensuring our login capabilities are
never broken.
Documentation in the readme has been added to show how local testing can be run.
A bindep.txt file has been added to ensure zuul knows how to install our
required base packages.
Closes-Bug: #1835657
Related-Bug: #1833584
Change-Id: I48f74b69c5d29dce4a576fa96e79563a4b484469
Signed-off-by: Kevin Carter <kecarter@redhat.com>
We need to be able to perform a login prior to pulling containers from
registries that require authentication.
Change-Id: Ic3b720ba35db8e3f3f866cd31d9171e91b04a86c
Related-Bug: #1833584
Avoids use of ignore_errors on a task that is only reading the status.
We only use the result code (rc) of the check so the task iself
should not fail regardless if the registry was managed or not.
Improves output of ansible console and confusing false errors.
Change-Id: I0be5f333a7ac6705279820a1a34667b4ec32f760
reset ssh connection to pick up docker group after the task that add the
deployment user to docker group.
Change-Id: Ifb9a9ad6c467b8f244665696ed02cdbdc7f9a9de
Some of our tasks and handlers need to be run as root but were
previously missing the become: true option. This change addresses this
to ensure the appropriate tasks and handlers are run as an admin user.
Change-Id: I9cf00809e8725d9220bc993c8fd6602e19ed7aa3
The commands used by constraints need at least tox 2.0. Update to
reflect reality, which should help with local running of constraints
targets.
Change-Id: I98aa14c59474f019bbbbc45957617e7fc6f31ad1
Newer versions of ansible lint are stricter. This change fixes up the
issues and ignores rule 405 which requires retries on package items.
We're skipping the retries because yum does that natively.
Change-Id: I9280a736cb1bdeeb1bdcea11ec4ca8f5af9d1e44
When deploying with --stack-only, the playbooks aren't executed so if a
variable is processed lated, it needs to be checked if it's actually
defined or not otherwise Ansible will fail.
Change-Id: I16a2eed003b8f7fd4c775cdeead3f3b51f8aa467
We only really need an undercloud job for testing at the moment. The
undercloud is the primary consumer of this role anyway.
Change-Id: If2a4be04dd710ea8174bbd0b77bd57c7baf0a6b9
This commit adds an option `container_registry_skip_reconfiguration`,
that, when enabled, disables the reconfiguration if docker has already
been configured once.
Change-Id: I0bcaeea9cd24ab35a81d8c3d6fc3a384c1e4c3c2
Related-Bug: #1804790
Since we know xfs ftype=0 is incompatible with the container usage,
let's fail hard with a message if the system has an improperly
configured filesystem.
Change-Id: I06f80003d7f3f6443f75f39973d4e68ac24673be
Related-Bug: #1765121
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ia848da33224b359c3ac0ad5a57cebc1897369f3e
This template needs to stay in project-config to work properly.
also, it's obsolete. project-config is updated already.
Change-Id: I818b10cd6614870fc0673d96d20a9fe66b99ba94
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ib81683ef8d3677a567d1e62e1ec6adc9a1ed8ea4
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
With https://review.openstack.org/#/c/597153/
registry_pkg_manager was set to dnf for Centos7 as
well due to wrong string comparison, This patch convert
ansible_distribution_major_version to integer before
comparison and fixes the issue.
Change-Id: I603c1f932c63d07040e6aa24f1a75eab4e389738
Related-Blueprint: dnf-support