summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Belanger <pabelanger@redhat.com>2018-08-17 12:31:28 -0400
committerPaul Belanger <pabelanger@redhat.com>2018-08-17 12:31:28 -0400
commit48531f50f1d3c1ad83c13115ea19164ed1a7be63 (patch)
treeeb8e5515ce2e9ccf7ae0a52e02bf2258b5810f88
parentefc9d57e2c6369a242e264196fe0b43be90cbafc (diff)
Fix truthy value should be true or false
While testing out molecule, the following warnings were raised with its linter. Lets fix them to keep it happy. Change-Id: I698f65daa58822f7befc72b9dcbf1f2d668cab02 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Notes
Notes (review): Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 17 Aug 2018 17:40:39 +0000 Reviewed-on: https://review.openstack.org/593100 Project: openstack/ansible-role-nodepool Branch: refs/heads/master
-rw-r--r--defaults/main.yaml4
-rw-r--r--tasks/config.yaml10
-rw-r--r--tasks/install.yaml2
-rw-r--r--tasks/install/pip.yaml2
-rw-r--r--tasks/pre.yaml6
-rw-r--r--tasks/service.yaml16
6 files changed, 20 insertions, 20 deletions
diff --git a/defaults/main.yaml b/defaults/main.yaml
index b10e5a3..1bd7317 100644
--- a/defaults/main.yaml
+++ b/defaults/main.yaml
@@ -84,13 +84,13 @@ nodepool_file_nodepool_launcher_service_config_group: root
84nodepool_file_nodepool_launcher_service_config_owner: root 84nodepool_file_nodepool_launcher_service_config_owner: root
85 85
86nodepool_service_nodepool_builder_daemon_reload: true 86nodepool_service_nodepool_builder_daemon_reload: true
87nodepool_service_nodepool_builder_enabled: yes 87nodepool_service_nodepool_builder_enabled: true
88nodepool_service_nodepool_builder_manage: true 88nodepool_service_nodepool_builder_manage: true
89nodepool_service_nodepool_builder_name: nodepool-builder 89nodepool_service_nodepool_builder_name: nodepool-builder
90nodepool_service_nodepool_builder_state: started 90nodepool_service_nodepool_builder_state: started
91 91
92nodepool_service_nodepool_launcher_daemon_reload: true 92nodepool_service_nodepool_launcher_daemon_reload: true
93nodepool_service_nodepool_launcher_enabled: yes 93nodepool_service_nodepool_launcher_enabled: true
94nodepool_service_nodepool_launcher_manage: true 94nodepool_service_nodepool_launcher_manage: true
95nodepool_service_nodepool_launcher_name: nodepool-launcher 95nodepool_service_nodepool_launcher_name: nodepool-launcher
96nodepool_service_nodepool_launcher_state: started 96nodepool_service_nodepool_launcher_state: started
diff --git a/tasks/config.yaml b/tasks/config.yaml
index a87b6b2..22ea91f 100644
--- a/tasks/config.yaml
+++ b/tasks/config.yaml
@@ -13,7 +13,7 @@
13# under the License. 13# under the License.
14--- 14---
15- name: Create required directories. 15- name: Create required directories.
16 become: yes 16 become: true
17 file: 17 file:
18 group: "{{ nodepool_user_group }}" 18 group: "{{ nodepool_user_group }}"
19 owner: "{{ nodepool_user_name }}" 19 owner: "{{ nodepool_user_name }}"
@@ -26,7 +26,7 @@
26 - /var/log/nodepool 26 - /var/log/nodepool
27 27
28- name: Install nodepool configuration. 28- name: Install nodepool configuration.
29 become: yes 29 become: true
30 template: 30 template:
31 dest: "{{ nodepool_file_nodepool_yaml_dest }}" 31 dest: "{{ nodepool_file_nodepool_yaml_dest }}"
32 group: "{{ nodepool_file_nodepool_yaml_group }}" 32 group: "{{ nodepool_file_nodepool_yaml_group }}"
@@ -36,7 +36,7 @@
36 register: nodepool_file_nodepool_yaml 36 register: nodepool_file_nodepool_yaml
37 37
38- name: Install nodepool secure configuration. 38- name: Install nodepool secure configuration.
39 become: yes 39 become: true
40 template: 40 template:
41 dest: "{{ nodepool_file_secure_conf_dest }}" 41 dest: "{{ nodepool_file_secure_conf_dest }}"
42 group: "{{ nodepool_file_secure_conf_group }}" 42 group: "{{ nodepool_file_secure_conf_group }}"
@@ -46,7 +46,7 @@
46 register: nodepool_file_secure_conf 46 register: nodepool_file_secure_conf
47 47
48- name: Install builder logging configuration file. 48- name: Install builder logging configuration file.
49 become: yes 49 become: true
50 template: 50 template:
51 dest: "{{ nodepool_file_builder_logging_conf_dest }}" 51 dest: "{{ nodepool_file_builder_logging_conf_dest }}"
52 group: "{{ nodepool_file_builder_logging_conf_group }}" 52 group: "{{ nodepool_file_builder_logging_conf_group }}"
@@ -56,7 +56,7 @@
56 register: nodepool_file_builder_logging_conf 56 register: nodepool_file_builder_logging_conf
57 57
58- name: Install launcher logging configuration file. 58- name: Install launcher logging configuration file.
59 become: yes 59 become: true
60 template: 60 template:
61 dest: "{{ nodepool_file_launcher_logging_conf_dest }}" 61 dest: "{{ nodepool_file_launcher_logging_conf_dest }}"
62 group: "{{ nodepool_file_launcher_logging_conf_group }}" 62 group: "{{ nodepool_file_launcher_logging_conf_group }}"
diff --git a/tasks/install.yaml b/tasks/install.yaml
index de78f3b..1758e2d 100644
--- a/tasks/install.yaml
+++ b/tasks/install.yaml
@@ -18,7 +18,7 @@
18 when: nodepool_build_depends is not defined 18 when: nodepool_build_depends is not defined
19 19
20- name: Ensure build dependencies are installed 20- name: Ensure build dependencies are installed
21 become: yes 21 become: true
22 package: 22 package:
23 name: "{{ nodepool_build_depends }}" 23 name: "{{ nodepool_build_depends }}"
24 state: installed 24 state: installed
diff --git a/tasks/install/pip.yaml b/tasks/install/pip.yaml
index 401dd79..1e7e77f 100644
--- a/tasks/install/pip.yaml
+++ b/tasks/install/pip.yaml
@@ -13,7 +13,7 @@
13# under the License. 13# under the License.
14--- 14---
15- name: Install nodepool using pip. 15- name: Install nodepool using pip.
16 become: yes 16 become: true
17 pip: 17 pip:
18 executable: "{{ nodepool_pip_executable|default(omit) }}" 18 executable: "{{ nodepool_pip_executable|default(omit) }}"
19 editable : "{{ nodepool_pip_editable|default(omit) }}" 19 editable : "{{ nodepool_pip_editable|default(omit) }}"
diff --git a/tasks/pre.yaml b/tasks/pre.yaml
index 5adcad2..067f9de 100644
--- a/tasks/pre.yaml
+++ b/tasks/pre.yaml
@@ -13,14 +13,14 @@
13# under the License. 13# under the License.
14--- 14---
15- name: Create group account. 15- name: Create group account.
16 become: yes 16 become: true
17 group: 17 group:
18 name: "{{ nodepool_user_group }}" 18 name: "{{ nodepool_user_group }}"
19 19
20- name: Create user account. 20- name: Create user account.
21 become: yes 21 become: true
22 user: 22 user:
23 createhome: yes 23 createhome: true
24 group: "{{ nodepool_user_group }}" 24 group: "{{ nodepool_user_group }}"
25 home: "{{ nodepool_user_home }}" 25 home: "{{ nodepool_user_home }}"
26 name: "{{ nodepool_user_name }}" 26 name: "{{ nodepool_user_name }}"
diff --git a/tasks/service.yaml b/tasks/service.yaml
index 66b5a48..859536c 100644
--- a/tasks/service.yaml
+++ b/tasks/service.yaml
@@ -73,7 +73,7 @@
73 when: nodepool_file_nodepool_launcher_service_config_src is not defined 73 when: nodepool_file_nodepool_launcher_service_config_src is not defined
74 74
75- name: Install nodepool-builder service script into place. 75- name: Install nodepool-builder service script into place.
76 become: yes 76 become: true
77 template: 77 template:
78 dest: "{{ nodepool_file_nodepool_builder_service_dest }}" 78 dest: "{{ nodepool_file_nodepool_builder_service_dest }}"
79 group: "{{ nodepool_file_nodepool_builder_service_group }}" 79 group: "{{ nodepool_file_nodepool_builder_service_group }}"
@@ -84,7 +84,7 @@
84 when: nodepool_file_nodepool_builder_service_manage 84 when: nodepool_file_nodepool_builder_service_manage
85 85
86- name: Create nodepool-builder service config directory. 86- name: Create nodepool-builder service config directory.
87 become: yes 87 become: true
88 file: 88 file:
89 group: "{{ nodepool_file_nodepool_builder_service_config_group }}" 89 group: "{{ nodepool_file_nodepool_builder_service_config_group }}"
90 owner: "{{ nodepool_file_nodepool_builder_service_config_owner }}" 90 owner: "{{ nodepool_file_nodepool_builder_service_config_owner }}"
@@ -93,7 +93,7 @@
93 when: nodepool_file_nodepool_builder_service_config_manage 93 when: nodepool_file_nodepool_builder_service_config_manage
94 94
95- name: Install nodepool-builder service config into place. 95- name: Install nodepool-builder service config into place.
96 become: yes 96 become: true
97 template: 97 template:
98 dest: "{{ nodepool_file_nodepool_builder_service_config_dest }}" 98 dest: "{{ nodepool_file_nodepool_builder_service_config_dest }}"
99 group: "{{ nodepool_file_nodepool_builder_service_config_group }}" 99 group: "{{ nodepool_file_nodepool_builder_service_config_group }}"
@@ -104,7 +104,7 @@
104 when: nodepool_file_nodepool_builder_service_config_manage 104 when: nodepool_file_nodepool_builder_service_config_manage
105 105
106- name: Install nodepool-launcher service script into place. 106- name: Install nodepool-launcher service script into place.
107 become: yes 107 become: true
108 template: 108 template:
109 dest: "{{ nodepool_file_nodepool_launcher_service_dest }}" 109 dest: "{{ nodepool_file_nodepool_launcher_service_dest }}"
110 group: "{{ nodepool_file_nodepool_launcher_service_group }}" 110 group: "{{ nodepool_file_nodepool_launcher_service_group }}"
@@ -115,7 +115,7 @@
115 when: nodepool_file_nodepool_launcher_service_manage 115 when: nodepool_file_nodepool_launcher_service_manage
116 116
117- name: Create nodepool-launcher service config directory. 117- name: Create nodepool-launcher service config directory.
118 become: yes 118 become: true
119 file: 119 file:
120 group: "{{ nodepool_file_nodepool_launcher_service_config_group }}" 120 group: "{{ nodepool_file_nodepool_launcher_service_config_group }}"
121 owner: "{{ nodepool_file_nodepool_launcher_service_config_owner }}" 121 owner: "{{ nodepool_file_nodepool_launcher_service_config_owner }}"
@@ -124,7 +124,7 @@
124 when: nodepool_file_nodepool_launcher_service_config_manage 124 when: nodepool_file_nodepool_launcher_service_config_manage
125 125
126- name: Install nodepool-launcher service config into place. 126- name: Install nodepool-launcher service config into place.
127 become: yes 127 become: true
128 template: 128 template:
129 dest: "{{ nodepool_file_nodepool_launcher_service_config_dest }}" 129 dest: "{{ nodepool_file_nodepool_launcher_service_config_dest }}"
130 group: "{{ nodepool_file_nodepool_launcher_service_config_group }}" 130 group: "{{ nodepool_file_nodepool_launcher_service_config_group }}"
@@ -135,7 +135,7 @@
135 when: nodepool_file_nodepool_launcher_service_config_manage 135 when: nodepool_file_nodepool_launcher_service_config_manage
136 136
137- name: Enable nodepool-builder service. 137- name: Enable nodepool-builder service.
138 become: yes 138 become: true
139 systemd: 139 systemd:
140 daemon_reload: "{{ nodepool_service_nodepool_builder_daemon_reload }}" 140 daemon_reload: "{{ nodepool_service_nodepool_builder_daemon_reload }}"
141 enabled: "{{ nodepool_service_nodepool_builder_enabled }}" 141 enabled: "{{ nodepool_service_nodepool_builder_enabled }}"
@@ -145,7 +145,7 @@
145 when: nodepool_service_nodepool_builder_manage 145 when: nodepool_service_nodepool_builder_manage
146 146
147- name: Enable nodepool-launcher service. 147- name: Enable nodepool-launcher service.
148 become: yes 148 become: true
149 systemd: 149 systemd:
150 daemon_reload: "{{ nodepool_service_nodepool_launcher_daemon_reload }}" 150 daemon_reload: "{{ nodepool_service_nodepool_launcher_daemon_reload }}"
151 enabled: "{{ nodepool_service_nodepool_launcher_enabled }}" 151 enabled: "{{ nodepool_service_nodepool_launcher_enabled }}"