recordsansible
/
ara-server
Code Issues Proposed changes

Add comments to describe bytestrings 

Change-Id: I6be0ff90d7f24de545e9e3d139d2233439b6fe64
This commit is contained in:
David Moreau Simard 2018-06-20 19:05:15 -04:00
parent f34c6ccb85
commit dd4da299f8
No known key found for this signature in database
GPG Key ID: 33A07694CBB71ECC
5 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ara/api/tests/factories.py
View File

@ -9,7 +9,7 @@ class FileContentFactory(factory.DjangoModelFactory):
django_get_or_create = ('sha1',)
sha1 = '1e58ead094c920fad631d2c22df34dc0314dab0c'
contents = b'x\x9cSV(\xc8I\xacL\xca\xcf\xcf\x06\x00\x11\xbd\x03\xa5'
contents = b'x\x9cSV(\xc8I\xacL\xca\xcf\xcf\x06\x00\x11\xbd\x03\xa5' # '# playbook'
class FileFactory(factory.DjangoModelFactory):
@ -26,7 +26,7 @@ class PlaybookFactory(factory.DjangoModelFactory):
ansible_version = '2.4.0'
completed = True
parameters = b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T'
parameters = b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T' # {'foo': 'bar'}
file = factory.SubFactory(FileFactory)
@ -48,7 +48,7 @@ class TaskFactory(factory.DjangoModelFactory):
action = 'setup'
lineno = 2
handler = False
tags = b'x\x9c\x8bVJ\xcb\xcfW\xd2QPJJ,R\x8a\x05\x00\x1eH\x04\x06'
tags = b'x\x9c\x8bVJ\xcb\xcfW\xd2QPJJ,R\x8a\x05\x00\x1eH\x04\x06' # ['foo', 'bar']
play = factory.SubFactory(PlayFactory)
file = factory.SubFactory(FileFactory)
@ -57,7 +57,7 @@ class HostFactory(factory.DjangoModelFactory):
class Meta:
model = models.Host
facts = b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T'
facts = b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T' # {'foo', 'bar'}
name = 'hostname'
changed = 1
failed = 0
@ -71,7 +71,7 @@ class ResultFactory(factory.DjangoModelFactory):
class Meta:
model = models.Result
content = b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T'
content = b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T' # {'foo', 'bar'}
status = 'ok'
host = factory.SubFactory(HostFactory)
task = factory.SubFactory(TaskFactory)

4
ara/api/tests/test_host.py
View File

@ -31,10 +31,10 @@ class HostTestCase(APITestCase):
serializer.is_valid()
host = serializer.save()
host.refresh_from_db()
self.assertEqual(host.facts, b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T')
self.assertEqual(host.facts, b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T') # {'foo': 'bar'}
def test_host_serializer_decompress_facts(self):
host = factories.HostFactory(facts=b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T')
host = factories.HostFactory(facts=b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T') # {'foo': 'bar'}
serializer = serializers.HostSerializer(instance=host)
self.assertEqual(serializer.data['facts'], {'foo': 'bar'})

9
ara/api/tests/tests_playbook.py
View File

@ -36,10 +36,15 @@ class PlaybookTestCase(APITestCase):
serializer.is_valid()
playbook = serializer.save()
playbook.refresh_from_db()
self.assertEqual(playbook.parameters, b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T')
self.assertEqual(
playbook.parameters,
b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T' # {'foo': 'bar'}
)
def test_playbook_serializer_decompress_parameters(self):
playbook = factories.PlaybookFactory(parameters=b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T')
playbook = factories.PlaybookFactory(
parameters=b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T' # {'foo': 'bar'}
)
serializer = serializers.PlaybookSerializer(instance=playbook)
self.assertEqual(serializer.data['parameters'], {'foo': 'bar'})

4
ara/api/tests/tests_result.py
View File

@ -36,12 +36,12 @@ class ResultTestCase(APITestCase):
result = serializer.save()
result.refresh_from_db()
self.assertEqual(
result.content, b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T'
result.content, b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T' # {'foo': 'bar'}
)
def test_result_serializer_decompress_content(self):
result = factories.ResultFactory(
content=b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T'
content=b'x\x9c\xabVJ\xcb\xcfW\xb2RPJJ,R\xaa\x05\x00 \x98\x04T' # {'foo': 'bar'}
)
serializer = serializers.ResultSerializer(instance=result)
self.assertEqual(serializer.data['content'], {'foo': 'bar'})

4
ara/api/tests/tests_task.py
View File

@ -44,10 +44,10 @@ class TaskTestCase(APITestCase):
serializer.is_valid()
task = serializer.save()
task.refresh_from_db()
self.assertEqual(task.tags, b'x\x9c\x8bVJ\xcb\xcfW\xd2QPJJ,R\x8a\x05\x00\x1eH\x04\x06')
self.assertEqual(task.tags, b'x\x9c\x8bVJ\xcb\xcfW\xd2QPJJ,R\x8a\x05\x00\x1eH\x04\x06') # ['foo', 'bar']
def test_task_serializer_decompress_tags(self):
task = factories.TaskFactory(tags=b'x\x9c\x8bVJ\xcb\xcfW\xd2QPJJ,R\x8a\x05\x00\x1eH\x04\x06')
task = factories.TaskFactory(tags=b'x\x9c\x8bVJ\xcb\xcfW\xd2QPJJ,R\x8a\x05\x00\x1eH\x04\x06') # ['foo', 'bar']
serializer = serializers.TaskSerializer(instance=task)
self.assertEqual(serializer.data['tags'], ['foo', 'bar'])