These were missed in change I2706e8af350d07e51169f8bc13c7404d4696b2a2
Change-Id: Ie6e15bdc948dcc918fd2eff344f804ac93434f1b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We run on Python 3 only, time to remove six dependency
Also fix l-c for new pip-resolver and move pep8 deps
in tox.ini to avoid conflicts.
And since we're here, update pre-commit config to support correct
hacking version.
Change-Id: Ibbe733c4be37d1a9dd9149d491591ef2e50dad6a
Introduced changes:
- pre-commit config and rules
- Add pre-commit to pep8 gate, Flake8 is covered in the pre-commit hooks.
- Applying fixes for pre-commit compliance in all code.
Also commit hash will be used instead of version tags in pre-commit to
prevend arbitrary code from running in developer's machines.
pre-commit will be used to:
- trailing whitespace;
- Replaces or checks mixed line ending (mixed-line-ending);
- Forbid files which have a UTF-8 byte-order marker (check-byte-order-marker);
- Checks that non-binary executables have a proper
shebang (check-executables-have-shebangs);
- Check for files that contain merge conflict strings (check-merge-conflict);
- Check for debugger imports and py37+ breakpoint()
calls in python source (debug-statements);
- Attempts to load all yaml files to verify syntax (check-yaml);
- Run flake8 checks (flake8) (local)
For further details about tests please refer to:
https://github.com/pre-commit/pre-commit-hooks
Change-Id: I1e4625d34ed08218dd7069402a1eff1418f4ec35
Signed-off-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>
Python 3.8 is now our highest level supported python runtime.
This updates the default tox target environments to swap out
py37 for py38 to make sure local development testing is
covering this version.
This does not impact zuul jobs in any way, nor prevent local
tests against py37. It just changes the default if none is
explicitly provided.
Change-Id: I803395e1448dae744707853387af5b01ec037b62
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Also prefer to lowercase `ignore_basepython_conflict` value to
uniformize with other oslo projects.
Change-Id: Ia5b47f1dd3b4aee25b1182620f61f05b0f1fb56f
As it was announced [1] global bindep-fallback.txt was removed and now
projects need to have a local bindep.txt to be able to install binary
dependencies for testing.
In documentation zuul job graphviz package ('dot' command) is needed.
Without that the job fails with:
dot command 'dot' cannot be run (needed for graphviz output),
check the graphviz_dot setting
[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007272.html
Change-Id: Ib9a720379ca997f848212eeca68ed9f32e4ed349
According to Openstack summit session [1],
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: Ic388868baaf9a1204d4ad35f3467de564c1a56fa
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I9a8f7b1734b23751e47297a15676219627969d7c
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Update the list of default virtualenvs that are run when a developer
just runs "tox" without specifying an environment.
Change-Id: I49c9203bb76f9cc075d7d7673d32daaf070bbfb7
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Set the default python to python3 except for the py27 environment. We
have to set that explicitly to override the new default.
Change-Id: I5ae4018191b6b78aa8abc22fd12e4c5ec1c02374
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I0fb35cb5102c1a9a45671bcb7631fe005925543c
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.
This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.
Change-Id: I9f2ad4af40ae0ce46a2e01d25e335820079ec66c
The gating on python 3.4 is restricted to <= Mitaka. This is due to
the change from Ubuntu Trusty to Xenial, where only python3.5 is
available. There is no need to continue to keep these settings.
Change-Id: I3463384984800d8bb53b030ea269c71449f9d06c
The directory openstack/common was used to keep codes from oslo-incubator,
we have retired oslo-incubator,so don't use this directory any more
Change-Id: Iddfa88749f87e65454bfe0c10c7cf5c6301c4f27
Adding constraints support to libraries is slightly more complex than
services as the libraries themselves are listed in upper-constraints.txt
which leads to errors that you can't install a specific version and a
constrained version.
This change adds constraints support by also adding a helper script to
edit the constraints to remove automaton.
Change-Id: Ibdd4d0a213bf1190e33c28c5c62561b083ae282d
The release management team have indicated this is their preferred way
to collect release notes in future.
Change-Id: Ia0580eb513dd78779b9b2adb849627cf5e19f89b
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Now that there is a passing gate job, we can claim support for
Python 3.5 in the classifier. This patch also adds the convenience
py35 venv.
Change-Id: Idb34ad4169d21af23ae02f9487ebfcebdb97f90b
To solve the problem of "db type could
not be determined" on py34 we have to run first the py34 env to, then, run
py27. This patch puts py34 first on the tox.ini list of envs to avoid this
problem to happen.
Change-Id: I7a1fefad4931574f37290085a7c2f8aa80add095
Closes-bug: #1489059
* Remove support for python 2.6
* Remove skipsdist : Needs to be set only if
sdist is expensive
* Remove usedevelop : only needed when skipsdist
is set to True
* Remove install_command : We can just use the
default, we don't need to override
* Remove setenv : We can just use the default as
we don't need any extra environment variables
* Remove requirements.txt from deps, as this is
already added automatically
Change-Id: I87c1fc87fb2a595b4453be6b33d679f0523cdea8
Just enforce that `python setup.py build_sphinx` will be the
way to build docs (which also builds a 'ChangeLog') so we don't
need to maintain a dummy file here anymore.
Change-Id: Icc34899fc1b29b1d81cada1f97d61e47eb086abd
Remove the specification in tox.ini that _ is a builtin so that
it will no longer assume that _ does not need to be imported.
This helps ensure that the _ from i18n is used.
Activating this check did not flag any violations.
Change-Id: I8849dc5fb187c2278e99fe8c41322b5f2c139879
This ensures that sphinx doc tests are ran and validated
and also runs doc8 to ensure style checks are done and adjusts
some of the current examples and code to fix found issues.
Also fixes the `get_callback_name` method which needs to check
if the __module__ is non-none (since it appears sphinx somehow
triggers it being none).
Change-Id: I54daecff219a9e9be71ff382d36fc2d5e67360cf
Zuul