stop assuming ceph/swift share same endpoint

showing backtrace on a handled and warning logged exception seems
aggressive, just return as error.

also, stop setting ceph/swift to same endpoint

Change-Id: I33be2d433c86cd67add5fac92fed1b66219d48b6
Closes-Bug: #1573241
This commit is contained in:
gord chung 2016-11-02 16:39:40 +00:00
parent be1015079a
commit 03298e645d
3 changed files with 5 additions and 4 deletions

View File

@ -32,7 +32,7 @@ from stevedore import extension
from ceilometer.agent import plugin_base
from ceilometer import coordination
from ceilometer.i18n import _, _LE, _LI, _LW
from ceilometer.i18n import _LE, _LI, _LW
from ceilometer import keystone_client
from ceilometer import messaging
from ceilometer import pipeline
@ -207,7 +207,7 @@ class PollingTask(object):
'res_list': err.fail_res_list}))
self.resources[key].blacklist.extend(err.fail_res_list)
except Exception as err:
LOG.warning(_(
LOG.error(_LE(
'Continue after error from %(name)s: %(error)s')
% ({'name': pollster.name, 'error': err}),
exc_info=True)

View File

@ -28,7 +28,6 @@ LOG = log.getLogger(__name__)
SERVICE_OPTS = [
cfg.StrOpt('radosgw',
default='object-store',
help='Radosgw service type.'),
]
@ -64,7 +63,7 @@ class _Base(plugin_base.PollsterBase):
# we store the endpoint as a base class attribute, so keystone is
# only ever called once, also we assume that in a single deployment
# we may be only deploying `radosgw` or `swift` as the object-store
if _Base._ENDPOINT is None:
if _Base._ENDPOINT is None and conf.service_types.radosgw:
try:
creds = conf.service_credentials
rgw_url = keystone_client.get_service_catalog(

View File

@ -89,6 +89,8 @@ class TestRgwPollster(testscenarios.testcase.WithScenarios,
def setUp(self):
super(TestRgwPollster, self).setUp()
self.CONF = self.useFixture(fixture_config.Config()).conf
self.CONF.set_override('radosgw', 'object-store',
group='service_types')
self.pollster = self.factory(self.CONF)
self.manager = TestManager(0, self.CONF)