Update pre-install hooks to fail on error

The pre-install operations may fail, yet that failure is not
elevated to the user. This masks the failure and makes early
package install issues difficult to troubleshoot.

If the basic pre-install script fails, the charm should not
proceed to later hooks as the requirements may not be met.

Hashbangs for bash should specify -e (errexit) on all of the
pre-install bash scripts.

Change-Id: I6e015c2e0a28f9b990bfd7b84a2317d339abbb4e
Closes-bug: #1815243
Partial-bug: #1815231
This commit is contained in:
Ryan Beisner 2019-02-08 15:28:41 -06:00
parent 5ed4956f2b
commit be74c0fd1c
No known key found for this signature in database
GPG Key ID: 952BACDC1C1A05FB
3 changed files with 3 additions and 3 deletions

View File

@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/bash -e
# ensure that the python3 bits are installed, whichever version of ubunut
# is being installed.

View File

@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/bash -e
# Wrapper to ensure that python dependencies are installed before we get into
# the python part of the hook execution

View File

@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/bash -e
# Wrapper to ensure that old python bytecode isn't hanging around
# after we upgrade the charm with newer libraries
rm -rf **/*.pyc