summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Beisner <ryan.beisner@canonical.com>2019-02-08 15:37:15 -0600
committerRyan Beisner <ryan.beisner@canonical.com>2019-02-08 15:37:32 -0600
commita90b30a8f2018933da52195934a4c4c4e5eef0e9 (patch)
tree0520ec310bcf8ebe9186f3eaa12fcb94c9d1b4cd
parent73d7745e1050b496a0d2f391d19931540856c496 (diff)
Update pre-install hooks to fail on error
The pre-install operations may fail, yet that failure is not elevated to the user. This masks the failure and makes early package install issues difficult to troubleshoot. If the basic pre-install script fails, the charm should not proceed to later hooks as the requirements may not be met. Hashbangs for bash should specify -e (errexit) on all of the pre-install bash scripts. Change-Id: I97e2d9fa092fd6af5f426977cf99ab735e520496 Closes-bug: #1815243 Partial-bug: #1815231
Notes
Notes (review): Verified+1: Canonical CI <uosci-testing-bot@ubuntu.com> Code-Review+2: David Ames <david.ames@canonical.com> Workflow+1: David Ames <david.ames@canonical.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sun, 10 Feb 2019 19:51:27 +0000 Reviewed-on: https://review.openstack.org/635943 Project: openstack/charm-ceph-proxy Branch: refs/heads/master
-rwxr-xr-xhooks/install2
1 files changed, 1 insertions, 1 deletions
diff --git a/hooks/install b/hooks/install
index 29ff689..86d4885 100755
--- a/hooks/install
+++ b/hooks/install
@@ -1,4 +1,4 @@
1#!/bin/bash 1#!/bin/bash -e
2# Wrapper to deal with newer Ubuntu versions that don't have py2 installed 2# Wrapper to deal with newer Ubuntu versions that don't have py2 installed
3# by default. 3# by default.
4 4