openstack
/
charm-layer-openstack
Code Issues Proposed changes

Move application version set to charms.openstack 

The version of the application deployed should be set on all
assess_status calls, not just during the 'update-status' hook
execution.

Remove call from update-status default handler (it will be
added to _assess_status in the core charm class).

Change-Id: Iac95a0b988ae6563039aae599985de5713432c00
Closes-Bug: 1715429
This commit is contained in:
James Page 2017-09-06 17:43:05 +01:00
parent d010603e67
commit e1168b8f3a
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
reactive/layer_openstack.py
View File

@ -1,4 +1,3 @@
import charmhelpers.core.hookenv as hookenv
import charmhelpers.core.unitdata as unitdata
import charms_openstack.charm as charm
@ -63,6 +62,5 @@ def default_update_status():
'run-default-update-status')
def run_default_update_status():
with charm.provide_charm_instance() as instance:
hookenv.application_version_set(instance.application_version)
instance.assess_status()
reactive.remove_state('run-default-update-status')