openstack
/
charm-nova-compute
Code Issues Proposed changes

drop driver and topic settings in designate ctx 

A similar change will land in designate to drop this extra topic as
well.

Also, driver and topic overrides in a service-specific context are not a
good idea.

Change-Id: I804a34fb044090010ecfd2560594cc1f55e9bd21
Closes-Bug: #1710831
Closes-Bug: #1738100
This commit is contained in:
Dmitrii Shcherbakov 2017-11-17 15:13:22 +03:00
parent 5d92bc9f7e
commit b89de21d47
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hooks/nova_compute_context.py
View File

@ -598,8 +598,6 @@ class DesignateContext(context.OSContextGenerator):
if related_units(rid):
ctxt['enable_designate'] = True
if ctxt['enable_designate']:
ctxt['notification_driver'] = 'messaging'
ctxt['notification_topics'] = 'notifications_designate'
ctxt['notify_on_state_change'] = 'vm_and_task_state'
return ctxt

2
unit_tests/test_nova_compute_contexts.py
View File

@ -517,8 +517,6 @@ class DesignateContextTests(CharmTestCase):
self.related_units.return_value = 'designate/0'
self.assertEqual(designatectxt(), {
'enable_designate': True,
'notification_driver': 'messaging',
'notification_topics': 'notifications_designate',
'notify_on_state_change': 'vm_and_task_state',
})