Update pre-install hooks to fail on error

The pre-install operations may fail, yet that failure is not
elevated to the user. This masks the failure and makes early
package install issues difficult to troubleshoot.

If the basic pre-install script fails, the charm should not
proceed to later hooks as the requirements may not be met.

Hashbangs for bash should specify -e (errexit) on all of the
pre-install bash scripts.

Change-Id: If36f0df0a8be40c82cf2244584e9531ada005c92
Closes-bug: #1815243
Partial-bug: #1815231
This commit is contained in:
Ryan Beisner 2019-02-08 15:58:48 -06:00
parent ac7793ffee
commit 56358d1d33
No known key found for this signature in database
GPG Key ID: 952BACDC1C1A05FB
1 changed files with 1 additions and 3 deletions

View File

@ -1,9 +1,7 @@
#!/bin/bash
#!/bin/bash -e
# Wrapper to deal with newer Ubuntu versions that don't have py2 installed
# by default.
set -e
declare -a DEPS=('apt' 'netaddr' 'netifaces' 'pip' 'yaml' 'dnspython')
check_and_install() {