openstack
/
charm-swift-storage
Code Issues Proposed changes

Using assertIsNone() instead of assertEqual(None) 

Following OpenStack Style Guidelines:
[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more specific
assertions. As a result, assertIsNone(...) is preferred over
assertEqual(None, ...) and assertIs(..., None)

Change-Id: Ib5dcf2f389dd76f99d87ad22268695f2a702e6b3
This commit is contained in:
wangqi 2018-04-20 07:33:26 +00:00
parent 6346a7458b
commit f9a6b36c93
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unit_tests/test_swift_storage_utils.py
View File

@ -146,7 +146,7 @@ class SwiftStorageUtilsTests(CharmTestCase):
def test_determine_block_device_no_config(self):
self.test_config.set('block-device', None)
self.assertEqual(swift_utils.determine_block_devices(), None)
self.assertIsNone(swift_utils.determine_block_devices())
def _fake_ensure(self, bdev):
# /dev/vdz is a missing dev