openstack
/
cinder
Code Issues Proposed changes

Fixes cinder failed to create/restore a backup with NFS driver 

The action cinder backup-create fails when trying to backup a newly
created volume when using cinder.volume.drivers.nfs.NfsDriver. This
patch removes not implemented stubs for backup_volume and
restore_volume. The inherited methods in cinder/volume/driver.py
succeed in creating a backup and in restoring it. After manual
testing of this change backups/restores succeed without the not
implemented stubs. This change also adds the not implemented
stubs to the glusterfs driver until a fix is submitted.

Closes-Bug: #1247743

Change-Id: I5478d00442ce855c91a7f04c5ba2b40733d44902
This commit is contained in:
Jeff Applewhite 2014-01-30 14:11:08 -05:00 committed by Eric Harney
parent 468bb2f40e
commit 10108f4d2e
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cinder/volume/drivers/glusterfs.py
View File

@ -1145,3 +1145,11 @@ class GlusterfsDriver(nfs.RemoteFsDriver):
def _get_mount_point_base(self):
return self.base
def backup_volume(self, context, backup, backup_service):
"""Create a new backup from an existing volume."""
raise NotImplementedError()
def restore_backup(self, context, backup, volume, backup_service):
"""Restore an existing backup to a new or existing volume."""
raise NotImplementedError()

8
cinder/volume/drivers/nfs.py
View File

@ -371,14 +371,6 @@ class RemoteFsDriver(driver.VolumeDriver):
def _ensure_share_mounted(self, nfs_share):
raise NotImplementedError()
def backup_volume(self, context, backup, backup_service):
"""Create a new backup from an existing volume."""
raise NotImplementedError()
def restore_backup(self, context, backup, volume, backup_service):
"""Restore an existing backup to a new or existing volume."""
raise NotImplementedError()
class NfsDriver(RemoteFsDriver):
"""NFS based cinder driver. Creates file on NFS share for using it