openstack
/
cinder
Code Issues Proposed changes

gpfs volume driver backup file access fixes 

Changes to volume file permission settings require a temporary
chown to the file being backed up.

Also, use gpfs file clone copy mechanism to create a consistent
file copy so that the TSM backup service can create a hard link
to the clone file.

Closes-bug: 1286924

Change-Id: I951ab16788277d0052d1845fad963e9e4cdbc53e
This commit is contained in:
Bill Owen 2014-03-01 14:36:38 -07:00
parent 22e60454f7
commit 4ffe195c4a
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
cinder/volume/drivers/ibm/gpfs.py
View File

@ -29,6 +29,7 @@ from cinder.openstack.common import fileutils
from cinder.openstack.common import log as logging
from cinder.openstack.common import processutils
from cinder import units
from cinder import utils
from cinder.volume import driver
GPFS_CLONE_MIN_RELEASE = 1200
@ -817,12 +818,14 @@ class GPFSDriver(driver.VolumeDriver):
LOG.debug(_('Begin backup of volume %s.') % volume['name'])
# create a snapshot that will be used as the backup source
backup_path = '%s_%s.snap' % (volume_path, backup['id'])
self._create_gpfs_snap(volume_path, backup_path)
backup_path = '%s_%s' % (volume_path, backup['id'])
self._create_gpfs_clone(volume_path, backup_path)
self._gpfs_redirect(volume_path)
try:
with fileutils.file_open(backup_path) as backup_file:
backup_service.backup(backup, backup_file)
with utils.temporary_chown(backup_path):
with fileutils.file_open(backup_path) as backup_file:
backup_service.backup(backup, backup_file)
finally:
# clean up snapshot file. If it is a clone parent, delete
# will fail silently, but be cleaned up when volume is
@ -835,8 +838,9 @@ class GPFSDriver(driver.VolumeDriver):
LOG.debug(_('Begin restore of backup %s.') % backup['id'])
volume_path = self.local_path(volume)
with fileutils.file_open(volume_path, 'wb') as volume_file:
backup_service.restore(backup, volume['id'], volume_file)
with utils.temporary_chown(volume_path):
with fileutils.file_open(volume_path, 'wb') as volume_file:
backup_service.restore(backup, volume['id'], volume_file)
def _migrate_volume(self, volume, host):
"""Migrate vol if source and dest are managed by same GPFS cluster."""