openstack
/
cinder
Code Issues Proposed changes

Fix policy documentation for os-show_image_metadata endpoint 

The policy documentation for os-show_image_metadata endpoint
is inconsistent with the implementation.

In policy documentation, the endpoint is listed as enforcing
"volume_extension:volume_image_metadata": [0]

But in the code it is clear that no policy enforcement is performed: [1]

This PS removes the os-show_image_metadata entry from the policy
documentation for consistency.

[0] 9fbf236dc1/cinder/policies/volume_metadata.py (L102)
[1] 0cf910d434/cinder/api/contrib/volume_image_metadata.py (L123)

Change-Id: Icfde885384d174dbf9b211faca3f31be0b41f232
Closes-Bug: #1733632
This commit is contained in:
Felipe Monteiro 2017-11-21 16:02:54 +00:00
parent 9fbf236dc1
commit 52576bbbc8
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/policies/volume_metadata.py
View File

@ -97,10 +97,6 @@ volume_metadata_policies = [
'method': 'POST',
'path': '/volumes/{volume_id}/action (os-set_image_metadata)'
},
{
'method': 'POST',
'path': '/volumes/{volume_id}/action (os-show_image_metadata)'
},
{
'method': 'POST',
'path': '/volumes/{volume_id}/action (os-unset_image_metadata)'