openstack
/
cinder
Code Issues Proposed changes

Change CHAP secret default length 

Some of the iSCSI initiators have a limit regarding the maximum
CHAP secret length. For example, the MS iSCSI Initiator
does not allow CHAP secrets longer than 16 characters, smaller
than the actual default 20 characters length.

This patch simply changes the default length to 16 characters,
value which is already used by default by some of the volume
drivers. In fact, the iSCSI specs state that: "Implementations
MUST support use of up to 128 bit random CHAP secrets".

Change-Id: I0295fabd0c0048c93e1f452077d0f5d19af9784d
Closes-Bug: #1392792
(cherry picked from commit 3e124edb5d)
This commit is contained in:
Lucian Petrut 2014-11-14 18:22:04 +02:00 committed by Alessandro Pilotti
parent e29c4987c2
commit 7b1d7a3133
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/volume/utils.py
View File

@ -417,7 +417,7 @@ DEFAULT_PASSWORD_SYMBOLS = ('23456789', # Removed: 0,1
'abcdefghijkmnopqrstuvwxyz') # Removed: l
def generate_password(length=20, symbolgroups=DEFAULT_PASSWORD_SYMBOLS):
def generate_password(length=16, symbolgroups=DEFAULT_PASSWORD_SYMBOLS):
"""Generate a random password from the supplied symbol groups.
At least one symbol from each group will be included. Unpredictable