Allocations committed against the destination host are not reverted
during live migration rollbacks. The reason is that we're not passing
the migrate data object properly.
At some point, the rollback callback signature has changed. We picked
it up but only for the main (non-cluster) driver:
I5f247d733642464f4ede0430d4dfc8a27a02e7fd
This change addresses the cluster driver as well.
Change-Id: I8c509d411b8fdf7e65622f1fbb2095fe9c3b98b5
Closes-Bug: #1841068
(cherry picked from commit d9c1cb6aa1)
The "get_info" now accepts a "use_cache" flag. This was backported
to Rocky as part of a bugfix:
I907b69eb689cf6c169a4869cfc7889308ca419d5
Change-Id: I54ae1111d008ff85b1e4bbb0a4943c06ca147c7f
This reverts commit 87fdd92f3d. The
changes were not made in Rocky.
Updates UPPER_CONSTRAINTS_FILE for stable/rocky
Additionally, sets the nova dependency branch to stable/rocky.
Change-Id: I0fa03ffa83978787726c983f69560bba79ece7ba
As of oslotest 2.5.0 moxstubout is deprecated so
remove it.
Change-Id: Ife7054711838df5f60acefdb02c4e31298a69c1f
Signed-off-by: Chuck Short <chucks@redhat.com>
A recent feature has been added, allowing users to specify
trusted certificates (e.g. as barbican secret ids). The idea is
to ensure that the certificates used to sign and validate the
glance image are actually trusted by the user.
In order to enable this feature within our driver, all we have to
do is pass the trusted certificate ids (stored as an instance
object attribute) to the method that fetches glance images.
Blueprint: nova-validate-certificates
Change-Id: Ic28f2b3ecf4ca92dcb7e9643c6e0d207d40b5287
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I90c548df545990a4575628d918f2bce72071c9ca
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Recently, a new pep8 rule (H903) was introduced which checks for Windows
style endings. Because of this, Zuul is failing the pep8 job.
The files were converting using dos2unix.
Change-Id: I7ea5bf692ca19895046cb0803ea9c833b19eafc7
According to Openstack summit session [1],
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: Ic328c6d6f47fabd3a9b8c013e60dfd44e9d38ac1
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ibb8ce8e655643161b0b7d4e84f0c2897e9c6417c
Some issues were not caught during the initial mock autospec
patch which was added to compute_hyperv, and now they're causing
some unit tests to fail. This patch fixes those issues.
Secondly, the docs job relies on tools/tox_install.sh to install
nova, but it is not passing the required arguments, causing it to
fail. This patch updates the script so it can properly execute.
Change-Id: I91cbadb2a05ee4880c3fa761696818ec95c40df2
This change ensure that we're honoring the "remove_unused_base_images"
config option, allowing deployers to disable the auto-removal of
old images.
Change-Id: I49a0a83ab34ca0b9da5d589aaa9006d169275b15
Closes-Bug: #1773342
Most of the os-win utils are created through
os_win.utilsfactory, which all rely on its function
'_get_class' to load and initialize the proper Utils
based on the OS version.
This commit patches the mention method, returning
an autospeced mock for the desired Utils instead.
Closes-Bug: #1735588
Change-Id: If0002b2c711aaeaf13273bed9b912fdd9c639a64
We need this in a later change to pull volume attachment
information from cinder for the volume being detached so
that we can do some attachment counting for multiattach
volumes being detached from instances on the same host.
(cherry-picked from commit d2941bfd165055348dd584b630d4e631ef05e328)
Change-Id: If6e869b1c3516220b7deb0599d699caa2ed33889
Related-Bug: #1752115
There are critical known issues related to the cluster driver and
passthrough disks.
When an instance is failed over, the instance attached volumes need
to be accessible on the destination host. This will not happen
transparently for such disks, for which reason the instance may
bounce between a few nodes and then end up in error state,
basically defeating the purpose of the cluster driver.
This change ensures that the Hyper-V Cluster driver rejects
iSCSI/FC Cinder volumes, raising an error that describes possible
alternatives.
Closes-Bug: #1749958
Change-Id: I231b51c648e1349fcb8df4cd818b2d2887a55d69
This change documents how to identify Cinder volumes from within
the guets as well as online resize limitations.
Change-Id: I725e958ae85353acdf1a1eb110f1a03c3629f0b2
We've enabled the release notes zuul job quite late in the release
cycle, for which reason some of the notes are missing, being added
by this change.
This change also adds a reference to the release notes page on
the main compute-hyperv docs page.
Change-Id: If5c717bad101b55379201a02afe6f88b3cd9345d
For some code blocks, we have a superfluous 2-space indentation.
For this reason, the generated docs are quite inconsistent.
This change fixes this issue.
Change-Id: Ib37906f61875c17d32635f3b11937f429a7027fc
This patch adds additional documentation regarding various
features introduced in the Hyper-V Driver, how to configure
the compute node in order to use them, and how to use them:
* Generation 2 VMs
* UEFI Secure Boot
* Shielded VMs
* Setting boot order
* RemoteFX
* Hyper-V vNUMA
* QoS
* PCI devices
* Serial ports
* Nested Virtualization
Additionally, this patch adds more details on how to add the
compute nodes to Nova cells.
Change-Id: Ie475da2a8dca947344de22e287225c972258b3c2
The eventlet clock must be patched with the monotonic clock
in order to avoid issues caused by drifs of system time.
This is done in nova/__init__.py, but if compute-hyperv is
installed after nova, compute-hyperv will overwrite that
file.
Closes-Bug: #1749088
Change-Id: I0d32406a65d1f4d57435766d41a0f1c1efba2782
At some point, we've removed the instance snapshot lock, allowing
destroy requests to proceed immediately. We assumed that this
should be fine as long as we're stopping pending WMI jobs.
The issue is that the snapshot operation is still not fully
preemptive. VHD related operations (e.g. copy, merge, upload to
glance) are not preemptive at the moment, for which reason
destroy requests will fail due to file locks.
Unless the new 'force_destroy_instances' config option is enabled
(disabled by default), we're locking the destroy/snapshot operations.
This partially reverts commit
e4208017fe.
Closes-Bug: #1748394
Change-Id: I3119c5bc5a714be867af19510dfab576f354835b
When spawning instances, we're checking if the instance dir
already exists, in which case we're logging a message, stating
that existing instance files will be reused.
Well, at least that's what we thought we were doing. Actually,
we're always logging this message as the check is wrong.
This change fixes this issue.
Change-Id: I6cf52ae23d90e687103e8bea0b6c4f9eaba6d36c
Closes-Bug: #1747961
Since compute-hyperv is not an official OpenStack project, we cannot
host our docs on docs.openstack.org. For this reason, we'll use
readthedocs.
As readthedocs will not use tox, we have to explicitly provide the doc
build requirements that are not included in requirements.txt.
Unfortunately, we'll have to update this file manually at least once
per release.
Also, reathedocs will invoke sphinx-doc from the /doc dir, for which
reason it cannot find etc/compute-hyperv-config-generator.conf. The
according reference is updated, explicitly declaring the namespaces
to be used when generating the config reference.
Change-Id: Idab6f10f92f7f2e40962f1cabaac8691e6c46619
Lucian Petrut