openstack
/
contributor-guide
Code Issues Proposed changes

Add description of web editor to using-gerrit 

There were a few typos in here that needed to be addressed.
Also, I don't think it is obvious how you get to the
web editor so I added a description for that.

Change-Id: Ifd60307694429cce522e24ced7d12513e5934030
This commit is contained in:
Jay S. Bryant 2018-05-17 13:04:31 -05:00 committed by Ildiko Vancsa
parent b1820a4fdb
commit e7b8c04303
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
doc/source/_assets/using-gerrit/web-editor.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 14 KiB

12
doc/source/code-and-documentation/using-gerrit.rst
View File

@ -31,7 +31,7 @@ commit hook. You only need to do this once per repository you clone::
git review -s
To create your development branch (substitute branch_name for a name
of your choice). Its better to create a new branch for each patch than
of your choice). It's better to create a new branch for each patch than
working from master::
git checkout -b <branch_name>
@ -54,7 +54,7 @@ your changes for review use::
git review
If successful, Git response message will contain a URL you can use to
If successful, the Git response message will contain a URL you can use to
track your changes.
If you need to make further changes to the same review, you can commit them
@ -110,6 +110,14 @@ line, etc- this gerrit feature can be convenient to make a quick
edit and publish the change without having to go through the entire
'git add', 'git commit --amend', 'git review' process.
To access the Gerrit Web Editor click on the icon that looks
like a pencil writing on paper next to the patch set number
at the top of a Gerrit Code Review page for a file.
.. image:: /_assets/using-gerrit/web-editor.png
:scale: 75
Reviewing Changes
=================