Update ChefSpec due to changes made in apache2 cookbook.
Depends-On: https://review.opendev.org/756168
Change-Id: Ie849f5bae082e94581146793f964d0e001a7c8c8
Signed-off-by: Lance Albertson <lance@osuosl.org>
- Cookstyle fixes
- Refactor Berksfile to use groups so we can exclude integration testing
cookbooks
- Update documentation
- Enable sensitive resources for the template[/etc/cinder/cinder.conf]
and to resources improve security.
- Update delivery configuration to exclude integration cookbooks
- Fix ChefSpec output.
- Switch package installations to send packages as arrays instead of individual
package resources. This generally speeds up chef runs.
Depends-On: https://review.opendev.org/701027
Depends-On: https://review.opendev.org/706151
Depends-On: https://review.opendev.org/706157
Change-Id: I73948a67e798477cfe7d3cf62474d0ea96f90db2
The Chef Style Guide[1] does not recommend using hyphens for
cookbook or resource names. To maintain consistency, we should follow
best practices.
[1]: https://docs.chef.io/ruby.html#use-of-hyphens
Depends-On: Ic2b6d8f1cdf719791faaebdbd7e29e789eb3f31c
Change-Id: Ib8c788f69e9545b2d7121199590e3795f2212c7f
* added endpoint attributes (moved from common)
* removed qpid as a messaging option (can be incuded in a wrapper)
* deleted default attributes from nova.conf.rb originated in
openstack-common
* adapted optimized endpoint logic
* removed rubocop exceptions in recipes and regenerated the
.rubocop_todo.yaml containing all remaining exceptions
* added versionbumb for refactored os-identity and common
* moved version up to 13.0.0 for mitaka release
* removed fedora, suse as supported platform
* adapted the specs (unit tests) to work again
* added new logic into templates/default/cinder.conf.erb
* refactored attributes throughout all recipes that were connected to
the attributes used for the cinder.conf.erb template to adapt the new
template attribute syntax
* moved all attributes from attributes/default.rb that were used in
cinder_conf.erb to attributes/cinder_conf.rb
* refactored attributes to fit upcomming template logic
* refactored recipes to fit upcomming template logic
* removed all attributes from default.rb and cinder.conf.erb which are set
as default in attributes, openstack doc and used to render the template
Depends-On: Ifa5a7f4e1df47a3961976e64f654224864c3dcb4
Depends-On: I3262b2e6f792f37c32a446e6567790b82bdd4613
Depends-On: I0547182085eed91d05384fdd7734408a839a9a2c
Implements: blueprint cookbook-refactoring
Change-Id: Idadc97bd7380d6c4f9f6f33d9c6b1215a5f24772
*_python_packages attributes are being moved to -common in order to
remove the duplication from all the cookbooks which are using them
Change-Id: I60798fb39f6167eafd0cc483dca9bb930a236946
Implements: blueprint move-python-db-client-attrs-to-common
As agreed on the mailing list:
https://groups.google.com/forum/#!topic/opscode-chef-openstack/HEL3KqBQIUM
This will allow the ibm_powerkvm platform to be recognized and will
simplify uses of multiple platforms from the same family.
Change-Id: Iebf2aad9f3b4649fb5c27d2fc93ee60c67e42737
Partially-Implements: blueprint add-ibm-powerkvm-enablement
Implements: blueprint platform-family
This change removes the attributes we'll be moving to openstack-common
and changes reference of those attributes to reflect new (more
consistent) namespace. We also fix a broken test which doesn't properly
converge after changing a node attribute. Lastly, we handle the rabbit
mq attribute use_ssl.
Change-Id: I12b9c33f89eb35a66bae7420340aff10efd18b1c
Implements: blueprint clean-up-attr-for-mq-and-db
Consolidate all the .rubocop.yml into a single file, finished out cleanups for
all the Ruby files.
Change-Id: I92d5983724d5d0185cd25bea6a0f46657a6c05d4
Addresses: blueprint rubocop-for-block-storage
Per the mailing list thread, introducing Rubocop as a replacement for Tailor.
Assuming Jenkins likes this, more pedantic patches will follow to make Rubocop
happy. So far this is just spacing issues and adding UTF-8 headers, but more
work will need to be done to remove all of the changes for the .rubocop-todo.yml
Change-Id: I590ac5ec03ce6a00dd73027d6798e36105a32af1
Prior, the cronjobs were being set if there was more than one scheduler node.
This logic will ensure only one node at a time will be set to run the audit.
Cron job is also now configurable to preference. Prior was setting to every
minute, which is more frequent than necessary.
Change-Id: I27b760b9260963bad3459bf2eb220e2c2966eb0f
Noticed that every recipe in the cookbook had a declaration for the
cinder.conf template, with a notify to the service defined in that recipie.
I moved the template, and the variables that it needs to populate,
to cinder-common.rb, included that in all the other recipes,
and changed the notify in the template to subscribes in each service
Also, added a spec for this.
All tests pass
Change-Id: Ibcab9566a907e1ea9febbd61e37b9587625a15e6
These patches make assumptions that are a bit too liberal.
As these cookbooks are more widely used, these should be
moved into a wrapper cookbook.
Change-Id: I5348876712418a520659aab606065e5a5b288d99
Nice thing about the new syntax, you can notify resources defined later.
FC043: Prefer new notification syntax: cookbook-cinder/recipes/api.rb:91
FC043: Prefer new notification syntax: cookbook-cinder/recipes/scheduler.rb:49
FC043: Prefer new notification syntax: cookbook-cinder/recipes/volume.rb:61
FC043: Prefer new notification syntax: cookbook-cinder/recipes/volume.rb:84
* Fixes hard-coded db password for Cinder with lookup
of the cinder_db_chef_role attribute
* Fixes typo of glance_host and glance_port in config template
* Fixes incorrect keystoneclient.middleware reference in api-paste
template
* Removes recipes/common.rb, as it was pointless now that the
config template processing had to be moved into each service recipe
* Removes the recipes/setup.rb, as it was all for the API service,
so moved the keystone_register calls directly into the api.rb recipe
This cookbook looks a bit more like RCB due to some difficult to solve
OOO issues.
1. Needed to duplicate the cinder.conf template in each service needing it, due
to the following reasons:
a. Having a notifies in common.rb to restart services that were not defined
yet (but in later recipes) broke the recipe.
b. Having notifies in common.rb for services that were not installed breaks
things.
Due to this very diffuclt issue to solve, felt it was okay to duplicate the
template rendering.
2. Need to lookup the database password from a mysql server query, like we do
elsewhere. Have not tackled this yet. Hardcoded to see if service would
finally install.
3. Reformatted a few things to match our other openstack cookbooks.
4. Found a few bugs with endpoints needing '.to_s', or missing @ reference
in template.
* Updates the attributes to align with openstack-common and
the other AT&T-standardized OpenStack cookbooks
* Splits the single server recipe out into recipes for
common, api, setup, volume and scheduler so that nodes
can get the Cinder API, Cinder Scheduler and/or Cinder Volume
service installed separately
* Pull in the isci and tgt packages, matching RCBOps volume recipe
Ghanshyam Mann