- Cookstyle fixes
- Refactor Berksfile to use groups so we can exclude integration testing
cookbooks
- Update documentation
- Cleanup line wraps
- Update delivery configuration to exclude integration cookbooks
- Fix ChefSpec output.
- Add missing ChefSpec tests
- Switch package installations to send packages as arrays instead of individual
package resources. This generally speeds up chef runs.
- Cleanup array syntax using %w() instead of []
- Remove FWaaS recipe as it's been unmaintained upstream.
Depends-On: https://review.opendev.org/701027
Depends-On: https://review.opendev.org/706101
Depends-On: https://review.opendev.org/706151
Change-Id: Ie3b65b701235bae65a1797d63d6a55dd6fc9958e
- Switched default linter to cookstyle
- Renamed rake tasks to better conform with Chef conventions
- Normalized the template banner
Change-Id: I80d825722a3218b34a5dee38b60017492e3768e0
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: I4d77e65dac01c138a82f1b11fefb8cc33cd04194
blueprint: rakefile
- Disable the NumericLiterals cop in the .rubocop.yml file - this cop
enforces an underscore '_' every 3 characters of an integer. This doesn't
make much sense in our use case and reduces readability. Especially for port
numbers.
Change-Id: Iea9504a7ca13485ab5a63c06f7c2d3547fa79519
Addresses: blueprint rubocop-integer
Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.
- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Move Excludes for non-existent folders to Includes so they
automatically cover future additions
Change-Id: I1e984e4dd496977d29f483199b3b091f1481dc47
Implements: blueprint lint-and-unit-testing-for-havana
- Remove individual directory/.rubocop.yml file
- Adjust .rubocop.yml to include all other directories
- Adjust Strainerfile to use the single .rubocop.yml file
Change-Id: Id64fae024f8972e87919f837f31f487a43744d5f
Addresses: blueprint rubocop-for-dashboard