Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: I6e007888e1b37a54628ab5c09e62f636a0b622ed
blueprint: rakefile
- Disable the NumericLiterals cop in the .rubocop.yml file - this cop
enforces an underscore '_' every 3 characters of an integer. This doesn't
make much sense in our use case and reduces readability. Especially for port
numbers.
Change-Id: I68cc5e8191bd8ef139aad220fad9f1ce3275bcbd
Addresses: blueprint rubocop-integer
Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.
- Upgrade rubocop to 0.18.1
- Make the rubocop.yml the same as others plus the exception at the bottom
Change-Id: I030322516fcdb1d742d7d4170c1f4436e8115852
Implements: blueprint lint-and-unit-testing-for-havana
Ghanshyam Mann