- Switched default linter to cookstyle
- Renamed rake tasks to better conform with Chef conventions
- Normalized template banner
Change-Id: I76bdb4149965ab7b23709762559bd6c71753cc8b
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: Ia822611f48f27b1027f508004150f83b0a2762f7
blueprint: rakefile
- Disable the NumericLiterals cop in the .rubocop.yml file - this cop enforces
an underscore '_' every 3 characters of an integer. This doesn't make much
sense in our use case and reduces readability. Especially for port numbers.
Change-Id: I58447925ac7a05fb6848c31ac67285131fb8c872
Addresses: blueprint rubocop-integer
Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.
- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Move Excludes for non-existent folders to Includes so they
automatically cover future additions
Change-Id: I08e8822a7ad7a5330881c14ffb07db3842bd5d9c
Implements: blueprint lint-and-unit-testing-for-havana
- Update .rubocop.yml to include recipes/**
- Update recipes to be rubocop compliant
Change-Id: Ibb2113e266427b1d9b509d1e66389462e1ff0189
Addresses: blueprint rubocop-for-ops-database
- Update .rubocop.yml to include spec/**
- Update metadata.rb to be rubocop compliant
- Update spec files to be rubocop compliant
Change-Id: If059f01f46102282ffeed9323f6e06fa78f8597c
Addresses: blueprint rubocop-for-ops-database
- Update rubocop config to handle entire repo in one file
- Update Strainerfile to run rubocop only once
- Update attributes to comply with rubocop
Change-Id: I299c2775a5a124b0af74f2e3d844cbd91f93380f
Addresses: blueprint rubocop-for-ops-database
Removing tailor, cleaning up metadata and Gemfile and adding TESTING.md
Addresses: blueprint rubocop-for-ops-database
Change-Id: Ia2e02864b3c157b44cf0cf483801c6bb19f83054