- Switched default linter to cookstyle
- Renamed rake tasks to better conform with Chef conventions
Change-Id: I84ebeb49823b022e85dddea9fcdd358b27be50a3
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: Ie245028db93d6d49eb224747f2c0697c9b6bdcf5
blueprint: rakefile
- Disable the NumericLiterals cop in the .rubocop.yml file - this cop enforces
an underscore '_' every 3 characters of an integer. This doesn't make much
sense in our use case and reduces readability. Especially for port numbers.
Change-Id: I4e7f7c03efc501857afb4c5ecd7af1bba107a8c7
Addresses: blueprint rubocop-integer
Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.
- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Move Excludes for non-existent folders to Includes so they
automatically cover future additions
Change-Id: I9473903e19f075cff520a2fa7602ad779e7f13db
Implements: blueprint lint-and-unit-testing-for-havana
Removing tailor, cleaning up metadata and Gemfile and adding TESTING.md
Addresses: blueprint rubocop-for-ops-messaging
Change-Id: I4734194aa52973dbaeb299e5970802a38b326dc5