Commit Graph

10758 Commits

Author SHA1 Message Date
OpenDev Sysadmins b1c29d77b6 OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
2019-04-19 19:31:40 +00:00
Helen Walsh 3c7fc7f27c VMAX driver - snapshot creation and immediate deletion fix
Creating and immediately deleting a snapshot greater than 50GB
fails. This patch rectifies the issue by passing the
WaitForCopyState parameter into the CreateElementReplica SMI-S
function when creating the snapshot.

Change-Id: I5aa4a77cb8208bb805551074a28d8b722d6eb22c
Closes-Bug: #1662950
(cherry picked from commit 3cdbcba1e2)
2017-07-19 12:03:19 +01:00
Jenkins a5c1179027 Merge "VMAX driver - Close ecom connections" into driverfixes/newton 2017-06-19 14:28:04 +00:00
Helen Walsh 3d3af7e4fd VMAX driver - Close ecom connections
Every secure connection to the ECOM was not being closed after
use. This fix closes each connection after use. Due to not being
able to mock pywbem there is no unit test for this fix.

Change-Id: I0730c709b9fdc20410de06ca3f9705c9ea77d098
Closes-Bug: #1689760
(cherry picked from commit 430e8c9fd8)
2017-06-19 11:43:01 +00:00
Helen Walsh 3d10a8663b VMAX driver - Detaching volumes if part of two or more MVs
When Live migration is used extensively there can be scenarios
where a regular attached volume can belong to two or more Masking
Views. Because of this, we did not remove the volume from the storage
group, which is not typical behaviour. In this fix we use a temporary
file to determine if a terminate_connection is a regular detach or a
part of the live migration process.

Change-Id: Ide38fa21d65859a5516c577a9983124d998a2e95
Closes-Bug: #1684595
(cherry picked from commit 9d2466bb29)
2017-06-19 11:36:58 +00:00
Helen Walsh 429193da22 VMAX driver - Rollback error on Live Migration
This patch fixes an issue where errorMessage is not getting reassigned
from None in the method ._get_port_group_name_from_mv., having the knock
on effect where errors are not being picked up in subsequent calls or
conditional checks.

Change-Id: I74a85aaa912a7f4c22abbf48f0a5d1bd4538c098
Closes-Bug: #1686174
(cherry picked from commit b44f55c516)
2017-05-30 13:05:28 +00:00
Helen Walsh 2148567c04 VMAX driver - Pre-zoned port group fix
If there are more than one masking view on the same compute node
with different portgroups, then code did not always pick the
correct masking view to extract the port group from. This can
happen when a system is pre-zoned FC.

Change-Id: I6787f9415d97ce5988984f3aeac05c02c5217aac
Closes-Bug: #1682176
2017-05-29 14:40:21 +00:00
Gorka Eguileor bc1e8d6782 NFS Backup: Fix overwritting backups
When using the NFS backup driver if we do multiple backups using the
same container we end up overwriting older backups.

The issue comes from a misunderstanding in the Posix backup driver of
the purpose of the "prefix" metadata used in the ChunkedBackupDriver
base class.

This prefix is for the name of the backup objects to store, but unlike
the prefix for the volumes, here it must be unique as the base driver
will only add numbers to identify the chunk (for the volume we add the
volume id).  Unfortunately the Posix driver just assumed that the prefix
had the same meaning as the prefix for volumes thus making one backups
override one another.

This patch changes the prefix generated by the Posix driver so we have
the following format: "volume_$VOL_ID_$TIMESTAMP_backup_$BACK_ID", thus
allowing multiple backups in the same container.

The new name is backward compatible with existing backups because the
new prefix will only be used on new backups as the prefix for already
existing backups is stored in the DB.

Change-Id: I2903c27633facde6370d95ba0b9e06025ccaef26
Closes-Bug: #1628768
(cherry picked from commit 535e717970)
(cherry picked from commit 640b9dc2b7)
2017-05-23 16:42:53 +02:00
Marc Koderer e4d719f646 NetApp: Refresh directory before waiting
After image cloning the NFS client cache needs to be refreshed.
This can be accomplished by touching the directory hosting the
cached image file.

See also: https://bugs.launchpad.net/nova/+bug/1617299
Co-Authored-By: Sebastian Schee <sebastian.schee@sap.com>
Co-Authored-By: Goutham Pacha Ravi <gouthampravi@gmail.com>

Closes-bug: #1679716
Change-Id: If392f41f65978721668b53cfab94393f074d24e9
(cherry picked from commit ff6acd62ec)
(cherry picked from commit cd3c1c2c37)
2017-05-14 00:57:56 +00:00
OpenStack Release Bot 3b5a0fcef9 Update UPPER_CONSTRAINTS_FILE for driverfixes/newton
Change-Id: I044c564f50fb31c6b706947826cbff15375820af
2017-05-07 14:59:45 +00:00
OpenStack Release Bot 1bb85c0c16 Update .gitreview for driverfixes/newton
Change-Id: I359dacd975960459e4b3ad21d5e71b8513399daf
2017-05-07 14:59:44 +00:00
Jenkins 08bfc7d817 Merge "Separate out routine for getting qemu_img_info" into stable/newton 2017-05-04 16:56:17 +00:00
Sean McGinnis 68e0fb82f3 Give more time for LVM deactivation
Current code retries three times for deactivation to complete,
waiting one second between retries. On some heavily loaded
systems, and apparently the gate, this is not enough time for
the operation to complete.

This attempts to work around those slower systems by increasing
our retries to 5 and adding a backoff of 2 seconds to give it
more time.

Change-Id: I4f40a1984fe828c8ff965033f7e25b1d7516ab1e
Closes-bug: #1687044
(cherry picked from commit 5744301777)
2017-05-02 15:33:59 +00:00
Eric Harney 02fc914ba7 Don't use tempest special_fields
This has been removed, which now causes these
tests to fail.

Tempest change: https://review.openstack.org/#/c/448869/

Cherry picking back to stable/newton as it is blocking a critical
fix for glance_store: https://review.openstack.org/#/c/417329/

Change-Id: I31310dc9b3834e0bf16618db3e473f17eab2b610
(cherry picked from commit 39c7165e33)
2017-04-27 12:55:39 -04:00
ShunliZhou 4a7fba500b Separate out routine for getting qemu_img_info
Without try...catch like fetch_to_volume_format,
fetch_verify_image will prevent a raw image from being used when qemu-img
is not installed.

So we add a try...catch for qemu_img_info for fetch_verify_image and
separate this into its own routine.

This fixes the failure if you create a volume with a raw, nonqemu image
and don't have the qemu packages on your system.

Change-Id: I3aaf43a453e7096161780d9bfc2515c66a3a9f2c
Closes-Bug: #1674771
(cherry picked from commit 70a0cc921f)
2017-04-11 06:43:45 +00:00
Shay Halsband 908def6bb9 XtremIO: allow a cloned volume with larger size
* In case the new volume is larger than the cloned one,
    resize the cloned volume.
* Added unit test for success and failed resize.

Co-Authored-By: Xinli Guan <xinli@us.ibm.com>

Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22
Closes-Bug: #1554778
(cherry picked from commit 105e625328)
2017-04-07 14:57:56 +03:00
Jenkins 26eb13da25 Merge "[BugFix]Cinder forgets to update 'deleted_at' when deleting" into stable/newton 2017-04-05 20:10:37 +00:00
Jenkins f64c4f0a7b Merge "VMAX driver - shapshot will fail if default storage group is missing" into stable/newton 2017-04-05 20:05:15 +00:00
Jenkins e4dc6ada79 Merge "VMAX driver - Live Migration is dropping connection" into stable/newton 2017-04-05 19:50:24 +00:00
TommyLike 8771277b0f [BugFix]Cinder forgets to update 'deleted_at' when deleting
Usually we would update the 'deleted_at' column when
soft-deleting records, otherwise the 'db purge' command
would fail because it depends on the 'deleted_at' column.

Closes-Bug: #1671354

Change-Id: Ib302488d3a007df09a2e7ece40488c00bf732119
(cherry picked from commit f9012466db)
(cherry picked from commit 1695e7c0cb)
2017-04-05 15:04:09 +00:00
Jenkins 6c2575dc25 Merge "NetApp: Track SVM and Cluster scoped credentials" into stable/newton 2017-04-04 17:42:07 +00:00
Helen Walsh 86ceab311b VMAX driver - shapshot will fail if default storage group is missing
Fixed as part of:

VMAX driver - Implement volume replication for VMAX

Volume replication supports disaster recovery solution where
there has been a catastrophic event in your data centre for
the VMAX array.

Change-Id: I2aafe564cdb31895756b4b8884af2635b054ae59
Implements: blueprint add-vmax-replication
(cherry picked from commit 67a2178eb4)
2017-04-04 14:11:05 +01:00
Helen Walsh 23eea5313a VMAX driver - Live Migration is dropping connection
When Live migrating from one compute node to another the connection
drops and requires the instance to be rebooted. To prevent this
from happening we need to share the storage group and port group
between masking views.

Change-Id: I1483ca38362c5ff1724940c2abf1179e75e02c8e
Closes-Bug: #1676459
(cherry picked from commit 069dd5b80d)
2017-03-31 15:52:47 +01:00
Jose Porrua ff961336ee NetApp: Track SVM and Cluster scoped credentials
This fix avoids logging an exception when a user
chooses to use an SVM scoped account. cDOT
driver requires cluster scoped privileges to
gather backend statistics, performance
counters, etc. These APIs are not available for
SVM scoped credentials.

Closes-Bug: #1660870
Change-Id: If2e3bae98db225ff0cfc9e868eaaeef088135562
(cherry picked from commit 0f9b6e9ac2)
(cherry picked from commit 109177a366)
2017-03-29 15:55:32 -04:00
Jenkins 98a11913ea Merge "cinder-backup - coordination not initialized" into stable/newton 2017-03-29 04:18:12 +00:00
Jenkins 56786a3c88 Merge "Fix execution of upload-volume-to-image" into stable/newton 2017-03-29 04:18:04 +00:00
Eric Harney 46799c4ff5 Bump prlimit cpu time for qemu-img from 2 to 8
Users have reported that the current CPU limit is not
sufficient for processing large enough images when
downloading images to volumes.

This mirrors a similar increase made in Nova (b78b1f8ce).

Closes-Bug: #1646181

Change-Id: I5edea7d1d19fd991e51dca963d2beb7004177498
(cherry picked from commit 52310fa864)
(cherry picked from commit 2a5e0086e1)
2017-03-13 16:44:58 +00:00
Jenkins df539f51d4 Merge "VMAX Driver - disable initiator check by default" into stable/newton 2017-03-08 20:24:54 +00:00
Jenkins 1eba820a04 Merge "VMAX driver - widen locking around storage groups" into stable/newton 2017-03-08 19:56:09 +00:00
Helen Walsh 161cffca64 cinder-backup - coordination not initialized
Fix is based on a previous fix to initialize coordination in
cinder-backup. https://review.openstack.org/#/c/332925/

Change-Id: Ib9cb968a3e4d7fcd9b9777202fb9d85487f573cf
Closes-Bug: #1669521
(cherry picked from commit b61bb0ac37)
2017-03-08 05:10:27 +00:00
Jenkins ca6e7b4974 Merge "VMAX driver - copy state fix" into stable/newton 2017-03-07 21:40:17 +00:00
Zhiteng Huang a73e37aff5 SolidFire: Handle connect_volume() failure when create vol from image
Currently the _create_image_volume() method in solidfire.py doesn't
catch the exception for initialize_connection() or connect_volume(),
therefore when something wrong happens at this stage, which is as
critial as image conversion, the empty volume created as image cache
wouldn't be deleted.  And that invalid image cache would cause all
consecutive volume creation from same image fail silently.

This change makes simple adjustment of the code to make sure the
errors happen at connecting volume to controler stage is being
covered.

Change-Id: Idd192be86a83dc341431593ab27bed9178cc36d1
Closes-bug: #1663782
(cherry picked from commit 55c1863e1d)
2017-02-17 20:04:00 +00:00
Helen Walsh 259ef405ef VMAX Driver - disable initiator check by default
For each existing masking view we check if the initiator group
matches with the initiators of the compute host. The is a very
expensive check and should be turned off by default. To turn
it back on we will put a initiator_check flag in the cinder.conf

Change-Id: Ia0677bafe9d586e9e65cd0d63924259f9a2e6ee8
Closes-Bug: #1663312
(cherry picked from commit 81aae7f712)
2017-02-16 15:02:30 +00:00
Jenkins dbc0f1a7d9 Merge "Prepare for using standard python tests" into stable/newton 2017-02-10 18:32:21 +00:00
Goutham Pacha Ravi 7d2afb298a Fix execution of upload-volume-to-image
While executing the image utils methods, we need to take
care not to use root privileges if the environment is running
in 'secure' mode.

This is a partial back-port of the fix committed in
Iae35c722eb4b6b7d02a95690abbc07a63da77ce7 in ocata.

Change-Id: I8a4912d10797ac8521acc27d02b97b00f8efdb7a
Closes-Bug: #1649209
2017-02-10 14:53:58 +00:00
Helen Walsh 035d6d3a30 VMAX driver - widen locking around storage groups
There is an issue around the locking of storage groups.
There is insufficent locking when multiple processes may
be adding and removing volumes from the same storage group
e.g. deleting the last replicated volume while another
process is creating one. This patch rectifies this issue.

Change-Id: I0138ace1e3d8f1e62d5422864481221915907a25
Closes-Bug: #1660374
(cherry picked from commit 84d463380a)
2017-02-09 16:30:13 +00:00
Helen Walsh 259ee5d2a0 VMAX driver - copy state fix
Creating a cloned volume can fail when the source volume
is bigger than 50 GB. This occurs when we try to unlink the
source from target before all the tracks are copied.
This patch fixes the issue by adding a 'WaitForCopyState'
parameter to the CreateElementReplica SMI-S function.

Change-Id: Iac8ce48dda6f21a49838e4ca900a4f3ba1a9b2a7
Closes-Bug: #1660378
(cherry picked from commit d43395d0af)
2017-02-08 17:48:59 +00:00
Peter Wang 5a02c7d740 VNX: Update sg cache if it already existed
This can avoid redundant sg creation during volume attachment,
thus benefiting the overall driver performance.

Closes-bug: #1657964
Change-Id: I1d96468248d512b59f77ab93d486efb3ff29d6ca
(cherry picked from commit 2d5bad7928)
2017-02-06 22:22:40 -05:00
Andreas Jaeger 02c36965e7 Prepare for using standard python tests
Add simple script to setup mysql and postgresql databases, this script
can be run by users during testing and will be run by CI systems for
specific setup before running unit tests. This is exactly what is
currently done by OpenStack CI in project-config.

This allows to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.

See also
http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html

Update devref for this.

Needed-By: I628f825d9200f7951eae46b7be78b111b1a8141c
Change-Id: If549e6f108ec6184a432d5050da4386efe794a4e
(cherry picked from commit 1c91c0f033)
2017-02-03 09:34:01 +01:00
Jenkins 79ad4598aa Merge "backup of active 3par ISCSI bootable volume fails" into stable/newton 2017-02-01 18:05:54 +00:00
Jenkins e2f0bd96c7 Merge "VMAX driver - Heat detach issue." into stable/newton 2017-01-31 20:43:34 +00:00
stack 7e59cad656 backup of active 3par ISCSI bootable volume fails
1.Backup of ISCSI volume with chap enabled on it, fails
because it choose online copy code path where copy
volume is background process on 3par and we do not
wait for process to complete and setting of any attribute
on cloned volume failed during online copy of data.
This patch ensures it choses non online copy code path
for above scenario.

2.Backup of attached volume fails with snapCPG error
Sometime, during online clone operation, we set snapCPG and
userCPG on cloned volume but when we get cpg of
cloned volume we get an error as these attributes
do not set for cloned volume on 3par.
This patch ensure if cpg is not available for volume
from 3par it will take default value from 'host' attribute
from volume param.

Change-Id: I8dab8fd4e56c38557c46e4ae9a01fb6fead2a2a8
Closes-Bug: #1644238
Closes-Bug: #1646396
(cherry picked from commit 6543c0e13d)
2017-01-31 12:00:12 +00:00
Helen Walsh be2ad10ef6 VMAX driver - QoS key fix
QoS key value was changed from 'qos_specs' to 'qos_spec' in a
feedback comment in _initial_setup. The side effect of this
was QoS was never enabled.  Please refer to
https://review.openstack.org/#/c/307502/

Change-Id: I32a203c1a29e214656f6684268266df589db67bd
Closes-Bug: #1656029
(cherry picked from commit d4d88f31c6)
2017-01-29 18:57:31 +00:00
Helen Walsh 5cb9852115 VMAX driver - Heat detach issue.
There is a threading issue in Heat on a delete stack. All
detaches happen simultaneously. The fix locks the portion
of code to determine accurately, the number of volumes left
in the storage group, at any given time, to prevent
attempting to remove a volume that is the last in the
storage group.

Change-Id: I84164a9abac35d962408febbe8d3af759beb6a94
Closes-Bug: #1630535
(cherry picked from commit d9ccfaef8e)
2017-01-28 18:25:39 +00:00
Chuck Fouts 412a97ecfa NetApp Data ONTAP headroom calculation error
The NetApp Data ONTAP drivers contain a minor calculation error
that can lead to misstated controller utilization values used by
the filter & goodness functions.

Closes-Bug: #1631460
Change-Id: Idf6a33a388e732acd2f3154ac7d0a6490f8cf88e
(cherry picked from commit f1bbaea40a)
2017-01-26 17:00:55 +00:00
Michał Dulko b3b2e136c7 Delete volume when rescheduling
If a reschedulable failure happens in the driver after the volume was
created on the backend, it will get orphaned and only way to remove it
will be through backend internals. This commit adds an additional
delete_volume call to the driver after the volume got rescheduled to
make sure no volumes will get orphaned.

Change-Id: Idd86a4842bdc6ecf0cabbeff0a9c9704e030302a
Closes-Bug: 1561579
(cherry picked from commit 7f09229d6c)
2017-01-16 15:04:41 +01:00
Jenkins 31e013fd9f Merge "Huawei: Fix the rest query timeout problem" into stable/newton 2017-01-13 00:11:40 +00:00
Jenkins b1c5a2c284 Merge "NetApp cDOT driver fails to clone from NFS cache" into stable/newton 2016-12-24 19:58:25 +00:00
Jenkins f1144c98c3 Merge "Do not manage VG with > 1 volume in Kaminario driver" into stable/newton 2016-12-17 09:21:54 +00:00
huananhuawei cec8d5e982 Huawei: Fix the rest query timeout problem
Due to the amount of query data is too large to cause rest
query timeout.

This commit fixes that by matching by name when rest query

Change-Id: Ied73574658403ed04cb238c953b11d56c9d35ba1
Closes-Bug: #1633956
(cherry picked from commit d4ae67db31)
2016-12-15 09:13:22 +00:00