This changes the logic of getting cancellation grace
period of task runner before closing it: to move the
liveness check into the cancel_all() method in the
scheduler rather than ask the resource if it's IN_PROGRESS.
Change-Id: Ia2a03de227ff15cdce1b3dbb6cd6bff6c5a50a15
Partial-Bug: 1693495
(cherry picked from commit 8c62e96947)
Don't generate/update user password again if
the user has already been created, to make sure
the occ credential works.
Change-Id: Iffcb7aa0fb256d36aef64f5fd0ec37af4bf47be8
Closes-Bug: #1697623
(cherry picked from commit e23fcfe93a)
The property 'metadata' doesn't make sense for resource
OS::Heat::DeployedServer, because the deployed server can
be provisioned out of nova. The deployment metadata
we can set by resource.metadata, so ignore the
property 'metadata' and do nothing if update it.
We cherry picked from master where we mark deprecated
status for the property 'metadata', and just ignore it
in stable/ocata.
Change-Id: Id218d699a0d49f127243ec537f719dd247197279
Closes-Bug: #1693661
(cherry picked from commit 08e8e790bd)
When resource references are used for properties restore
does not work for nova server and volume resources.
This patch fixes it and adds a functional test for it.
Conflicts:
heat/engine/resources/openstack/nova/server.py
There is very minor conflict in server.py as the code
has been changed in pike for translation refactoring.
Change-Id: I34efb3f4e0d3578d95134793f5c5d413667790e0
Closes-Bug: #1687009
(cherry picked from commit a8129573d2)
Since we're comparing local time to database time, we need to correctly
handle negative offsets to account for clock skew. The datetime.timedelta
class always reports a positive number of seconds, but with a possibly
negative number of *days*. Therefore, take the days into account.
Change-Id: I4422e4cf41cb57cdc89548d01b0abc27cda914ef
Closes-Bug: #1688327
(cherry picked from commit f3f05c9a3f)
When an update fails, we may have copy some chunk of resources or
parameters to the new template. If the version was updated and the new
resources require the version, this can lead to a state where the stack
is in an usable state. This synchronizes the version when a failure
happens.
Change-Id: I2faf8f3541fc800ea61c417e5575f4a56a83665b
Closes-Bug: #1620696
(cherry picked from commit 45fde10197)
This was most likely meant as a max 2s delay here, not a max 2ms
delay.
Also includes a related change: when retries for metadata updates are
attempted, make sure we do not have a stale value of the atomic_key
(otherwise we'll just inevitably hit the ConcurrentTransaction issue).
Conflicts:
heat/engine/service_software_config.py
Co-Authored-By: Crag Wolfe <cwolfe@redhat.com>
Partial-Bug: #1651768
Change-Id: Ie56e0e4ff93633db1f4752859d2b2a9506922911
(cherry picked from commit e37d9fab8f)
Update the status from FAILED to COMPLETE for
resources which do not have to update or replace.
Closes-Bug: #1663522
(cherry picked from commit f05105ec48)
Conflicts:
heat/engine/resource.py
Change-Id: I9a632691ec8f0682000d704a30039d99d12d71e3
In python-mistralclient, the `workflow_name` argument was renamed to
`workflow_identifier` in version 2.0.0, breaking this resource type. Ensure
that this works with all client versions by passing the first two arguments
as positional rather than keyword args.
Change-Id: Ibbed3af468bbc0d68995495095b6cd340c1ea427
Closes-Bug: #1557575
(cherry picked from commit f682e7afed)
The same way that context was changed to store the attribute in
user_domain_id, use project_domain_id to remove some errors.
Change-Id: I591b6644e113cc90eeb2aff6b628a649ae8d4740
Related-Bug: #1663013
(cherry picked from commit 37b1f7c963)
Make sure only to delete internal ports when user
wants to detach them, and just do detach for
external ports.
Change-Id: I09e686d4e1603c6a8b388772eee900f06b1e775d
Closes-Bug: #1676821
(cherry picked from commit b194775ebe)
Previously, ResourceGroup._needs_update() would raise UpdateReplace
when the ResourceGroup was in CHECK_FAILED status, resulting in
delete/replacement of every resource in the group. Now, it will
return True so that only resources in the CHECK_FAILED status.
Change-Id: I800c4f58feec7c1aaa4897c2ba056e5a74200e5d
Closes-Bug: #1671592
(cherry picked from commit 362069cd1f)
In the deployed-server metadata that configures os-collect-config, the
ec2 collector should not be enabled. ec2 metadata is not typically
available when using the deployed-server resource.
Closes-Bug: #1669842
Change-Id: I33e062b70fdf298908656a8ed3e62ac7cae16a37
(cherry picked from commit 00b82577f1)
We reset the metadata for resources when mark healthy
in change Ibd6c18acf6f3f24cf9bf16a524127850968062bc,
but it doesn't work, because resource policy and group
inherit from multiple class, and the method
'handle_metadata_reset' actually be called now is wrong.
This patch will fix it.
Change-Id: I8583f26b6c8f6c814a00a0a38042484378fa53db
Closes-Bug: #1672596
(cherry picked from commit ebc210375e)
This change improves the bug fixing
I2376f2702672d28b24de5ac4ad0bb81fd7171abe
to handle the unauthorized exception in delete_trust()
of */heat_keystoneclient.KsClientWrapper.
Change-Id: Ic6fd336f63ae995dd4d76b0f31daa85e86f55ab0
Closes-Bug: #1634362
(cherry picked from commit 2b90a14102)
If getting an output from a child stack fails with an error, we didn't pass
on the error message to the parent stack that was requesting it but instead
reported essentially that the given output did not exist.
Change-Id: I5653baf310a29dc4829ad570c769cf67ce12695e
Partial-Bug: #1599114
(cherry picked from commit b90991e00b)
With more then 5% of failure rate in gate. We decide to reduce the possibility
of conflict by reduce the number of signal. Will try to resume the
number back, once we feel confortable.
Change-Id: I90e1d26a67a349f897d895f750d8e57fae98ec1f
(cherry picked from commit 411daeae89)
Instead of calling check_resource on all leaves in the resource graph at
once, sleep a little bit between each call. As it's a tad slower,
delegate it to a thread so that the stack_create RPC message doesn't
timeout when you have lots of resources.
Change-Id: I84d2b34d65b3ce7d8d858de106dac531aff509b7
Partial-Bug: #1566845
(cherry picked from commit 4a500125b3)
Storing in self._user_domain was actually relying on the
oslo_context.RequestContext also storing in self._user_domain, however
this was renamed in change I203acefae8270bd3373b006fa096bea5ef3106f3
to _user_domain_id.
This change switches to _user_domain_id, which avoids infinite
recursion in the heat tripleo undercloud installer.
Change-Id: I1114611f6765e94dcab74943078066bb096f4078
Closes-Bug: #1663013
(cherry picked from commit b44b0c6970)
We stop showing json deserialized message in debug log, because
message will involved with some private credential message (like
password). Let's block it for now, until we get a better solution.
Partial-Bug: #1664792
Change-Id: I07410df56449c5414a5572d07507e17f5858c5c6
(cherry picked from commit 1c32b85d54)
Previously, if a resource was in a FAILED state Heat would set the hook
but not wait for the user to clear it before continuing. It is not clear
what case this was designed to handle, since there's no way that I know
of for the resource to go into a FAILED state while waiting for the
hook.
Change-Id: Iaacc585b9806c08fd5a57c80c10eeb31cb0a8f71
Closes-Bug: #1665699
(cherry picked from commit 5cd7ff3fa6)
Allows to use OS::Manila::Share with share_protocol set to CEPHFS.
Closes-Bug: #1664574
Change-Id: Ia2ece0163a3c25eb28bc0b471cd1797d52fe4e3c
(cherry picked from commit ddb0dff5ab)