Commit Graph

56 Commits

Author SHA1 Message Date
Tony Breeds 345521c643 Retire Packaging Deb project repos
This commit is part of a series to retire the Packaging Deb
project. Step 2 is to remove all content from the project
repos, replacing it with a README notification where to find
ongoing work, and how to recover the repo if needed at some
future point (as in
https://docs.openstack.org/infra/manual/drivers.html#retiring-a-project).

Change-Id: I3db6f86082fca5d5a42479ce8a7be4a06537a759
2017-09-12 16:01:29 -06:00
Samriddhi Jain a47bcb6b73 Turn on warning-is-error for sphinx build
The doc-migration spec requires all projects to treat warnings
as errors during sphinx build. This patches turns that function
on.

Change-Id: I3b57177cc1dfa34dea57e62bbc93fafa40899899
2017-07-15 23:42:17 +05:30
Van Hung Pham bdfa6d59cc Switch from oslosphinx to openstackdocstheme
As part of the docs migration work[0] for Pike we need to switch to use
the openstackdocstheme.

[0]https://review.openstack.org/#/c/472275/

Change-Id: I47d858fafd5d57f00cab9d7a4b87950320febf70
2017-06-30 15:37:13 +07:00
pallavi 68d46529c6 Fix html_last_updated_fmt for Python3.
html_last_updated_fmt option is interpreted as a
byte string in python3, causing Sphinx build to break.
This patch makes it utf-8 string.

Change-Id: I896d6d962e4c7f932bc7e0a566a3b47205be61fb
Closes-Bug:#1693670
2017-06-09 15:05:07 +05:30
OpenStack Proposal Bot 62e08434f8 Updated from global requirements
Change-Id: I66a3cce10c25d92877a9735bd022f3591678c023
2017-05-17 03:49:40 +00:00
OpenStack Proposal Bot 89666baf13 Updated from global requirements
Change-Id: I126f84d400113cd6961ebc50630cc189069a8fe6
2017-04-20 16:18:53 +00:00
Jenkins a607f72dc2 Merge "[Fix gate]Update test requirement" 2017-04-19 21:35:56 +00:00
OpenStack Proposal Bot 3be5ce5bfb Updated from global requirements
Change-Id: I46c49cb556869e99abaf3022858c56cc6d4e8d1d
2017-03-10 03:31:33 +00:00
Colleen Murphy 53565dfd97 Don't call start_tls_s() twice
pyldap's start_tls_s function calls ldap_start_tls_s[1] which, if called
twice, returns LDAP_LOCAL_ERROR which causes a LDAP queries to fail with
the traceback:

 Traceback (most recent call last):
   File "/usr/lib/python2.7/site-packages/ldappool/__init__.py", line 258, in _create_connector
     self._bind(conn, bind, passwd)
   File "/usr/lib/python2.7/site-packages/ldappool/__init__.py", line 227, in _bind
     conn.start_tls_s()
   File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line 1095, in start_tls_s
     res = self._apply_method_s(SimpleLDAPObject.start_tls_s,*args,**kwargs)
   File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line 1071, in _apply_method_s
     return func(self,*args,**kwargs)
   File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line 780, in start_tls_s
     return self._ldap_call(self._l.start_tls_s)
   File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line 263, in _ldap_call
     result = func(*args,**kwargs)
 LOCAL_ERROR: {'desc': u'Local error'}

This means that currently keystone's [ldap]/use_pool and [ldap]/use_tls
options are incompatible. This patch fixes the problem by removing the
unnecessary call.

[1] https://linux.die.net/man/3/ldap_start_tls_s

Change-Id: I6baff12bcbd3b110e62f4bcdfb97c561d7ee5fe9
2017-03-08 22:43:01 +01:00
ricolin 8a41011918 [Fix gate]Update test requirement
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848

Change-Id: I2ff5ed75751f3448ff47c4f598d91f65b21ac84d
2017-03-02 19:53:28 +08:00
Tony Breeds 0016814c3d Add Constraints support
Adding constraints support to libraries is slightly more complex than
services as the libraries themselves are listed in upper-constraints.txt
which leads to errors that you can't install a specific version and a
constrained version.

This change adds constraints support by also adding a helper script to
edit the constraints to remove .

Change-Id: I41c6b3a2c4875128679b2dd8177425dd9f515ebc
2016-12-21 11:45:22 +11:00
Jenkins bef66c354e Merge "update README to reflect actual ldap dependency" 2016-11-23 04:53:11 +00:00
Steve Martinelli 2cee10d1f7 update README to reflect actual ldap dependency
remove references of python-ldap in favor of pyldap.

Change-Id: Id8cba94a4cf76880f785b2b471ed723927cde433
2016-11-12 21:51:00 -05:00
Colleen Murphy 5d69b3fed7 Expose SERVER_DOWN if connection fails
Without this change, ldappool might fail to bind to an LDAP server for
any number of reasons, but eats most of them and instead raises its own
not-very-descriptive error. A network failure or the LDAP server being
down is useful information that a user might be able to do something
with (see this related patch[1]) so let's add that to the list of
exceptions ldappool raises directly.

[1] https://review.openstack.org/#/c/390948

Change-Id: Iebb58f9046707a044ed86d8ce940e4c230ffd2aa
2016-11-08 16:04:23 +01:00
OpenStack Proposal Bot 38003f190c Updated from global requirements
Change-Id: I5145ef99197f11461d1db0d0fc37f030d1b5305d
2016-10-22 01:20:24 +00:00
OpenStack Proposal Bot 99e1a06b0c Updated from global requirements
Change-Id: I6272cb835dc3b55a1b3b9a7b852fc069ba8b94d2
2016-09-30 19:59:55 +00:00
OpenStack Proposal Bot b5935fe318 Updated from global requirements
Change-Id: Iaa8b0de37c735f286052a49808fc6ee49c8607c5
2016-09-28 16:54:07 +00:00
OpenStack Proposal Bot 0bcd0b1cc5 Updated from global requirements
Change-Id: Ia29f6c373f2d37b8ca7af22547662c1301698d4f
2016-06-21 18:00:17 +00:00
OpenStack Proposal Bot 4ce78d2332 Updated from global requirements
Change-Id: I16cefcc471afc6c385da68e84bf27b7ff39911d8
2016-05-30 00:34:32 +00:00
OpenStack Proposal Bot 26766b509d Updated from global requirements
Change-Id: Ifac3a5b2fd0964eb9cfa4a5877433367cbbe1d2c
2016-05-18 02:35:37 +00:00
Jenkins a1a5e5bd09 Merge "Add py3 info to setup.cfg" 2016-05-18 00:55:55 +00:00
Jenkins 4235456eea Merge "Updated from global requirements" 2016-05-18 00:24:13 +00:00
Morgan Fainberg 62b14c6320 Add py3 info to setup.cfg
Add the python 3 classifiers to setup.cfg and proper envs to
tox.ini.

Change-Id: I771c148ee8d246a5a3ac45e3a2e45c1fe3a691b1
2016-05-17 16:51:19 -07:00
Jenkins 902e47efa5 Merge "Raise an explicit BackendError on TLS failures" 2016-05-17 23:43:49 +00:00
OpenStack Proposal Bot 18d77299c6 Updated from global requirements
Change-Id: I09512326aaaee909ce1a204a23ae948f4f2a45d9
2016-05-17 23:35:40 +00:00
Steve Martinelli 5f6748212b make ldappool py3 compatible
* properly utf8 encode password
* switch to pyldap, the drop in replacement for python-ldap

Change-Id: Ic0fc838b8e015d90c946c3d161d096afe0bb7a21
Depends-On: I9cf13a5be63a0abc964c5a6e29c92d16365d89d8
Depends-On: I330b9b8fd3b53a588f0a1ae0c7de16cf03adb3cd
2016-05-17 21:52:23 +00:00
Steve Martinelli cee42d218e use standard docstring convention for parameters
switch from using "Args" to "params" so the generated API docs
look cleaner.

Change-Id: I82b65638e7c758a0dda7d35a1255738ef8c9158a
2016-05-12 21:57:20 -07:00
Jenkins c05f1cf608 Merge "Use standard-library logging to record errors" 2016-05-13 04:02:25 +00:00
Charles Duffy 91f5cbc36f Use standard-library logging to record errors
This is a port of a pull request from the old ldappool repo [1]

ldappool frequently catches and ignores transient errors.
There's nothing generally wrong with this -- but if the user
chooses to give the ldappool module a DEBUG priority level,
they really ought to be able to see these. This change makes it
so (and logs final connection errors with the higher ERROR level).

[1] https://github.com/mozilla-services/ldappool/pull/9

Change-Id: I223584393e6010845a5e7eb6aa619a77f6aba84f
2016-05-12 20:45:32 -07:00
Lorenzo M. Catucci 61695772c5 Raise an explicit BackendError on TLS failures
This change is a port of an existing pull request for ldappool [1]

It simply raises a more appropriate error / stacktrace if unable
to bind.

[1] https://github.com/mozilla-services/ldappool/pull/3

Change-Id: I3a17160a76122a1e4d05112fc86e346dea5dd88b
2016-05-12 20:14:05 -07:00
Colleen Murphy b08b776fdc Fix pool_full race condition
Sometimes the main thread starts before the spawned thread, which means
that the thread that is supposed to hold open a connection starts after
the main thread has already successfully made a connection. This means
that the test for a successful connection attempt[1] was nearly useless
since the main thread would get the connection first and activate it[2]
no matter how long the spawned thread waited, and the test for a failed
connection attempt[3] would intermittently fail since is sometimes able
to get the connection before the busy-waiting worker thread does.
Adding a short sleep in the main thread ensures that the main thread
yields to the worker thread and it can grab the connection first so we
can actually test what happens in the main thread.

[1] http://git.openstack.org/cgit/openstack/ldappool/tree/ldappool/tests/test_ldappool.py#n183
[2] http://git.openstack.org/cgit/openstack/ldappool/tree/ldappool/__init__.py#n167
[3] http://git.openstack.org/cgit/openstack/ldappool/tree/ldappool/tests/test_ldappool.py#n193

Change-Id: Ic32ef931cd672907dd14d5ec6339a6d7d9a2018d
2016-05-12 19:16:28 -07:00
Steve Martinelli feed0a08c8 additional files to ignore in .gitignore
when using tox and other tools, we should ignore a few additional
files.

Change-Id: I6fdf25223258c5f44483118553c547bdde19f864
2016-05-12 13:51:59 -07:00
Monty Taylor d4c8129cec Fix license in setup.py
While the ldappool project is MPL and the license info is appropriately
associated with Tarek, setup.py is actually not a file written by him -
it is an exact copy of the boilerplate OpenStack setup.py file which is
Apache licensed. There should be no license issues with the project with
the OpenStack setup.py file being in use, as neither license are
incompatible with each other.

Change-Id: I0d334e624afe62a53b3324ee45ca9bc454ae1d4a
2016-05-12 13:51:17 -07:00
Steve Martinelli 96d81b06e2 add .gitreview and fix ldappool gate
the docs job wasn't passing, and no .gitreview file

Change-Id: Ida0d366d924e2bcfc1b4efc14411240ee70490ae
2016-05-12 13:50:05 -07:00
Morgan Fainberg a4fbd7263e Merge pull request #1 from morganfainberg/import
Add support for tox unit testing
2016-05-12 09:25:09 -07:00
Morgan Fainberg a6495a7af0 Add test-requirements for py27 testing
Add the requirements for py27 testing.
2016-05-12 09:24:14 -07:00
Morgan Fainberg ceca46e006 PEP8 fixes
Fix pep8 errors, add appropriate flake8 exceptions.
2016-05-12 09:20:06 -07:00
Morgan Fainberg 6350323b7f Add support for tox unit testing
Add support for tox unit testing prior to import into openstack's
gerrit/CI system.
2016-05-12 08:36:14 -07:00
Tarek Ziade 56597fb23f Merge pull request #6 from charles-dyfis-net/prefer-setuptools
Use setuptools when available
2013-04-22 13:27:45 -07:00
Tarek Ziade a8594620ac Merge pull request #5 from charles-dyfis-net/issues/4
UTF-8 encode passwd only when set (fixes: #4)
2013-04-22 13:27:26 -07:00
Tarek Ziade c25bba5348 Merge pull request #8 from charles-dyfis-net/issues/7
Initialize conn in _create_connector (fixes: #7)
2013-04-22 13:25:04 -07:00
Charles Duffy b0f5bff824 Initialize conn in _create_connector (fixes: #7) 2013-04-22 15:22:13 -05:00
Charles Duffy 21d35ae336 Use setuptools when available 2013-04-18 17:12:14 -05:00
Charles Duffy 0e1da6275b #4: UTF-8 encode passwd only when set 2013-04-18 16:59:32 -05:00
Tarek Ziade 6c43653950 starting 1.1 2012-02-27 23:08:32 +01:00
Tarek Ziade 4325e8c172 raised version 2012-02-27 23:06:58 +01:00
Tarek Ziade e8f0af539c preparing 1.0 2012-02-27 23:05:12 +01:00
Tarek Ziade b60da0949a Merge pull request #1 from mcdonc/fix.use_tls
fix use_tls flag
2012-02-27 13:57:44 -08:00
Chris McDonough d1f800739f fix use_tls flag 2012-02-26 02:58:00 -05:00
Tarek Ziadé e5c62a3946 packaging tweaks 2011-10-28 18:39:34 +02:00