openstack
/
designate
Code Issues Proposed changes

Validate NS records on a pool during an update 

Calls validation on a pool ns_records list during an
update.

Closes-Bug: #1655042
Change-Id: I53342b9602ebfb6e0c4dffbba3c8cf1d5399787a
This commit is contained in:
Graham Hayes 2017-01-31 17:14:12 +00:00
parent a02ddcb178
commit c135dc7e95
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
designate/manage/pool.py
View File

@ -142,6 +142,16 @@ class PoolCommands(base.Commands):
pool = DesignateAdapter.parse('YAML', xpool, pool)
# TODO(graham): We should be doing a full validation, but right
# now there is quirks validating through nested objects.
for ns_record in pool.ns_records:
try:
ns_record.validate()
except exceptions.InvalidObject as e:
LOG.error(e.errors.to_list()[0]['message'])
sys.exit(1)
if dry_run:
output_msg.append("Update Pool: %s" % pool)
else:
@ -149,7 +159,12 @@ class PoolCommands(base.Commands):
except exceptions.PoolNotFound:
pool = DesignateAdapter.parse('YAML', xpool, objects.Pool())
# pool = objects.Pool.from_dict(xpool)
for ns_record in pool.ns_records:
try:
ns_record.validate()
except exceptions.InvalidObject as e:
LOG.error(e.errors.to_list()[0]['message'])
sys.exit(1)
if dry_run:
output_msg.append("Create Pool: %s" % pool)
else: