hacking 3.0.x is too old. This also removes the note about old behavior
of pip which has been changed in recent versions.
Notes:
- A few errors newly detected are also fixed.
- This also fixes the compatibility with flake8 >= 3.0 because flake8
is also bumped when we bump hacking.
- pretty_flake8 tool is removed because it's not commonly used but
needs maintenance effort to keep it in sync with newer releases
Change-Id: I8e91b06199bfbed1d6e9f8d62ddf52fafd60b7f9
This patch adds a hacking check for line continuation backslashes and fixes the occurences that existed in the code.
Change-Id: I1d1269de231f6e747248a9d816a1d64e3968c69b
tox.ini started failing with Tox4 which had some
incompatible changes. One is allowlist_externals which now needs to be
explicitly set for each testenv.
Other failure is due to the skipsdist = True.
Fixing tox.ini for tox4 changes.
Change-Id: I7ef284a07866d99cbc34b391295efbae261af7c6
Currently the code coverage check job has no minimum threshold.
Let's set a minimum bar of 83% coverage or the job will fail.
Currently we are around 85%, so this gives us some room. As coverage improves we can incrementally raise this bar.
Change-Id: I3df49281619727ad0386f0cd8f8751bf272d2147
Pip is pulling in unstrained dependencies during the "sibblings" package
install step. Normally this is fine as the dependencies have already been
installed and it's just installing the package under test. However, with
designate there are a lot of overlapping dependencies and pip will end up
reinstalling an unconstrained version. In this case it was Jinja2.
Change-Id: Ie49f99ba8e86913471ee6cd078f5afd28282c0f5
This patch adds a non-voting job that runs the Designate unit tests
with the latest release of the dnspython package.
Change-Id: Ief33213ab5cc549b7fa4babc4eabf72aaeb98b6b
Python 3 deprecated the logger.warn method, see:
https://docs.python.org/3/library/logging.html#logging.warning
so we prefer to use warning to avoid DeprecationWarning.
This patch adds a hacking check, similar to other projects, that enforces
using LOG.warning() instead of LOG.warn().
Change-Id: I424ccc14ec09dd6c7662aaee1096dfd56917aef2
To better align with other OpenStack projects and to reduce the
ongoing problem with duplicate imports, this patch re-enables the
H306 check for proper module import order.
Change-Id: Iced92590829f6d9177d64ad4868aebe6eafd6a8a
Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so will switch to the correct
upper-constraints list automatically when the requirements repository branches.
Change-Id: Iaf95ed023d5d665cb7bc885b931fd29ccffe1c9f
When running the lower-constraints test we are currently
using pip install -e . to install the source. This caused
python libraries to unintentionally getting upgraded beyond
the intended constraints.
Change-Id: Ie05efab2f52fe3e1641c9863f6f85c813158e748
The docs requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.
Change-Id: I3a6acbe9dac8bbf91a4926c806a1fabac028cda3
Tox should be smart enough to figure out the correct python version on
its own, avoid having to follow-up for every new python release.
Change-Id: If515467fd4c9e678d54d4e8551b52611fec786ff
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found.
Update local hacking checks for new flake8.
# to unbreak gate:
Depends-on: https://review.opendev.org/715835
Change-Id: Icc2f4368cc90689d74510ce36fe77d2346aec625
- Enable PDF documentation. Based on [1].
- Enable table of contents generation for pdf
- Removed literalinclude of designate.conf [2]
- Removed illegal character (a literal ESC)
- Fix incorrect column count in backends summary section
- Replace nodes.line() with nodes.paragraph()
[1] https://review.opendev.org/601659
[2] https://github.com/sphinx-doc/sphinx/issues/3099
Change-Id: Ie454f8f9ebc8e36347ce33b22f2e6da0257fe4e0
Signed-off-by: Nicolas Bock <nicolas.bock@suse.com>
The api documentation is now published on docs.openstack.org instead
of developer.openstack.org. Update all links that are changed to the
new location.
Note that redirects will be set up as well but let's point now to the
new location.
For details, see:
http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007828.html
Change-Id: Ibd4ed1a1e282f0088467a6fcafe44b1dad46ed5f
The tox environment was missing deps and thus failed, add those in.
Remove outdated comment, -W is used.
Change-Id: Ib31fcbbbd6f3f3eb6f6aed0ec0c8e03da3782189
This goal is to implement the process set out in the 2018-10-24 Python
Update Process TC resolution[1], for the Train cycle to ensure unit
testing is in place for all of the Tested Runtimes for Train[2].
In practice, this generally means adding unit tests for Python 3.7 and dropping
unit tests for Python 3.5. Using the Zuul template for Train will ensure that
all projects that support Python3 will be tested against the agreed runtime
versions, and make it easier to update them in future.
[1]https://governance.openstack.org/tc/resolutions/20181024-python-update-process.html
[2]https://governance.openstack.org/tc/reference/runtimes/train.html
Change-Id: I27ad92ae4f17e56e5879b7338db3543e5a67d8a5
Depends-On: https://review.opendev.org/#/c/641878/
Make sure that we are testing with the latest python version, too.
We should also add a functional job running with py37.
Change-Id: If6c2cd41ec39f15682ea6385ccbb5cfc8551689a
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')
Change-Id: Ia9cf4ec0b6cd5addb81dd1ff31d7e930040ddc44
Without doc/requirements.txt in the venv target you
can't create release notes by doing:
tox -e venv -- reno new <slug>
This fixes the venv target dependencies to do that.
Change-Id: Ia4b0311755fe30a79bdb529dcea4ae21efd57c8a
The following Openstack specific plugins were removed
in the 1.5.0 release on bandit and is causing the pep8
tests to fail.
* B109, B111
Change-Id: I6270decd28be26e8c497062e75b54a12f3a54517
According to Openstack summit session [1] stestr is maintained
project to which all Openstack projects should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: I0d2391779623135551f095f8f4b61a2d523c6f35