openstack
/
diskimage-builder
Code Issues Proposed changes

upgrade pip before using -c option 

The installed pip can be an older version which does not support
the -c argument. Therefore, upgrade pip before using -c.

Change-Id: If18d8ea822a62c8551c9c4d47354d58b0299fed2
Closes-Bug: 1744403
This commit is contained in:
Mark Hamzy 2018-01-19 13:08:13 -06:00
parent e9df83b2b3
commit 34ff72f253
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
diskimage_builder/elements/ironic-agent/install.d/ironic-agent-source-install/60-ironic-agent-install
View File

@ -15,6 +15,9 @@ $IPADIR/imagebuild/common/generate_upper_constraints.sh $IPADIR/upper-constraint
# create the virtual environment
virtualenv $IPADIR/venv
# pip might be an older version which does not support the -c option, therefore upgrade first
$IPADIR/venv/bin/pip install pip --upgrade
# install IPA inside the virtual environment
$IPADIR/venv/bin/pip install -c $IPADIR/upper-constraints.txt $IPADIR

8
releasenotes/notes/upgrade-pip-before-c-d2443847f9d58c7a.yaml Normal file
View File

@ -0,0 +1,8 @@
---
fixes:
- |
This fixes bug 1744403 where 60-ironic-agent-install fails to run
when DIB_INSTALLTYPE_ironic_agent=source is set. pip installs
constraints with the -c argument and this argument is a relatively
newer addion. The currently installed pip may not support that
option and must be upgraded before proceeding.