openstack
/
glance
Code Issues Proposed changes

Version negotiation api middleware to include v2.3 

Glance API is at v2.3 listed to be CURRENT version but the version
negotiation middleware lists only v2, v2.0, v2.1, v2.2.

Version negotiation middleware and related tests must include v2.3

Change-Id: I4018af408fa45f3ac0ad6e9c8229428a9f87089f
Closes-Bug: 1609571
This commit is contained in:
Nikhil Komawar 2016-08-03 18:34:32 -04:00
parent 60151c8180
commit 0d1daf44ef
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
glance/api/middleware/version_negotiation.py
View File

@ -82,6 +82,7 @@ class VersionNegotiationFilter(wsgi.Middleware):
allowed_versions['v2.0'] = 2
allowed_versions['v2.1'] = 2
allowed_versions['v2.2'] = 2
allowed_versions['v2.3'] = 2
return allowed_versions
def _match_version_string(self, subject):

7
glance/tests/unit/test_versions.py
View File

@ -268,8 +268,13 @@ class VersionNegotiationTest(base.IsolatedUnitTest):
self.middleware.process_request(request)
self.assertEqual('/v2/images', request.path_info)
def test_request_url_v2_3_unsupported(self):
def test_request_url_v2_3(self):
request = webob.Request.blank('/v2.3/images')
self.middleware.process_request(request)
self.assertEqual('/v2/images', request.path_info)
def test_request_url_v2_4_unsupported(self):
request = webob.Request.blank('/v2.4/images')
resp = self.middleware.process_request(request)
self.assertIsInstance(resp, versions.Controller)