summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorzhubx007 <zhu.boxiang@99cloud.net>2018-07-25 14:08:50 +0800
committerAkihiro Motoki <amotoki@gmail.com>2018-08-07 21:02:51 +0000
commit446abc41bfe562bcc1d2933bd42d0225c6f3cb53 (patch)
tree684a987b5d35f4b20f49db2f0c583aa16e50a9f7
parent9a66accb1c3b340886a4814ffe635a6041997b9f (diff)
add dns_name and dns_domain into admin column
https://review.openstack.org/#/c/561185/ According to the above merged commit, dns_name and dns_domain are added into project/floating_ips/tables.py. But because of the class 'FloatingIPsTable' inherits the project_tables.FloatingIPsTable, so that we should add dns_name and dns_domain into columns of Meta. If not, if you click the Admin/Network/Floating IPs, the page will crash. Closes-Bug: #1785897 Change-Id: I6e933749a56a492989cab002c1b65656b7e2c65b
Notes
Notes (review): Code-Review+2: Akihiro Motoki <amotoki@gmail.com> Workflow+1: Akihiro Motoki <amotoki@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 08 Aug 2018 00:02:27 +0000 Reviewed-on: https://review.openstack.org/585639 Project: openstack/horizon Branch: refs/heads/master
-rw-r--r--openstack_dashboard/dashboards/admin/floating_ips/tables.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/openstack_dashboard/dashboards/admin/floating_ips/tables.py b/openstack_dashboard/dashboards/admin/floating_ips/tables.py
index ae8eaf9..15e90a6 100644
--- a/openstack_dashboard/dashboards/admin/floating_ips/tables.py
+++ b/openstack_dashboard/dashboards/admin/floating_ips/tables.py
@@ -86,4 +86,5 @@ class FloatingIPsTable(project_tables.FloatingIPsTable):
86 AdminFloatingIPsFilterAction) 86 AdminFloatingIPsFilterAction)
87 row_actions = (AdminSimpleDisassociateIP, 87 row_actions = (AdminSimpleDisassociateIP,
88 AdminReleaseFloatingIP) 88 AdminReleaseFloatingIP)
89 columns = ('tenant', 'ip', 'description', 'fixed_ip', 'pool', 'status') 89 columns = ('tenant', 'ip', 'description', 'fixed_ip', 'pool',
90 'status', 'dns_name', 'dns_domain')