openstack
/
horizon
Code Issues Proposed changes

Allow @tables.bind_row_action() to bind in 2 additional scenarios 

First, it's now able to bind destructive actions rendered with
button.btn-dander. Second, now it successfully matches a single
primary action (button outside of div.btn-group container).

Change-Id: I1c55dc10b344c4899a80d83f4d18e59d5df266a6
Closes-Bug: #1537526
This commit is contained in:
Timur Sufiev 2016-01-24 21:12:23 +03:00
parent 78cbb5eec2
commit 4b83421bf5
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openstack_dashboard/test/integration_tests/regions/tables.py
View File

@ -224,15 +224,17 @@ def bind_row_action(action_name, primary=False):
a button drop-down needs to be clicked prior to clicking a button.
Defaults to `False`.
"""
# NOTE(tsufiev): button tag could be either <a> or <button> - target
# both with *. Also primary action could be single as well, do not use
# .btn-group because of that
primary_action_locator = (
by.By.CSS_SELECTOR,
'td.actions_column > .btn-group > a.btn:nth-child(1)')
by.By.CSS_SELECTOR, 'td.actions_column *.btn:nth-child(1)')
secondary_actions_opener_locator = (
by.By.CSS_SELECTOR,
'td.actions_column > .btn-group > a.btn:nth-child(2)')
'td.actions_column > .btn-group > *.btn:nth-child(2)')
secondary_actions_locator = (
by.By.CSS_SELECTOR,
'td.actions_column > .btn-group > ul.row_actions > li > a')
'td.actions_column > .btn-group > ul.row_actions > li > a, button')
def decorator(method):
@functools.wraps(method)