openstack/horizon
Code Issues Proposed changes

Check that row is defined when wait cell status

Browse Source 
Change-Id: I848b2d14138a362040abc516e32061d0b3570394
Closes-Bug: #1572036
This commit is contained in:
Sergei Chipiga 2016-04-19 12:12:04 +03:00
parent 4ec8b211f6
commit 5d8161147e
4 changed files with 7 additions and 4 deletions
openstack_dashboard/test/integration_tests/pages/project
compute
imagespage.py
volumes
volumesnapshotspage.pyvolumespage.py
network
networkspage.py

2
openstack_dashboard/test/integration_tests/pages/project/compute/imagespage.py

@ -158,7 +158,7 @@ class ImagesPage(basepage.BaseNavigationPage):
def is_image_active(self, name):
row = self._get_row_with_image_name(name)
return bool(self.images_table.wait_cell_status(
lambda: row.cells[IMAGES_TABLE_STATUS_COLUMN], 'Active'))
lambda: row and row.cells[IMAGES_TABLE_STATUS_COLUMN], 'Active'))
def wait_until_image_active(self, name):
self._wait_until(lambda x: self.is_image_active(name))

3
openstack_dashboard/test/integration_tests/pages/project/compute/volumes/volumesnapshotspage.py

@ -101,7 +101,8 @@ class VolumesnapshotsPage(basepage.BaseNavigationPage):
def is_volume_snapshot_available(self, name):
row = self._get_row_with_volume_snapshot_name(name)
return bool(self.volumesnapshots_table.wait_cell_status(
lambda: row.cells[self.SNAPSHOT_TABLE_STATUS_COLUMN], 'Available'))
lambda: row and row.cells[self.SNAPSHOT_TABLE_STATUS_COLUMN],
'Available'))
def get_volume_name(self, snapshot_name):
row = self._get_row_with_volume_snapshot_name(snapshot_name)

3
openstack_dashboard/test/integration_tests/pages/project/compute/volumes/volumespage.py

@ -145,7 +145,8 @@ class VolumesPage(basepage.BaseNavigationPage):
def is_volume_status(self, name, status):
row = self._get_row_with_volume_name(name)
return bool(self.volumes_table.wait_cell_status(
lambda: row.cells[self.VOLUMES_TABLE_STATUS_COLUMN], status))
lambda: row and row.cells[self.VOLUMES_TABLE_STATUS_COLUMN],
status))
def is_volume_deleted(self, name):
return self.volumes_table.is_row_deleted(

3
openstack_dashboard/test/integration_tests/pages/project/network/networkspage.py

@ -108,4 +108,5 @@ class NetworksPage(basepage.BaseNavigationPage):
def is_network_active(self, name):
row = self._get_row_with_network_name(name)
return bool(self.networks_table.wait_cell_status(
lambda: row.cells[self.NETWORKS_TABLE_STATUS_COLUMN], 'Active'))
lambda: row and row.cells[self.NETWORKS_TABLE_STATUS_COLUMN],
'Active'))