openstack
/
horizon
Code Issues Proposed changes

No more no-extra-parens eslint errors 

Running eslint is effectively useless nowdays because of the
overwhelming number of warnings returned.

This patch fixes the existing "no-extra-parens" errors.

I've decided to only fix those errors here to keep the patch small, and
not destroy any chance of success by needing to rebase every 5 minutes.
Other fixes will be incoming.

Change-Id: I634eafd359b14f40b89c2b30995557432cbb1b99
Partial-Bug: #1554824
This commit is contained in:
woodm1979 2016-07-22 15:49:00 -06:00
parent a8b6281215
commit 6cc5ce1fa7
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
horizon/static/framework/util/filters/filters.js
View File

@ -133,7 +133,7 @@
function noValueFilter() {
return function (input, def) {
if (input === null || angular.isUndefined(input) ||
(angular.isString(input) && '' === input.trim())) {
angular.isString(input) && '' === input.trim()) {
return def || gettext('-');
} else {
return input;
@ -208,9 +208,9 @@
function itemCountFilter() {
function ensureNonNegative(input) {
var isNumeric = (input !== null && isFinite(input));
var isNumeric = input !== null && isFinite(input);
var number = isNumeric ? Math.round(input) : 0;
return (number > 0) ? number : 0;
return number > 0 ? number : 0;
}
return function (input, totalInput) {

2
horizon/static/framework/util/validators/hz-password-match.directive.js
View File

@ -70,7 +70,7 @@
// helper function to check that password matches
function passwordCheck() {
scope.$apply(function () {
var match = (ctrl.$modelValue === pwElement.val());
var match = ctrl.$modelValue === pwElement.val();
ctrl.$setValidity('match', match);
});
}

4
horizon/static/framework/widgets/magic-search/hz-magic-search-context.directive.js
View File

@ -106,9 +106,9 @@
cancel: gettext('Cancel'),
prompt: gettext('Click here for filters.'),
remove: gettext('Remove'),
text: (scope.clientFullTextSearch
text: scope.clientFullTextSearch
? gettext('Search in current results')
: gettext('Full Text Search'))
: gettext('Full Text Search')
};
scope.filterStrings = filterStrings || defaultFilterStrings;

2
horizon/static/framework/widgets/wizard/wizard.controller.js
View File

@ -190,7 +190,7 @@
}
});
viewModel.ready = (stepReadyPromises.length === 0);
viewModel.ready = stepReadyPromises.length === 0;
return $q.all(stepReadyPromises);
}