openstack
/
horizon
Code Issues Proposed changes

Remove arguments "{}" in function definitions 

remove mutable default arguments "{}" in function definitions
refer to:http://docs.python-guide.org/en/latest/writing/gotchas/

Close-Bug: #1526140

Change-Id: Ib85bd0238beaac95c53d9ae1779a5d566db9eb16
This commit is contained in:
Bo Wang 2015-12-15 12:13:17 +08:00 committed by Matt Thompson
parent 3ab7820405
commit 7e02c996e8
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
horizon/test/tests/templatetags.py
View File

@ -43,8 +43,9 @@ class TemplateTagTests(test.TestCase):
tag_call = "{%% %s %%}" % tag_name
return self.render_template(tag_call, tag_require)
def render_template(self, template_text, tag_require='', context={}):
def render_template(self, template_text, tag_require='', context=None):
"""Render a Custom Template to string."""
context = context or {}
template = Template("{%% load %s %%} %s"
% (tag_require, template_text))
return template.render(Context(context))

3
openstack_dashboard/api/glance.py
View File

@ -316,8 +316,9 @@ def metadefs_namespace_list(request,
return namespaces, has_more_data, has_prev_data
def metadefs_namespace_full_list(request, resource_type, filters={},
def metadefs_namespace_full_list(request, resource_type, filters=None,
*args, **kwargs):
filters = filters or {}
filters['resource_types'] = [resource_type]
namespaces, has_more_data, has_prev_data = metadefs_namespace_list(
request, filters, *args, **kwargs

3
openstack_dashboard/api/rest/utils.py
View File

@ -147,7 +147,7 @@ def ajax(authenticated=True, data_required=False,
return decorator
def parse_filters_kwargs(request, client_keywords={}):
def parse_filters_kwargs(request, client_keywords=None):
"""Extract REST filter parameters from the request GET args.
Client processes some keywords separately from filters and takes
@ -156,6 +156,7 @@ def parse_filters_kwargs(request, client_keywords={}):
"""
filters = {}
kwargs = {}
client_keywords = client_keywords or {}
for param in request.GET:
if param in client_keywords:
kwargs[param] = request.GET[param]