openstack
/
horizon
Code Issues Proposed changes

Fixing test cases 

The tests in ceilometer_tests.py for fetching the meter list,
alarm list, sample list, statistic list and the resource list
are incomplete.It verifies the API call, but the API could fail
completely and an empty list would still pass the assertion.
This patch fixes it.

Change-Id: I532992a9a7ad150c83e7f18721d885721070b029
Closes-bug:#1536470
This commit is contained in:
sanjana 2016-01-21 15:45:57 +05:30
parent 87f7f69cac
commit b6b685ab98
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openstack_dashboard/test/api_tests/ceilometer_tests.py
View File

@ -34,6 +34,7 @@ class CeilometerApiTests(test.APITestCase):
ret_list = api.ceilometer.sample_list(self.request,
meter_name,
query=[])
self.assertEqual(len(samples), len(ret_list))
for c in ret_list:
self.assertIsInstance(c, api.ceilometer.Sample)
@ -45,7 +46,7 @@ class CeilometerApiTests(test.APITestCase):
self.mox.ReplayAll()
ret_list = api.ceilometer.alarm_list(self.request, query=[])
self.assertIsNotNone(ret_list)
self.assertEqual(len(alarms), len(ret_list))
for c in ret_list:
self.assertIsInstance(c, api.ceilometer.Alarm)
@ -94,6 +95,7 @@ class CeilometerApiTests(test.APITestCase):
self.mox.ReplayAll()
ret_list = api.ceilometer.meter_list(self.request, [])
self.assertEqual(len(meters), len(ret_list))
for m in ret_list:
self.assertIsInstance(m, api.ceilometer.Meter)
@ -105,6 +107,7 @@ class CeilometerApiTests(test.APITestCase):
self.mox.ReplayAll()
ret_list = api.ceilometer.resource_list(self.request, query=[])
self.assertEqual(len(resources), len(ret_list))
for r in ret_list:
self.assertIsInstance(r, api.ceilometer.Resource)
@ -122,6 +125,7 @@ class CeilometerApiTests(test.APITestCase):
meter_name,
period=None,
query=[])
self.assertEqual(len(statistics), len(ret_list))
for s in ret_list:
self.assertIsInstance(s, api.ceilometer.Statistic)