openstack
/
horizon
Code Issues Proposed changes

Fix misleading message in Update Metadata Form. 

First you put some data to Other field.
In next step you delete it.
Then you give message 'invalid key name'.
This is inconsistent to this field behavior.

DocImpact
Closes-Bug: #1371230

Change-Id: I61d3569adf89277ddec61507bd7816513e4623eb
This commit is contained in:
Marcin Karkocha 2014-10-16 12:20:07 +02:00
parent f0d8f1a729
commit c078767706
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
horizon/templates/horizon/common/_modal_form_update_metadata.html
View File

@ -51,13 +51,10 @@
</div>
</li>
<li class="list-group-item list-group-item-danger"
ng-show="!customItem.valid && customItem.focused && treeForm.customItem.$dirty">
<span ng-show="customItem.found.length > 0">
ng-show="!customItem.valid && customItem.focused && customItem.found.length > 0">
<span>
{% trans "Duplicate keys are not allowed" %}
</span>
<span ng-hide="customItem.found.length > 0">
{% trans "Invalid key name" %}
</span>
</li>
<li ng-repeat="item in available = (flatTree | filter: {$: treeFilter, visible: true, added: false})"