openstack
/
horizon
Code Issues Proposed changes

table: Show checkbox only when there is BatchAction 

Checkbox in a table assumes BatchAction.
 This commit checks whether at least one BatchAction is
 included as table actions and displays checkboxes
 only when BatchAction is available.

Change-Id: Ia1cba6c59f5d40f7df7f4b98a9f459a6934cfbb7
Closes-Bug: #1744742
This commit is contained in:
wangliangyu 2017-12-14 17:05:12 +08:00
parent 554bcfc808
commit e97623e158
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
horizon/tables/base.py
View File

@ -41,6 +41,7 @@ from horizon import conf
from horizon import exceptions
from horizon.forms import ThemableCheckboxInput
from horizon import messages
from horizon.tables.actions import BatchAction
from horizon.tables.actions import FilterAction
from horizon.tables.actions import LinkAction
from horizon.utils import html
@ -1548,6 +1549,8 @@ class DataTable(object):
template_path = self._meta.table_actions_template
table_actions_template = template.loader.get_template(template_path)
bound_actions = self.get_table_actions()
batch_actions = [action for action in bound_actions
if isinstance(action, BatchAction)]
extra_context = {"table_actions": bound_actions,
"table_actions_buttons": [],
"table_actions_menu": []}
@ -1562,7 +1565,7 @@ class DataTable(object):
if self._meta.table_actions_menu_label:
extra_context['table_actions_menu_label'] = \
self._meta.table_actions_menu_label
self.set_multiselect_column_visibility(len(bound_actions) > 0)
self.set_multiselect_column_visibility(len(batch_actions) > 0)
return table_actions_template.render(extra_context, self.request)
def render_row_actions(self, datum, row=False):