openstack
/
horizon
Code Issues Proposed changes

Remove session caching of can_access call results 

Partial revert of commit 16db58faba

Change-Id: I7b80a94117310c92f9eb83541c8d75e2bf638b90
Closes-Bug: #1450963
Closes-Bug: #1382079
This commit is contained in:
lin-hua-cheng 2015-09-15 16:19:25 -07:00
parent 16e0d7c1c3
commit fa746811e4
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
horizon/base.py
View File

@ -57,6 +57,10 @@ def _decorate_urlconf(urlpatterns, decorator, *args, **kwargs):
_decorate_urlconf(pattern.url_patterns, decorator, *args, **kwargs)
# FIXME(lhcheng): We need to find a better way to cache the result.
# Rather than storing it in the session, we could leverage the Django
# session. Currently, thTs has been causing issue with cookie backend,
# adding 1600+ in the cookie size.
def access_cached(func):
def inner(self, context):
session = context['request'].session
@ -109,7 +113,10 @@ class HorizonComponent(object):
urlpatterns = patterns('')
return urlpatterns
@access_cached
# FIXME(lhcheng): Removed the access_cached decorator for now until
# a better implementation has been figured out. This has been causing
# issue with cookie backend, adding 1600+ in the cookie size.
# @access_cached
def can_access(self, context):
"""Return whether the user has role based access to this component.