django.utils.translation.ugettext(), ugettext_lazy(), ugettext_noop(),
ungettext(), and ungettext_lazy() are deprecated in favor of the
functions that they’re aliases for: django.utils.translation.gettext(),
gettext_lazy(), gettext_noop(), ngettext(), and ngettext_lazy().
https://docs.djangoproject.com/en/4.0/releases/3.0/#id3
Change-Id: I77878f84e9d10cf6a136dada81eabf4e18676250
Sometimes value is populated with uuid of resources but that resource is not present in openstack,
So it is good to change initial_value with one of the values from choices.
Closes-Bug: #1928953
Change-Id: Ia33aaf7019d73f96c27e75ee24d80dcbf3e8ceb2
All strings are considered as unicode strings in python 3,
so we no longer need "u" prefix (u'...').
Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I796d2fcdca066475bbf29d25cbf2aa67b2b2178b
In python3, super() does not always require a class and self reference.
In other words, super() is enough for most cases.
This is much simpler and it is time to switch it to the newer style.
pylint provides a check for this.
Let's enable 'super-with-arguments' check.
NOTE: _prepare_mappings() method of FormRegion in
openstack_dashboard/test/integration_tests/regions/forms.py is refactored.
super() (without explicit class and self referece) does not work when
a subclass method calls a same method in a parent class multiple times.
It looks better to prepare a separate method to provide a common logic.
Change-Id: Id9512a14be9f20dbd5ebd63d446570c7b7c825ff
This pylint check 'no-else-return' might be debatable.
but as far as I checked it works in most cases.
Change-Id: Ie8574d4a529454c6e050fa62a7a17ea097d00240
Since we don't support Python 2 anymore, we don't need
to use python_2_unicode_compatible decorator.
Change-Id: I2aafc8d07ba95571b381ff65ba9e5c0044e2d959
We don't support Python 2 anymore so we don't need this
compatibility library.
six.reraise usages are left as is until it'll be moved to some
base lib like oslo.utils to not re-implenent this method in
Horizon.
This patch also removes Python2-specific base test case methods
assertItemsEqual and assertNotRegexpMatches in flavor of new
Python 3 analogues.
Change-Id: I0b567382edf4d68674a7b8d0b02333fb57293958
As noted in the Django 2.1 release notes [1]:
Support for Widget.render() methods without the renderer argument is
removed.
Simply add the argument.
[1] https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-in-2-1
Change-Id: I48ac79464cf10011c1b2d45556aea5b107f2fc7f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
In python 3, the ExternalUploadMeta metaclass does not preserve the
order of the fields of the class it is modifying.
First we add a __prepare__() method which returns an empty
collections.OrderedDict.
That mapping records the methods and attributes of the class it is
metaclassing as they are defined within the body of the class statement.
Then we send a collections.OrderedDict to create the new class.
Change-Id: I7223ae5bd931202c95602ec9674ae86b4708368d
Closes-Bug: #1835724
creation_counter is never used in fields.py and was deprecated in
Django 2.x. Fields of object are keeped internally as ordered
dictionary, so we don't need any additional tools to manage it
Related Django bug:
https://code.djangoproject.com/ticket/23919#comment:95
Change-Id: I530a47ad8bfed6aef63d0a678a69fa09288f123e
pycodestyle 2.5.0 introduces E117 over-indented.
This commit fixes E117 errors.
pycodestyle 2.5.0 also drops pep8.py. As a result,
horizon/test/unit/hacking/test_checks.py starts to fail.
The equivalent elements are provided by pycodestyle.py,
so we can consume pycodestyle instead of pep8 module.
Change-Id: Ib103998f42ce7c901a10669b771a898783ca1a92
horizon/forms/fields.py:
ThemableCheckboxSelectMultiple.__init__ does not have
arguments "name" and "value". They were specified before somehow.
openstack_dashboard/dashboards/project/instances/forms.py:
messages.error() does not have "redirect" argument.
We need to redirect explicitly.
Change-Id: Ib51abf136fb49e3be65005c5f48715f004379178
(In Django 2.0) The django.core.urlresolvers module is removed
in favor of its new location, django.urls.
It was depreacted in Django 1.10:
https://docs.djangoproject.com/en/2.0/releases/1.10/#id3
blueprint django2-support
Change-Id: I46ab5c325491274b8eaffbf848e5d80f83c2fd26
horizon/forms/fields.py def build_attrs
there is a string message non sense,
I think it was a comment.
Change-Id: I445fe96acd5c0dd3904dfc442f57a364e7c5bcde
Signed-off-by: peiy <peiy@rc.inesa.com>
Django 1.11+ doesn't have RenderMixin class for widgets, so we have to
implement render method for ThemableCheckboxSelectMultiple to get it
rendered in a correct way with all supported Django versions until we
find a better solution for our widgets implementation.
Change-Id: I656afb162e130f2b77853368945b74330bedf747
Closes-Bug: #1715066
Required for Django 1.11 compatibility. Apparently
DynamicSelectWidget.render() receives it (through kwargs) and
tries to pass the parameter to its parent's method, but then
it fails (leading to exceptions in the rendering).
Closes-Bug: #1707660
Change-Id: I25e294a1c2f721a2f57dd50acb4c5e408b6187f9
Mostly the issue with Horizon was we were using some
undocumented widgets that were cut for version 1.11
django. This patch adds their code into our repo for
now, but we need to do a proper rewrite of our widgets
for Queens to use current widgets in Django.
Also edits some tests because the functionality changed
in Django 1.11
Implements: blueprint dj111
Co-Authored-By: Rob Cresswell <robert.cresswell@outlook.com>
Change-Id: I444d45f274662f4f33701c16cce4ae80cb546654
Previously template.render() takes Context or RequestContext object
but after Django 1.8 the method takes a dict and request as separate
arguments. The old way will be dropped in Django 1.10.
This commit update the usage based on the Django 1.8 release notes [1].
commit 95d78a140f addresses this
deprecations but it turns out all similar places are not switched.
I searched the code base more carefully and found more.
I hope this clean up all of them.
After this change, extra_context which was passed to (Request)Context
previously is no longer available in HttpResponse object.
Volume unit test is tightly coupled with the context information
and checks rendered actions using the context. Thus the corresponding
tests no longer work. Since we can use only HttpResponse.content
(which is a rendered HTML), the new tests just check various strings
like ID, link and label of a specific action.
This is tricky, but this is now the only thing we can do.
[1] https://docs.djangoproject.com/en/1.8/ref/templates/upgrading/#get-template-and-select-template
Change-Id: I350c22dc3d7db7b93ca4b823dac1e3d88beef1a7
Plus refactor Allowed Address Pairs form to use it.
The new input field is introduced because a follow-up patch wants to use
MAC address input fields at multiple places and this seems more reusable
than a CharField with regex validation. This is also a bit more generic,
because it accepts multiple MAC address formats (all formats supported
by netaddr). Then normalize the MAC address to the most usual format.
Change-Id: Ie2cbfdfbfb46a50d71d325e42f7d614710c6df3b
Partially-Implements: blueprint neutron-trunk-ui
attribute-level imports are not checked by hacking module now.
most noqa is used to disable warnings on attribute-level imports.
This commit drops noqa for this purpose.
After this, there are 8 noqa under horizon/ :)
In addition to this, the following changes are made.
horizon/exceptions.py: The following imports are dropped.
They are not used anywhere.
from django.http import HttpRequest
from django.views.debug import CLEANSED_SUBSTITUTE
horizon/forms/__init__.py:
Some entries were missing in __all__. They are added.
Change-Id: I33b504ef6c396f0675e8a340867e2ca59c77c684
Since large Glance images even temporarily stored on dashboard side
tend to fill up Web Server filesystem, it is desirable to route image
payload directly to Glance service (which usually streams it to
storage backend, which in turn has plenty of space).
To make it possible we need to trick Django into thinking that a file
was selected inside FileInput, while its contents are not actually
transferred to Django server. Then, once image is created client-side
code needs to know the exact url the image payload needs to be
transferred to. Both tasks are solved via using ExternalFileField /
ExternalUploadMeta classes which allow to work around the usual Django
form processing workflow with minimal changes to CreateImage form
business logic.
The client-side code relies on CORS being enabled for Glance service
(otherwise browser would forbid the PUT request to a location
different from the one form content came from). In a Devstack setup
you'll need to edit [cors] section of glance-api.conf file, setting
`allowed_origin` setting to the full hostname of the web server (say,
http://<HOST_IP>/dashboard) and restart glance-api process.
A progress bar is implemented to track the progress of a file upload,
in case a really huge image is transferred.
The new machinery could be easily switched on/off with a single
setting `HORIZON_IMAGES_UPLOAD_MODE` set to 'direct' / 'legacy'.
Related-Bug: #1467890
Closes-Bug: #1403129
Implements blueprint: horizon-glance-large-image-upload
Change-Id: I01d02f75268186b43066df6fd966aa01c08e01d7
The DynamicTypedChoiceField is now a themable select. Floating
ips have been updated to use it.
Change-Id: I41e25f86cb0eaa6d0aadd18a5dc953b047c1581d
Partially-implements: blueprint horizon-theme-css-reorg
Horizon was using a standard select input. Unfortunately, this type
of input is only customizable to a small extent.
Co-Authored-By: Ryan Peters <rjpeter2@gmail.com>
Co-Authored-By: Matthew Wood <woodm1979@gmail.com>
Co-Authored-By: Brian Tully <brian.tully@hp.com>
Change-Id: Iaf8427c3fff6d2fbfae944731fd9f6f754ed7c31
Partially-implements: blueprint horizon-theme-css-reorg
Horizon was using a standard select input. Unfortunately, this
type of input is only customizable to a small extent.
I/We have created a new input type for forms to use that is a bootstrap
dropdown. This will allow bootstrap themes to affect selects the same
way they do for check boxes and radio buttons and the like.
Material's inputs are a bit special, so custom css was added to keep
style parity with Bootswatch's Paper.
co-authored-by: brian.tully@hp.com
co-authored-by: hurgleburgler@gmail.com
ThemableSelect widget template has been modified so that shadow select
element does not contain any classes (which are usually used for
customizing appearance - since it's hidden, it doesn't need
that). Given that we could match legacy select element as 'div >
select.form-control' with no possibility that SelectFormFieldRegion
(legacy select widget region) will bind a hidden part of
ThemableSelect widget and intercept all commands send to
ThemableSelectFormFieldRegion. ThemableSelectFormFieldRegion was
modified to still use legacy widget wrapper for getting 'name' and
'value' properties, while doing all other things on its own, not using
Selenium wrapper for <select>.
Co-Authored-By: Timur Sufiev <tsufiev@mirantis.com>
Change-Id: Ie921b3adc2e1d3388d3c2aa1f76afe3af6ceb87b
Partially-implements: blueprint horizon-theme-css-reorg
Horizon checkboxes were using a standard checkbox. Unfortunately,
this type of checkbox is only customizable through Chrome, and
even then, its not completely flexible.
The default checkboxes have now been altered to allow for a highly
customized experience through the use of CSS pseudo elements and
Icon Fonts. This allows the color, size and unselected and selected
states of the checkbox to be customized.
The 'default' theme uses the standard Font Awesome checked and
unchecked icons. The 'material' now uses the Material Design
checkbox design.
It was also noticed (and fixed) that the help-icon on the forms
were not the same color as its corresponding text.
Partially-Implements: blueprint horizon-theme-css-reorg
Change-Id: I52602357d831a5e978fe6916b37b0cde9edb2b9b
This feature enables user to customize choices in a drop down
list of a form by adding additional properties to the 'choices'
attribute of ChoiceField class.
Currently, the ChoiceField class has an attribute choices which
takes a list of 2 element tuple by default.
self.field[<field name>].choices = ([
(option_value1, option_label1),
(option_value2, option_label2)
])
With this implementation,users can specify an additional transform
function in the forms.fields.SelectWidget class called
transform_html_attrs. Given the option label for a given choice,
transform_html_attrs will return a dictionary containing the html
attributes and their values
Implements: blueprint add-attributes-to-form-field-choices
Change-Id: I8ba997c58b485a33676cf9f350be00a1f365256f
Django changed the name to force_unicode and it's only available in
python2 as an alias of force_text. The new name is available since
Django 1.4.2
Closes-Bug: #1345642
Change-Id: Ida8c545ceec7c31999f2497d540a0dc5a653d286
There's several places in the code where this type of thing exists:
form_data.update({'vpnservice_id': vpnservice.id})
better would be this:
form_data['vpnservice_id'] = vpnservice.id
This type of thing bothers me, so I'm going to clean it up.
Also fixed the two cases of:
if <some_string>.find(<some_other_string>) != -1:
which should clearly use the "in" operator instead.
Change-Id: Ic72a5b0a17c211f3949edc69732c1101c24590ec
Closes-Bug: 1339849
Remove vim setting:
comment - # vim: tabstop=4 shiftwidth=4 softtabstop=4
at the top of source code files, except for files in
openstack/common.
Change-Id: I9a5c6b17c6ef7ecec601f4503dfc7b31fc72e90a
Close-bug: #1229324
Do not wrap self.add_item_link_args in an additional list because it
makes impossible to pass more than one arg (i.e. tuple or list of
args) to url resolver.
Change-Id: Idf6d5d1f27c9176f1de93a475e0f1abbae5ee275
Closes-Bug: #1297317
According to the Django architecture, all fields are grouped in
the django.form module, Horizon fields were dispatched in two modules
utils and form. This patch cleanup the loading of Horizon specific
fields.
Change-Id: Ib18848a8cc06dbd5984ec02d7cd647145124ced4
Closes-Bug: #1287634
In an effort to help horizon more friendly to OpenStack hacking
guidelines, we now gate on H40* violations.
Change-Id: Id07294543660368d2f7f5ac363710176ab23b874
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
This patch also re-organizes imports to import one per line.
Change-Id: Ia958e3a30a48d4308d08d51df243c1272425c316
Fixes: bug 1188529
Fixes: bug 1188537
* Update Project workflow now includes a tab to update project members
* Can add/remove existing users from project and update roles
* Can add a new user via inline object creation
* Can filter both lists!
* Changed css/jquery to make things appear more like other tables
* Fixed a few JS bugs
* "Fixed" exception handling for now, although it naively redirects the
user out of the workflow
partially implements blueprint tenant-creation-workflow
Change-Id: I38589bf3ee4c33c49df982417d995c141f4e6709
Allows the creation of related objects during a workflow.
For example, this patch implements importing keypairs during
the launch instance workflow and allocating floating IP
addresses during the floating IP associate workflow.
This required several significant changes:
* SelfHandlingForm should no long return a redirect.
Instead, it should return either the object it
created/acted on, or else a boolean such as True.
* The ModalFormView now differentiates between GET
and POST.
* Due to the previous two items, SelfHandlingForm
was mostly gutted (no more maybe_handle, etc.).
* Modals now operate via a "stack" where only the
top modal is visible at any given time and closing
one causes the next one to become visible.
In the process of these large changes there was a large
amount of general code cleanup, especially in the javascript
code and the existing SelfHandlingForm subclasses/ModalFormView
subclasses. Many small bugs were fixed along with the cleanup.
Implements blueprint inline-object-creation.
Fixes bug 994677.
Fixes bug 1025977.
Fixes bug 1027342.
Fixes bug 1025919.
Change-Id: I1808b34cbf6f813eaedf767a6364e815c0c5e969
Akihiro Motoki