Commit Graph

8 Commits

Author SHA1 Message Date
Akihiro Motoki cd7c1b5110 Address RemovedInDjango40Warning (2)
django.utils.translation.ugettext(), ugettext_lazy(), ugettext_noop(),
ungettext(), and ungettext_lazy() are deprecated in favor of the
functions that they’re aliases for: django.utils.translation.gettext(),
gettext_lazy(), gettext_noop(), ngettext(), and ngettext_lazy().

https://docs.djangoproject.com/en/4.0/releases/3.0/#id3

Change-Id: I77878f84e9d10cf6a136dada81eabf4e18676250
2022-02-04 16:22:07 +09:00
Akihiro Motoki e5d09edc20 Use python3-style super()
In python3, super() does not always require a class and self reference.
In other words, super() is enough for most cases.
This is much simpler and it is time to switch it to the newer style.

pylint provides a check for this.
Let's enable 'super-with-arguments' check.

NOTE: _prepare_mappings() method of FormRegion in
openstack_dashboard/test/integration_tests/regions/forms.py is refactored.
super() (without explicit class and self referece) does not work when
a subclass method calls a same method in a parent class multiple times.
It looks better to prepare a separate method to provide a common logic.

Change-Id: Id9512a14be9f20dbd5ebd63d446570c7b7c825ff
2020-10-15 14:37:20 +09:00
pengyuesheng 35b20d0a18 Correct error messages of Create Extra Spec Form under Volume Type Panel
When there is more than one Extra Specs in Volume Type Extra Specs,
then create an Extra spec with an invalid key name like "#^&*",
the form prompts a wrong error message.
This patch corrects the error message.

Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b
Closes-Bug: #1822924
2019-04-11 11:25:59 +08:00
manchandavishal a85687cb7e Add Validation msg in Create Extra Spec Form under Volume Type Panel
This patch add a validation message when a user try to 'Create'
a extra spec with an existing key name under Volume Type panel.

Change-Id: I6a1eac269e616ba0861a41eda5eac1b1a4cdd1d0
Closes-Bug: #1818826
2019-03-19 12:44:47 +00:00
Akihiro Motoki 4a67f7d79c Correct regular expression of volume type extra spec key
The "-" in the regex group has to be the first or the last character,
otherwise it counts as a range.

This is a follow-up patch of https://review.openstack.org/#/c/632204/

Change-Id: I08f80410540cb73f74837fe3ac83bd16f1ae7978
2019-01-31 14:10:19 +09:00
pengyuesheng 59cfc3fc3b Input limit on key name
server has checked the input parameters,
Key names can only contain alphanumeric characters,
underscores, periods, colons and hyphens

Change-Id: Ie49b5cfbb10c7c2234c88f89ad7d491d026eef9e
2019-01-25 10:02:01 +08:00
Akihiro Motoki e477eafa45 django2: Replace django.core.urlresolves with django.urls
(In Django 2.0) The django.core.urlresolvers module is removed
in favor of its new location, django.urls.
It was depreacted in Django 1.10:
https://docs.djangoproject.com/en/2.0/releases/1.10/#id3

blueprint django2-support
Change-Id: I46ab5c325491274b8eaffbf848e5d80f83c2fd26
2018-02-17 01:36:48 +09:00
Richard Jones a22bba4af9 Move Volume Types out of tabbed panel
Change-Id: Ie8ddc78a6638e02b673582b081a67f05ec0a2a0a
Implements: blueprint reorganise-volumes
2017-03-09 14:30:56 +11:00