Commit Graph

14 Commits

Author SHA1 Message Date
Zhenguo Niu 3d25f1d595 Move volume snapshots table to volumes panel
Now that instance snapshots are just images, the images & snapshots
page only has images and volume snapshots. This is an odd combination.
I think we should now move volume snapshots to the volumes panel,
since a volume snapshot is tied to a volume.

Closes-Bug: #1190843
Change-Id: I3e12cec8b859a30db9f131e9889a92277e064086
2014-02-18 10:24:18 +08:00
Radomir Dopieralski 028332da4a Remove #noqa from most common imports and add them to import_exceptions
We have a lot of import with #noqa that is there to ignore h302,
because it's traditional to import and use a name directly, instead
of a whole module. This hides other errors and gives people the
impression that it's actually fine to import non-modules, you just
have to slap #noqa on those lines.

I went through the code and identified about a dozen names that are
most commonly imported this way. I remove the #noqa tag from them,
and added them to the list in import_exceptions.

I also removed a few unused imports that were revealed in the process.

Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
2014-01-07 12:26:35 +01:00
Zhenguo Niu 04494e8678 Allowing snapshoting attached volume
The cinder api allows calling snapshot on attached volumes,
we should enable it on horizon.

Change-Id: I33d7bbca0bf993ace7c243867aa5f57438a57a5d
Fixes: bug #1202929
2014-01-06 11:15:25 +08:00
Abhijeet Malawade 3686360878 Standardize display name on detail pages
* Standardized overview pages for volume, image and snapshot
as per the instance overview page.

Fixes bug #1207770

Change-Id: I7ae48542f4c8732c92dc4393dbaaea81158d34d6
2013-10-16 02:18:29 -07:00
Kieran Spear f4d56fb134 Fix excessive volume_get requests in snaps table
The volume snapshots table has a column that shows the associated volume
name and links to its volume detail page. This calls volume_get twice
for each snapshot, so loading the Images & Snapshots page takes forever
if you have a decent number of snapshots.

This commit instead gets the volume list at the same time as the
volume snapshot list, and stores the volume as an attribute on
the snapshot so it can be easily retrieved later.

Closes-bug: 1218259
Change-Id: I004e50aae51a6ed7549da41967bc42babfa6cb45
2013-09-25 15:36:15 +10:00
Julie Pichon 2ed62bb2e5 Fix volume snapshot creation
The referenced template was wrong, and the quota usages information
had not been switched to using limits.

Thanks to Nuno Santos and Rohan Kanade for the initial versions of
this patch.

Change-Id: I97f578b84cd1cd4babab2580c60f0132026e3c93
Closes-Bug: #1194506
2013-09-18 18:19:19 +01:00
Tatiana Mazur 953d1b9793 Enable H302 check
This patch replaces some method imports with module imports and
makes H302 test enabled.

Fixes bug 1188531

Change-Id: Ibfbddeaa19cbbb244da58ffd5c918c41f03a0c65
2013-08-22 17:39:09 +04:00
Matthias Runge cea720e793 Sort imports alphabetically
This patch also re-organizes imports to import one per line.

Change-Id: Ia958e3a30a48d4308d08d51df243c1272425c316
Fixes: bug 1188529
Fixes: bug 1188537
2013-06-14 12:05:55 +02:00
Jiri Tomasek 8a0b4c7e47 Mix snapshots and images tables together
Don't filter snapshots from images data, display image_type column in images table,
don't translate image string in get_image_type method, don't show LaunchImage button when
image is in different state than active, remove snapshots table from the UI, update tests

Fixes: bug #1140760

Change-Id: Ie6cc5bc98fa97de00b55540fe9f60e90d20acab3
2013-06-07 15:27:05 +02:00
Jan Provaznik ea1edcb027 Enable snapshot quota setting
Change-Id: Ie8bcd2d2fddf717a29328bc802a2fda80198183b
Fixes: bug #1177249
2013-05-27 14:22:38 +02:00
Akihiro MOTOKI 12faaa5c30 Ensure to use api.<category>.<method>
In the current code both api.<method> and api.<category>.<method> are used.
Using api.<method> directly makes it difficult to identify which module
defined a method and forces developers to use unique method names among
projects. This commit removes api.<method> style method calls.

Change-Id: Iaefa1061f99b7865e02541df87c112a6b2868ec0
2013-01-22 20:37:12 +09:00
Tihomir Trifonov e837b105e8 Changed "Delete volume" success message text
As deletion of volume/snapshot is performed
asynchronous, the success label should not be
'Deleted', but 'Scheduled for deletion', as it
is for Instances ('Scheduled for termination').

Fixes bug 1073718

Change-Id: Ia7884b5b82fea225cfc559309346e73683c4cb3e
2012-11-08 17:32:25 +02:00
Tihomir Trifonov 057d891f31 Added support for volume types
As cinder already supports volume types, it's time
to be added in Horizon. The types are added in admin panel.
A volume can either have a *valid* type, or None.

There are two minor issues:
1. When a type is deleted, if there is a volume with
   this type, the type is returned as the id,
   instead of the name. Which is good as consistency,
   but maybe a type should not be deleted if used by a volume?
2. If no vol type is passed(None) value, the type is being
   assigned as 'None', and returned as a string('None')
3. In the create volume type form, the 'Description' is
   empty at the moment, I couldn't find any help info
   to add for volume types...

Implements blueprint volume-types

Tested with n-cinder and n-vol services. Since Folsom both
support volume-types. I'm not sure if it is possible a grizzly
Dashboard to work with essex nova, which could be a problem.
Dashboard doesn't seem to provide permissions based on tables,
so if it needs to check if a service is available to show/hide
volume types, this will need some more effors to implement
permissions on table/action level. Or maybe this needs to be
added as a standalone panel?

Patch set 2: implemented suggestions, added one more thing:
When creating a volume from a snapshot, set the volume type
initial as the type of the original volume from which
the snapshot is being created.

Patch Set 3: Updated the description of volume types,
based on the notes from:
https://etherpad.openstack.org/grizzly-cinder-volumetypes
https://etherpad.openstack.org/cinder-usecases
Any feedback on the description is welcome.

Change-Id: Ib0c136c5c8cd9fbd34ce1dd346260f404c96f667
2012-10-25 15:35:36 +03:00
Gabriel Hurley cb8e7c1f8f Splits OpenStack Dashboard bits from framework app code.
Moves everything OpenStack-specific (dashboards, apis, etc.)
into the openstack_dashboard project, achieving a much
cleaner separation between the project-specific code and
the generic Horizon framework code.

Change-Id: I7235b41d449b26c980668fc3eb4360b24508717b
2012-10-11 11:47:50 -07:00