Extracted openLaunchInstanceWizard from the
LaunchInstanceModalController to a Service named
horizon.dashboard.project.workflow.launch-instance.modal.service
This service is required for the new Images panel
to create the launch instance modal pop up.
Partially-Implements: blueprint angularize-images-table
Change-Id: Id7177cbafbfb9094d03908b5f8eba52d00241817
Following John Papa's style guide
https://github.com/johnpapa/angular-styleguide,
this patch refactors the Angular code for Launch Instance wizard.
Note that the construction of the Launch Instance wizard precludes
applying JP's "controller as" rule to the top level wizard controller
itself; doing so breaks the *many* implicit parent accesses throughout
the wizard sub controllers (implicit parent scope accesses are not
possible using the "controller as" style). Fixing that is potentially
a flow-on tech-debt fix that is outside of the scope of this
patch - it'll be a bunch of work!
I also noticed a trivial bugfix while addressing this. It could be
broken out into a separate patch, but we have enough patches already ;)
Change-Id: Ie6a1fdca1da60259adbb65c36a9829b001ae752b
Partially-Implements: blueprint jscs-cleanup
Closes-Bug: 1481135
This patch relocates the 'launch-instance' directory.
Continuing re-organization of the Launch Instance angular code
to move it into the correct place for plugins, namely
openstack_dashboard/dashboards/project/
This patch attempts to divide https://review.openstack.org/#/c/191592
into smaller, more easily reviewable pieces.
Co-Authored-By: Shaoquan Chen <sean.chen2@hp.com>
Co-Authored-By: Tyr Johanson <tyr@hp.com>
Change-Id: I426c77d704ed9114ce9ae148b5fdec4e381f0f68
Partial-Bug: 1478717
Rajat Vig