This introduces a new config option `DEFAULT_BOOT_SOURCE` to allow
operators to configure a default instance boot source.
Change-Id: Ia9b0d1d24ae69958b6606b9a645bd54f70b3aacc
Implements: blueprint default-instance-boot-source
The most elegant way to add pagination is to refactor the table using
<hz-dynamic-table> which already contains pagination instead of wiring
it to the existing table framework.
This solution adds the pagination and makes the code more readable.
Partial-Bug: #1859423
Change-Id: I08b7b94cf214a6b086565c2dd429e460e4e5c3de
Problem description
===================
In the launch instance workflow while creating a virtual machine, when
I select the Source tab, most of the time the default boot-source is
`Image` and everything works just fine. However, some times, the default
boot-source comes as Volume, due to some race condition (tested and
reproduced in Chrome 77). In this case, the Available items table is
empty, even if there are bootable volumes to be attached to the VM. This
problem happens because the initial state of boot-sources is setting
only the `displayedAvailable` of the Image source (that is the "default
source"), instead of setting all the initial `displayedAvailable`
elements.
Proposal
========
The proposal is basically to set up the `displayedAvailable` in
all boot-sources.
Closes-Bug: #1848334
Change-Id: I1c9399bf3f6c859206c093452c2e637892aa9722
This commit updates several places where image information is processed
and extends support for the 'community' image visibility value.
Some support did exist already, which was mostly just the main Images
tab of the dashboard, but this commit also includes support for:
- image name in the instances list/details
- 'Community' visibility label in the Images tab
- Listing of community images in launch instance wizard
Closes-Bug: #1779250
Change-Id: Iedea0b7d20313837a72a2759511251a7bb324869
When launching instance from snapshot, volume or volume snapshot,
the selected boot source was always image.
This was due to a reset to image boot source when receiving "change allowed boot
sources" event.
From now:
- The "change allowed boot source" event does not flush a preselection
if the preselection boot source type is in the allowed sources.
- Set the bootsource with preselection update correctly the form for each
different type of boot source.
Change-Id: I6907652731fa89b303d997fe2e3c331a68f085b6
Closes-bug: #1608565
This fixes an issue introduced by watchers:
when page initialized images watchers called before
select boot source watcher.it leads to sutiation when
we specify selection from user input and flush it on
updateBootSource. as a result page come to
inconsistent state described in the bug.
Perhaps, this requires big refactoring but in the
current patch we do not flush selection if boot type
was not changed. it allows to use image, snapshot,
volume from context as ctrl.selection.
Change-Id: I4b23071a2a9e2c02cc1f46713165e5cb5155894f
Closes-Bug: #1710890
This patch adds the ability to configure the default "create volume"
value when launching an instance with Cinder enabled.
Co-Authored-By: Rob Cresswell <robert.cresswell@outlook.com>
Closes-Bug: 1678109
Change-Id: I272f7f1b20cc1276976c464a82d1776de92d17e7
On the Angular launch instance modal, the volume size for the new
instance does not take the disk size required by the selected flavor
into consideration, which is inconsistent with the Django launch
instance modal.
This patch will set the volume size of the new instance to the
minimum disk size required by the selected flavor.
Change-Id: Ifb35b70c5b41820024e17da783687bfe7880b8e8
Closes-bug: #1676648
In images tab, when launching an instance snapshot,
the images is not selected by default in the source
tab of the launch instance wizard.
Change-Id: I9c1bcdd4e22ebf7034146c14a43d8a405ae2a8be
Closes-Bug: #1644882
A previous patch altered the defaults in the angular Launch Instance,
but didn't account for those running without Cinder. This patch fixes
those assumptions.
Co-Authored-By: Rob Cresswell <robert.cresswell@outlook.com>
Change-Id: I8dc54fa40fa7eb8ae95a13741405f2a80337b33d
Closes-Bug: 1585761
Adds new configs to LAUNCH_INSTANCE_DEFAULTS to configure
which sources are available when launching an instance.
Provides an info message if no boot sources are enabled.
Prevents doing extra calls if a boot source is disabled.
Adds tests to check for the proper filling of allowedBootSources.
Removes one test as the object being checked no longer exists.
Co-Authored-By: Brad Pokorny <brad_pokorny@symantec.com>
Co-Authored-By: Yosef Hoffman <yh128t@att.com>
Change-Id: I90f76c34dbfb20cb54d5f3e599052388bd0dba39
Implements: blueprint configurable-boot-sources
This makes is easier to listen for the appropriate Magic Search
events in other parts of Horizon, or from plugins to Horizon.
Change-Id: I5a551bf44139dab07a7ca111fc195dc23079f7d6
The code for updating the Volume Size error in the Launch Instance
source step appears to be incorrect. This patch updates and improves the
handling to also bump the current value to the minimum for the chosen
image (rather than just a form field error). Also changed the default to
create a new volume, as it was advised that this is the more common
workflow.
Change-Id: Iecb679d967b2285776278f23018e4151ebb18df2
Closes-Bug: 1568866
Just as with https://review.openstack.org/#/c/219925/ , right now on
the Volume Snapshots table, if you click on Launch as Instance you
get the legacy launch instance wizard even if local_settings is
configured for LAUNCH_INSTANCE_LEGACY_ENABLED = False.
This needs to recompile the Angular context due to the way Django
creates tab content.
Change-Id: Ibf027d523751cd4808591b8b24d8bb26c6351f5a
Fixes-Bug: 1543891
Adds a new step to the new instance launch
with the available ports.
The operator can add or remove ports to be
attached to the instance on boot.
This allows the operator to use ports
at launch instead or together with a network.
Adds tests and modifies other tests to take
into account the new number of steps and the
new addition to the model.
Change-Id: I29fdce433a5a8a9e3ebedbd1a1d96399890e4c6c
Implements: blueprint allow-launching-ports
In the Angular Launch Instance Wizard, when you change the
the boot source, the Available items count does not update
correctly. Example: Boot Source is set to Image by default and
the Available items Count is correct. Change the boot source.
The count does not update. Also, when you change back to
Image, the previously allocated item no longer exists.
Also fix tiny typo.
Change-Id: I647b31c7a280af4e10040fb27b4436d489fd8163
Closes-Bug: #1489618
The launch as instance option for Volumes launches the legacy
launch instance wizard even if local_settings is configured
for LAUNCH_INSTANCE_LEGACY_ENABLED = False. This Fix addresses
the issue.
Volume snapshots will be a separate patch.
Horizon tables.js has a separate bug that needs to be fixed:
https://bugs.launchpad.net/horizon/+bug/1514627
Change-Id: Id4a7dc2a48c63cbe27ece4dba1825eb89b7a0388
Closes-bug: #1491645
Co-Authored-By: Travis Tripp <travis.tripp@hpe.com>
Currently implemented in the "Select Source", Network and
"Select Flavor" step in the Launch Instane workflow.
Co-Authored-By: Rajat Vig<rajatv@thoughtworks.com>
Change-Id: I5e195bfcf7fe3367576089b23cc08b40c2c36b09
Partial-Bug: #1434710
This updates the angular Launch Instance wizard so the source tables
correctly display DOCKER as the type when the disk format is raw and
the container format is docker.
Closes-Bug: #1489562
Change-Id: Id8c93376237bd37efded1d6f9d0c036d8a5b1144
"Delete" is being used almost everywhere in OpenStack Dashboard
except the instance panel. Using "Delete" looks more consistent.
In addition, "Delete" tells non-native English speakers that
deleted instances will be no longer usable again compared to
"Terminate".
DocImpact
Closes-Bug: #1502773
Change-Id: Idccaf3c45566f20f11d02ada64c1d3934a6f3002
Per user feedback, the existing wizard step, Select Source,
is being split into two steps - Instance Details and Select Source.
Partial-Implements: blueprint launch-instance
Change-Id: I3bf2c6dc8baea782416e608965459cce0aee69f6
Co-Authored-By: Coleman Beasley <cbeasley@thoughtworks.com>
Co-Authored-By: Kyle Olivo<keolivo@thoughtworks.com>
Co-Authored-By: Errol Pais<epais@thoughtworks.com>
Co-Authored-By: Matt Borland <matt.borland@hpe.com>
Per the JP style guide, implements getter syntax rather than declaring a
variable for the module, and implements DI for the service as well.
This also fixes the indent related issues caused by the new eslint
rules.
Change-Id: I8d9404d56c0c38debe97a99d8282d1d5b559302d
Co-Authored-By: Valerie Roske<varoske@thoughtworks.com>
Partially-Implements: blueprint jscs-cleanup
We should clean out old gettext and move them into HTML files.
This bug addresses the move to launch-instance source step.
Change-Id: Ib7dd0880949e980994464aa18cc3a2e8f224fe58
Partial-Bug: #1487582
This patch relocates the 'launch-instance' directory.
Continuing re-organization of the Launch Instance angular code
to move it into the correct place for plugins, namely
openstack_dashboard/dashboards/project/
This patch attempts to divide https://review.openstack.org/#/c/191592
into smaller, more easily reviewable pieces.
Co-Authored-By: Shaoquan Chen <sean.chen2@hp.com>
Co-Authored-By: Tyr Johanson <tyr@hp.com>
Change-Id: I426c77d704ed9114ce9ae148b5fdec4e381f0f68
Partial-Bug: 1478717
Zuul