These are detected as errors since the clean up was done[1] in
the requirements repository.
[1] 314734e938f107cbd5ebcc7af4d9167c11347406
Also remove the note about old pip's behavior because the resolver
in recent pip no longer requires specific order.
Change-Id: Ie2f08726cfc764643a50777c552f95413eb67305
The lower-constraints test was removed because of an issue where pip
could not correctly determine the required packages versions to install,
ending in an almost infinite loop that would end up in timeout, failure,
and general mayhem.
Recently the issue has been fixed and, if properly configured, the
lower-constraints test can provide good indication of which minimum
versions are required to support the current code.
This patch adds the test back to the current development branch, and it
runs only on master.
The lower-constraints file will stay in the future stable branches.
Fix olso.utils min requirement and remove doc8 from test-requirements
as it's already included in tox.ini config.
Change-Id: Ic0174f59b95a878539ab17f659f1663548e94ed7
To be able to use the same JSON RPC implementation for ironic-inspector,
it is now imported in ironic-lib. Some additional abstraction laters are
added to avoid hard dependency on oslo.context and oslo.messaging.
Change-Id: I0e790cebcd086d26bf27b909f73842c3f46bbd77
This code is used by both ironic and ironic-inspector with barely
any difference and will be required to import the JSON RPC code.
To prevent IPA from depending on keystoneauth, the new requirement
is added as a new extra feature "keystone".
Change-Id: I8bc08ec9e081a67d1687033413fee63698e14e69
Remove pep8 dependencies from test-requirements, they're not
needed there and are hard to constraint properly.
Change lower-constraints to make pip resolver happy.
Add bindep.txt to provide dev libraries to build python modules.
Change-Id: I4edc2ebc7b29849901964279b5cc551944d830a9
Versions of hacking from 3.1.0 until 4.0.0 NOT included are supposed
to require a safe version of flake8, so besides normale issues related
to minor version upgrades, we can safely use those versions.
Also forcing pycodestyle versions to be compatible with flake8 installed
by hacking.
Change-Id: I4612e84ee88c21121d97e31c9ab22d776f4fb5bc
flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.
Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.
To avoid similar gate break in future, we need to bump the hacking min
version.
- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html
Change-Id: Ib39f593616e2933ca5c1dbfa231691d6ced60e6c
* Remove testscenarios, it's an ancient artefact
* Replace the only usage of testtools with a simple check
* Split out doc/requirements.txt
* Clean tox.ini of unnecessary (and probably cargo-culted) stuff
* Added Pygments for syntax highlighting check
Change-Id: I9f6b03606973e1e8123165c46bef53c4ce8e2b92
Full py3 compatible version.
Add all Python3 modules to stdlib list.
Also includes fix to an enum34 dependency bug.
Change-Id: Ib518f6f110a52e891fb1952262e4456181d3d712
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
Change-Id: I94daf175305b5fd31380088e27ecec2083f89e59
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Make a few cleanups:
- Remove python 2.7 stanza from setup.py
- Add requires on python >= 3.6 to setup.cfg so that pypi and pip
know about the requirement
- Remove obsolete sections from setup.cfg
- Update classifiers
- Update requirements, no need for python_version anymore
- Switch to apidoc instead of autodoc for API docs, use sphinx-build.
Change-Id: Ie6107bc80961a7306957b17ac2eda44417b53d3e
The new version enables a lot of standard flake8 checks, so a few
fixes are required. W503 is disabled as it conflicts with W504
and the latter seems to be preferred nowadays.
Change-Id: I929ff36eaa47a42bc551f5c37bd40f64bc4f14d0
According to Openstack summit session [1] stestr is maintained project
to which all Openstack projects should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: Ibb1e23aceeb9a864306c52b410bda77736454ef0
Signed-off-by: Chuck Short <chucks@redhat.com>
hacking is not capped in g-r and it is in
blacklist for requirement as hacking new version
can break the gate jobs.
Hacking can break gate jobs because of various
reasons:
- There might be new rule addition in hacking
- Some rules becomes default from non-default
- Updates in pycodestyle etc
That was the main reason it was not added in g-r
auto sync also. Most of the project maintained the
compatible and cap the hacking version in
test-requirements.txt and update to new version when
project is ready. Bumping new version might need code
fix also on project side depends on what new in that
version.
If project does not have cap the hacking version then,
there is possibility of gate failure whenever new hacking
version is released by QA team.
Example of such failure in recent release of hacking 1.1.0
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html
Change-Id: I2cdc79ed0cd302990a0434c477d6f3ec2c05fb8b
Fix the lower constraints settings to match the expected values.
We will manage the eventlet version using constraints now. See the
thread starting at
http://lists.openstack.org/pipermail/openstack-dev/2018-April/129096.html
for more details.
Change-Id: If7314a88a57bdd8db9bfa090e5e46c09c37a5087
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Use latest version of flake8-import-order package, like we do in
openstack/ironic
Fix two issues detected by new version.
Change-Id: I3d2f5499f3a863167419469d313e06be79f51841
Enable the following off-by-default checks:
* [H106] Don't put vim configuration in source files.
* [H203] Use assertIs(Not)None to check for None.
* [H204] Use assert(Not)Equal to check for equality.
* [H205] Use assert(Greater|Less)(Equal) for comparison.
* [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in
mock.patch/mock.patch.object calls
* [H904] Delay string interpolations at logging calls.
Fix code that failed [H904]. Nothing else failed the new added checks.
Change-Id: I727c944aad04298de07bcdd1d0008dcb9ffe32e9
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: Icb9a79cac0222db5261e8802b4b3b08c4d5e6ac2
Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: Ib3fde54d8baa2c6e3567ff3f1a902de4b25f9f70
Hacking's latest release is 0.11.0. Most other ironic projects are using
this release.
These updates are done project-by-project to avoid introducing
unexpected new hacking rules to projects. This version bump already
applies cleanly to ironic-lib with no code style changes.
Change-Id: I6e47390299bf8f073b8c8413f0cd4e1365f938bb
This patch fixes all sphinx warnings generated by malformed docstrings.
Additionally, it contains formatting and accuracy fixes for the metrics
docstrings, to ensure blockquotes are properly rendered, and to indicate
the get_metrics_logger() method is actually in metrics_utils.
Finally, this adds doc8 to the pep8 job, ensuring we don't reintroduce
some of these errors. As a note, there are items that can cause warnings
in doc builds that aren't enforced by doc8, and can't be enforced until
a doc build job is added to project-config.
Change-Id: I622812bfe8af576ab215c098dd211c6faf697a0c
Partial-bug: #1614272
Partial-bug: #1611559
This adds a doc build for ironic-lib. Currently the only documentation
is that generated from docstrings.
Change-Id: I6ee00ad863bc7ce72958db4e8d5b6871a5b96eb0
Partial-bug: #1614272
Takashi Kajinami